From patchwork Mon Feb 6 16:10:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 53407 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2320381wrn; Mon, 6 Feb 2023 08:13:23 -0800 (PST) X-Google-Smtp-Source: AK7set9eF+goBPHAcDJPTmlLdWbllnVeeL5Agy/tjuazlEEG3QMY0CnV2mJePcuMsNP7e0vmUq9a X-Received: by 2002:a17:90b:33d0:b0:22c:1331:9c59 with SMTP id lk16-20020a17090b33d000b0022c13319c59mr79327pjb.31.1675700003345; Mon, 06 Feb 2023 08:13:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675700003; cv=none; d=google.com; s=arc-20160816; b=znTui7eo8WU2FfQ7/15cmBq6w+uzSGCzOMxSrNsbry8fUB0gsVV7FtWCDfL6n21g/b yYgS2OXkS7IGiIzOAX7o+igdXgWavK3uS5NkSAbm4cHBcrlSi6ec31FBYY9c3VIT08lf sqmlGb8GcOK+dkq0d9vtkYCWbqILjSHRJBixpmsqy3iKvfYCK8r/ZIK0K4ffGll7GqPo KwLv3SwKm+Kf3frUVERdiYNAf4ulE3PqgiNEPzgW6kHYa4sjC3VR3RCQO60827YTUSk7 ey5w8FcOPXth93eNozaP53laQ6ryRCTMQ+lY2+gUR6hABflN3zp+01Yfs7tZmTrNRyCr JF4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=adk3xJpz9WGI02hkGX2wprqLAfjTxuBmaG1MAi/EbrY=; b=WGC2E2SOBXrntYmaYQKg25izyoO3cJFbyaANPra9A68XPNk5CVqGwfJLpy/M7Y9K9c 8ZBEd0JNMLRrtGDIW5dEpUYSImocy0i++xWTG1lAOOQ3LqTisNLIM5gyR+B9nRCrhYLP MLQGM1EeIMAerPMUPjOmd6qaca82vJgo0jIu+SC0dUuRuDmiPgJy0yOjrHfZklLOgDwU lkPq9eh/rB/A2IIFS0sQ7ekE7WqVhez+7T1FKz/U9PRcOZJYl1Kz6Uwqxcg0R+WzyoM8 HppKz1nxDNitO0n/VmqPD7ldqINH76v4ywG8/kSR2okXJdXr3cQVonqpDo9dCRHfvkiT +WPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=LvHTGWOT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fu1-20020a17090ad18100b00226ddf6b7ddsi12146516pjb.181.2023.02.06.08.13.11; Mon, 06 Feb 2023 08:13:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=LvHTGWOT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231682AbjBFQMF (ORCPT + 99 others); Mon, 6 Feb 2023 11:12:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231508AbjBFQMD (ORCPT ); Mon, 6 Feb 2023 11:12:03 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53E442ED49; Mon, 6 Feb 2023 08:11:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675699903; x=1707235903; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=6q1oqYzgNWSfxZgRT2J9mn+oyf7jlZ2Pq+SmMt+Wz70=; b=LvHTGWOT+4lYvlS+qtojUqASyyoz5+tUmpXI6j9xKqHTIERzYK9ueRCE Es+uN44OYiYLCV5FrINQjhqGYKZ0Z9+Ywr7jz9ZEUZX9RfSCYQXTWy24L R+o2qtfQRb1fDZ5DpF5m86DYya9NduQQXF5G4FZnixHfNzLMAxknfcPs1 8jRGS0flZ8ijFk0MtP5xQXPBxRFQSaLSZU1RT6zx+B8PtODcGOhZfAKWE ClDKcnQ5fKLgcpUBiUjpRR5a0YN6OugHIsT27fJ6tlmOCrQguhdhEuTRq JwCbox1aQwKBftOt/7hDGvaBrgBNWYvCvocZHdWpQI8UiogcseUiyKuOt w==; X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="308887658" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="308887658" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2023 08:10:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="616485720" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="616485720" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga003.jf.intel.com with ESMTP; 06 Feb 2023 08:10:14 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 71DD934D; Mon, 6 Feb 2023 18:10:52 +0200 (EET) From: Andy Shevchenko To: Mathias Nyman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mathias Nyman , Greg Kroah-Hartman , Andy Shevchenko Subject: [PATCH v1 4/7] xhci: mem: Drop useless return:s Date: Mon, 6 Feb 2023 18:10:46 +0200 Message-Id: <20230206161049.13972-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230206161049.13972-1-andriy.shevchenko@linux.intel.com> References: <20230206161049.13972-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757098806252688845?= X-GMAIL-MSGID: =?utf-8?q?1757098806252688845?= When function returns void and we have if-else-if chain, there is no need to explicitly call return. Drop them and indent lines better. While at it, make if chain sorted from testing bigger values to smaller. Signed-off-by: Andy Shevchenko --- drivers/usb/host/xhci-mem.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c index 34f5ba19471e..5c873e62c4d3 100644 --- a/drivers/usb/host/xhci-mem.c +++ b/drivers/usb/host/xhci-mem.c @@ -544,14 +544,11 @@ static void xhci_free_stream_ctx(struct xhci_hcd *xhci, size_t size = sizeof(struct xhci_stream_ctx) * num_stream_ctxs; if (size > MEDIUM_STREAM_ARRAY_SIZE) - dma_free_coherent(dev, size, - stream_ctx, dma); - else if (size <= SMALL_STREAM_ARRAY_SIZE) - return dma_pool_free(xhci->small_streams_pool, - stream_ctx, dma); + dma_free_coherent(dev, size, stream_ctx, dma); + else if (size > SMALL_STREAM_ARRAY_SIZE) + dma_pool_free(xhci->medium_streams_pool, stream_ctx, dma); else - return dma_pool_free(xhci->medium_streams_pool, - stream_ctx, dma); + dma_pool_free(xhci->small_streams_pool, stream_ctx, dma); } /*