From patchwork Mon Feb 6 13:58:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bastien Nocera X-Patchwork-Id: 53281 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2251937wrn; Mon, 6 Feb 2023 06:04:39 -0800 (PST) X-Google-Smtp-Source: AK7set9+wSQMpKWLQVy7ZhjgK4leS3gl9fy5TDWKc0afQdmyjZd7+0kHll19rw0aCu0+z/I3CMzC X-Received: by 2002:a05:6a21:3a86:b0:b6:40ae:823e with SMTP id zv6-20020a056a213a8600b000b640ae823emr21345663pzb.5.1675692279502; Mon, 06 Feb 2023 06:04:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675692279; cv=none; d=google.com; s=arc-20160816; b=R8vAeLJB2YPToygOGpvXpY7QXzYtn54XiCuXjc7NFP7Uh26DavZJOXNEZqv003ub91 chVsqSzRzLe0I8dHjLjotjGWhhZA0HLCsVLrJpyegZkpOte04aHMLiah9knbitm+mtk3 iXg81nRmHR4s93TVJ44BvZE3MsChyvxiUhJM0GX/OApkkl+5BMCTrFxzwomxsm9Zvxjf NCFGc2Dj1a/cmEtbdR0rAgYrwYxXrKQuZwyeqBhbClbE2LosXXWAG3ZPuNKxwDICCiNj 7fdmXUFvyX1w0tX3qTEE5DBwE/0m/9kVf2ouhzq2xp1wCPh+KL5HlpDZAAMA/QE2dcAT sruA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=fQfROqObbYzkbeaDSfY6Gip7EqHisQIvJ3wDE7yee50=; b=EWkKZ6QjOXTvxacoOG7LUtN34ml8CtxyMtDiXOq+2tq6AZEkSJO3/sE1+muoy91w7p xvMCaAfVnTd/ZZwAtA7mJRjv1MCopHZB7TjPHjQwz82imNOwTo8F6iOyeQnYA7/bCvBI L8KTuNr8/oOk0ts1a2mdnHMtdk+LlX+tTBo0PzY4K4oAM+dGGtPa4tv2oh//MkCXw+93 0l0J6ZP5dpS36WUp8bmn2959+ugZWfqozfk8pfL/Qw61AvybNZqcKo3MLCJIvjA5tc6X NiZiUHUVJMr3ekYixPmjOVC1JmAqAArRrKIXEuuuxWRiM66jACDKtAnEqgmbB/9Lhi2K Iadg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t71-20020a63814a000000b004f2d18b40dbsi12087644pgd.79.2023.02.06.06.04.02; Mon, 06 Feb 2023 06:04:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229941AbjBFN7R (ORCPT + 99 others); Mon, 6 Feb 2023 08:59:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229744AbjBFN7E (ORCPT ); Mon, 6 Feb 2023 08:59:04 -0500 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::223]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07B7B212BA; Mon, 6 Feb 2023 05:58:19 -0800 (PST) Received: (Authenticated sender: hadess@hadess.net) by mail.gandi.net (Postfix) with ESMTPSA id D244E60005; Mon, 6 Feb 2023 13:58:14 +0000 (UTC) From: Bastien Nocera To: linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , "Peter F . Patel-Schneider" , =?utf-8?q?Filipe_La?= =?utf-8?q?=C3=ADns?= , Nestor Lopez Casado Subject: [PATCH 2/3] HID: logitech-hidpp: Retry commands when device is busy Date: Mon, 6 Feb 2023 14:58:07 +0100 Message-Id: <20230206135808.8840-2-hadess@hadess.net> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230206135808.8840-1-hadess@hadess.net> References: <20230206135808.8840-1-hadess@hadess.net> MIME-Version: 1.0 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757090707555564728?= X-GMAIL-MSGID: =?utf-8?q?1757090707555564728?= Handle the busy error coming from the device or receiver. The documentation says a busy error can be returned when: " Device (or receiver) cannot answer immediately to this request for any reason i.e: - already processing a request from the same or another SW - pipe full " Signed-off-by: Bastien Nocera --- drivers/hid/hid-logitech-hidpp.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index 6386d3f023ca..ef497a82fe4e 100644 --- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers/hid/hid-logitech-hidpp.c @@ -295,6 +295,7 @@ static int hidpp_send_message_sync(struct hidpp_device *hidpp, */ *response = *message; +retry: ret = __hidpp_send_report(hidpp->hid_dev, message); if (ret) { @@ -321,6 +322,10 @@ static int hidpp_send_message_sync(struct hidpp_device *hidpp, response->report_id == REPORT_ID_HIDPP_VERY_LONG) && response->fap.feature_index == HIDPP20_ERROR) { ret = response->fap.params[1]; + if (ret == HIDPP20_ERROR_BUSY) { + dbg_hid("%s:got busy hidpp 2.0 error %02X, retrying\n", __func__, ret); + goto retry; + } dbg_hid("%s:got hidpp 2.0 error %02X\n", __func__, ret); goto exit; }