From patchwork Mon Feb 6 13:50:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 53271 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2248419wrn; Mon, 6 Feb 2023 06:00:00 -0800 (PST) X-Google-Smtp-Source: AK7set+OQHV+dJeepR+L9J10wX7Na/IBrebXaXzyO/FTJJfyylhZNzeWuqrHRztwUcRJNxLktn7t X-Received: by 2002:a50:998f:0:b0:4aa:b63f:a0e with SMTP id m15-20020a50998f000000b004aab63f0a0emr2293423edb.17.1675692000590; Mon, 06 Feb 2023 06:00:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675692000; cv=none; d=google.com; s=arc-20160816; b=yLQFdfwumojFzJhq4Arqx6rBos47BjLskDahCG17fQYLAt34dKo/45oBT07EQCexhm jo7Vnk91iUmYP0lDRUdjhnttIKbkwrx/N6AzVX9ZG/tfqQKI4XT09xd3wp/iI+mYO52z t7sRYsjqSoRBGKpWwjLE+NDg0AWaITmXWtl1+XGgLAj3NfUDcvsnrDiujLdZK1N57llg PiMU8GyRj0vWFRJkBMyRLxs0swCfbtUEGLb0s7UhGtMqPGjuy1mz6bIYinYfkNg88+Tm Nt1F13VZOecYjnBXg0ia3Aaqvs/JP093aVhlQ7WyrtzrU/8rDxcPm8dp90yi6sZ2zoMw z4HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=UfCaUBHX+3/LkfLzQuXrMd4bV7htIRYG6ar+kSsVHKo=; b=i+30d7+5rHEU6Xi0K4Es+Ybtb41tVHdbXUJLy72DWTyOaW+bISQXYiLKRx9VDxgCxb kSLnJfT/nCeW/lbgiyMHD2wp6ZTAqrmROKVi2Q8SfHACV6rewiL92t6Q5ZpCMQto7G+y UFe7XuRHgS3ylIiIXcftFxjNS1twcZUBj+nHQDHnv/53k+L7AQ58r3xrypwyzsckBs1d ukv78Q1oK1HHc8yRrd7q4g7ks9HF7jRYHMyDsXut3zFyO4IyWBVzWy/6V5AGwxw4Pgd3 aM6cMiQlyhqARzfAU/ftpD50gpYDe6Z0X4skpDkWd7+yWq+trfPjLIm669iAAi6JXLK+ Rn/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t17-20020aa7d711000000b004aaa96811dasi5547882edq.90.2023.02.06.05.59.35; Mon, 06 Feb 2023 06:00:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231280AbjBFNxM (ORCPT + 99 others); Mon, 6 Feb 2023 08:53:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231152AbjBFNvj (ORCPT ); Mon, 6 Feb 2023 08:51:39 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 782D77EF6 for ; Mon, 6 Feb 2023 05:51:22 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pP1tZ-0007Ko-Ev; Mon, 06 Feb 2023 14:50:57 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pP1tX-0034ek-98; Mon, 06 Feb 2023 14:50:56 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pP1tU-00DaOj-AU; Mon, 06 Feb 2023 14:50:52 +0100 From: Oleksij Rempel To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Wei Fang , Heiner Kallweit Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Arun.Ramadoss@microchip.com, intel-wired-lan@lists.osuosl.org Subject: [PATCH net-next v5 07/23] net: phy: c45: migrate to genphy_c45_write_eee_adv() Date: Mon, 6 Feb 2023 14:50:34 +0100 Message-Id: <20230206135050.3237952-8-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230206135050.3237952-1-o.rempel@pengutronix.de> References: <20230206135050.3237952-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757090414993607648?= X-GMAIL-MSGID: =?utf-8?q?1757090414993607648?= Migrate from genphy_config_eee_advert() to genphy_c45_write_eee_adv(). It should work as before except write operation to the EEE adv registers will be done only if some EEE abilities was detected. If some driver will have a regression, related driver should provide own .get_features callback. See micrel.c:ksz9477_get_features() as example. Signed-off-by: Oleksij Rempel Reviewed-by: Andrew Lunn --- drivers/net/phy/phy-c45.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c index 38361df1e669..23ecb12714b6 100644 --- a/drivers/net/phy/phy-c45.c +++ b/drivers/net/phy/phy-c45.c @@ -262,7 +262,11 @@ int genphy_c45_an_config_aneg(struct phy_device *phydev) linkmode_and(phydev->advertising, phydev->advertising, phydev->supported); - changed = genphy_config_eee_advert(phydev); + ret = genphy_c45_write_eee_adv(phydev, phydev->supported_eee); + if (ret < 0) + return ret; + else if (ret) + changed = true; if (genphy_c45_baset1_able(phydev)) return genphy_c45_baset1_an_config_aneg(phydev); @@ -968,6 +972,11 @@ int genphy_c45_pma_read_abilities(struct phy_device *phydev) } } + /* This is optional functionality. If not supported, we may get an error + * which should be ignored. + */ + genphy_c45_read_eee_abilities(phydev); + return 0; } EXPORT_SYMBOL_GPL(genphy_c45_pma_read_abilities);