From patchwork Mon Feb 6 13:50:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 53256 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2245482wrn; Mon, 6 Feb 2023 05:52:53 -0800 (PST) X-Google-Smtp-Source: AK7set9Bql8baY2Y/FDoAx6wj0JHd9jmVZ86l2oqhPVVms2u24tzgM7OBhC8K+pOssYm8ccAv8LY X-Received: by 2002:a17:906:8a63:b0:888:7ce4:1dc1 with SMTP id hy3-20020a1709068a6300b008887ce41dc1mr20382750ejc.26.1675691573050; Mon, 06 Feb 2023 05:52:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675691573; cv=none; d=google.com; s=arc-20160816; b=JHQOXxO3MDgGkZZ3cIgBg8XA3s6S0z/GwQg66WeCgn6p5tcldlGT5COwWGYAoq0Ek0 RNOP5AYFLi7Q+Tu+R203p0MS9Su4JlTeCxdU0wHNLVXxBHGI3w4gHeGjfLf/2Eg3l9ue 0PcUbC/QajUmZMsmWEz4VKXXRyR8T4syy1/zFoOT75ZUZ/xNuxymTmYKByopaoeVqSwQ 8YkU130xdH1tg1n9sjGyRh3cq26FsovmhTQBfpDn8o1TYOT+OzkBUwmDY5S6YqJh0sUp jHc23mljHZnoHqFZ9kRKH+nON2TmlNaDKePYvAqCmtfyZtZph+mR3Tz7zsyF/tO2klyV bb8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=3XLu6rj+X7cX3peT/w79iuU4hqO+twT0e+LhM7Q6L0Q=; b=U0SzegHr6JGpCxczqkCx0SNJFvY+bWF9aCi6XT4wjs/pzhs7PVBhpkGjzzoeU1a2Os FVef1JwrEd9CgDyjrRVBDnqBqIcjifD2ziQofMydjf6EG7BaHE1LBOnUSAzmaXtUMXri q6k6xLyUQxiCsep95HxWq45dMNdQC4yE5Ig7R+T+hkkrtNH+OeuutqhB2yFsR/syMq9m dQrf+3F88kN0E+Dfe3YgVBV6o8LrnU6sEz8J9/vrOs5BOOMB1j+0lSwV+G6Ju+7AlIbh uBFe0O/LgPGI2yCBnjXnfq3xE7cqfUn+nE00W7wUurRdWG/z7pptADOg1z2IS70/J3fj JeLw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ey7-20020a0564022a0700b004a212080564si13024620edb.339.2023.02.06.05.52.30; Mon, 06 Feb 2023 05:52:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229557AbjBFNvc (ORCPT + 99 others); Mon, 6 Feb 2023 08:51:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230392AbjBFNvW (ORCPT ); Mon, 6 Feb 2023 08:51:22 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D71425945 for ; Mon, 6 Feb 2023 05:51:04 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pP1tX-0007EC-4c; Mon, 06 Feb 2023 14:50:55 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pP1tU-0034dT-FJ; Mon, 06 Feb 2023 14:50:53 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pP1tU-00DaOa-8b; Mon, 06 Feb 2023 14:50:52 +0100 From: Oleksij Rempel To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Wei Fang , Heiner Kallweit Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Arun.Ramadoss@microchip.com, intel-wired-lan@lists.osuosl.org Subject: [PATCH net-next v5 06/23] net: phy: c22: migrate to genphy_c45_write_eee_adv() Date: Mon, 6 Feb 2023 14:50:33 +0100 Message-Id: <20230206135050.3237952-7-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230206135050.3237952-1-o.rempel@pengutronix.de> References: <20230206135050.3237952-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757089966953320259?= X-GMAIL-MSGID: =?utf-8?q?1757089966953320259?= Migrate from genphy_config_eee_advert() to genphy_c45_write_eee_adv(). It should work as before except write operation to the EEE adv registers will be done only if some EEE abilities was detected. If some driver will have a regression, related driver should provide own .get_features callback. See micrel.c:ksz9477_get_features() as example. Signed-off-by: Oleksij Rempel Reviewed-by: Andrew Lunn --- drivers/net/phy/phy_device.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 66a4e62009bb..8d927c5e3bf8 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -2231,7 +2231,10 @@ int __genphy_config_aneg(struct phy_device *phydev, bool changed) { int err; - if (genphy_config_eee_advert(phydev)) + err = genphy_c45_write_eee_adv(phydev, phydev->supported_eee); + if (err < 0) + return err; + else if (err) changed = true; err = genphy_setup_master_slave(phydev); @@ -2653,6 +2656,11 @@ int genphy_read_abilities(struct phy_device *phydev) phydev->supported, val & ESTATUS_1000_XFULL); } + /* This is optional functionality. If not supported, we may get an error + * which should be ignored. + */ + genphy_c45_read_eee_abilities(phydev); + return 0; } EXPORT_SYMBOL(genphy_read_abilities);