From patchwork Mon Feb 6 13:50:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 53273 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2249434wrn; Mon, 6 Feb 2023 06:01:23 -0800 (PST) X-Google-Smtp-Source: AK7set+3lUjgCh1TO/FRULSMYyMcwxPfp+0ZLSzHW2HPuFpTm5/Rmy1SpSjRtdjNfNHafTOO3W8L X-Received: by 2002:a17:907:8c85:b0:7ad:aed7:a5da with SMTP id td5-20020a1709078c8500b007adaed7a5damr23103530ejc.28.1675692083258; Mon, 06 Feb 2023 06:01:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675692083; cv=none; d=google.com; s=arc-20160816; b=JKJ/CJTRAYBXFGIqP4ELgehJH9Hg+G6KIKajy0dF+JOkbMvHgEO3W4peW9seISHcPN yt0iZsNVzjE9ZQuThUc9BnzJCtPLho6Lh0P4vTlF5t/wjHfjdjd/IQ6PwQg1cFhcZrts 9PP3mtqX9v70+oHCjzRkGgmMS+Ll7oD+/nVt3qT+1coBAyhHkqvJFnRmiISC7jp8c4aH BqtWLttRnv5+MqBibsiwE+GcAftEekwbJCl5IkNBUkXJw/S2GK1RRpNQACAHG6scmr1n bFa1pB68MZq38j4r9h6312difOq3Qt2RN4QNnxrU2eKdbdsFOYsS3QgcumggBLR4LatU +cuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=YUcnu+gZKSsaxR2WuMb3Vd1Ih+cNr5/VZJSkkKEFCo8=; b=H0nEcr3ZdSZBWqkr9R1AdVa+nQPhaBqT2qdNsrW+ZvUSY3lcvWXGeHIE++ZuCqg9lr pWytTD9TZzAX9kyg47W9MV5gYERpBnp8bQJRuFvOnna8t5eTHhsxdGqox5y4yTiMqUHo pbvOuAZrWPexRmsqI+lrz+m/XbGrQ6wokOhk9WUnqs5UaswA9/r1JR5X0BL8gGMpsgkO tQZVcNE0NoWk+mrBVogHabu+FfUU8mE+EmzBLRBsRdYsrPLgp9U8CudESb4yCsfEy5ea OrLUr8YSSIndy2ryp/EMZ8hrK8AjCzj5G690Q0p0BoxeHgDqk07ObGBwPiwNQ4pxqE3T EP1Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id uj3-20020a170907c98300b008778e608891si12524777ejc.256.2023.02.06.06.01.00; Mon, 06 Feb 2023 06:01:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231252AbjBFNxB (ORCPT + 99 others); Mon, 6 Feb 2023 08:53:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231147AbjBFNvj (ORCPT ); Mon, 6 Feb 2023 08:51:39 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30E3A1F49F for ; Mon, 6 Feb 2023 05:51:22 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pP1tZ-0007J8-1m; Mon, 06 Feb 2023 14:50:57 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pP1tW-0034eS-P6; Mon, 06 Feb 2023 14:50:55 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pP1tV-00DaQy-Ap; Mon, 06 Feb 2023 14:50:53 +0100 From: Oleksij Rempel To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Wei Fang , Heiner Kallweit Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Arun.Ramadoss@microchip.com, intel-wired-lan@lists.osuosl.org Subject: [PATCH net-next v5 20/23] tg3: replace EEE ethtool helpers to linkmode variants Date: Mon, 6 Feb 2023 14:50:47 +0100 Message-Id: <20230206135050.3237952-21-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230206135050.3237952-1-o.rempel@pengutronix.de> References: <20230206135050.3237952-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757090501910963163?= X-GMAIL-MSGID: =?utf-8?q?1757090501910963163?= Replace EEE ethtool helpers with linkmode variants. This will reduce similar code snippets and prepare ethtool EEE interface to linkmode migration. Signed-off-by: Oleksij Rempel --- drivers/net/ethernet/broadcom/tg3.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index 58747292521d..ba1913e88372 100644 --- a/drivers/net/ethernet/broadcom/tg3.c +++ b/drivers/net/ethernet/broadcom/tg3.c @@ -2339,6 +2339,8 @@ static void tg3_phy_apply_otp(struct tg3 *tp) static void tg3_eee_pull_config(struct tg3 *tp, struct ethtool_eee *eee) { + __ETHTOOL_DECLARE_LINK_MODE_MASK(adv) = {}; + __ETHTOOL_DECLARE_LINK_MODE_MASK(lp) = {}; u32 val; struct ethtool_eee *dest = &tp->eee; @@ -2361,13 +2363,16 @@ static void tg3_eee_pull_config(struct tg3 *tp, struct ethtool_eee *eee) /* Pull lp advertised settings */ if (tg3_phy_cl45_read(tp, MDIO_MMD_AN, MDIO_AN_EEE_LPABLE, &val)) return; - dest->lp_advertised = mmd_eee_adv_to_ethtool_adv_t(val); + mii_eee_cap1_mod_linkmode_t(lp, val); + ethtool_convert_link_mode_to_legacy_u32(&dest->lp_advertised, lp); + /* Pull advertised and eee_enabled settings */ if (tg3_phy_cl45_read(tp, MDIO_MMD_AN, MDIO_AN_EEE_ADV, &val)) return; dest->eee_enabled = !!val; - dest->advertised = mmd_eee_adv_to_ethtool_adv_t(val); + mii_eee_cap1_mod_linkmode_t(adv, val); + ethtool_convert_link_mode_to_legacy_u32(&dest->advertised, adv); /* Pull tx_lpi_enabled */ val = tr32(TG3_CPMU_EEE_MODE);