From patchwork Mon Feb 6 13:50:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 53267 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2245887wrn; Mon, 6 Feb 2023 05:53:41 -0800 (PST) X-Google-Smtp-Source: AK7set+T2kTyJeDFqzRsnmpCIiGiy8/vE9wVqT4qH2mVfEw/gIUE4wq17FNCgZVk1xWeDxQ8vue1 X-Received: by 2002:a50:955b:0:b0:4aa:c68c:5441 with SMTP id v27-20020a50955b000000b004aac68c5441mr135451eda.16.1675691620966; Mon, 06 Feb 2023 05:53:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675691620; cv=none; d=google.com; s=arc-20160816; b=yNuUZ9On+FRN5EpUp2/N6pWkwAFAaUiukAyoqYN4PKWgcyHC2HKbCf1FLuIxaRtohb dQlOroCj+Q1sJ7cSkVeat3/eEO8Mbd/cPN9AixFCh/O8OpDSUWHi+EjDEZJCItQORyct atg6/oep2tLeCgub9cxZsMOiqmipljSjIBVpXEYf0YUm1xvwaGCflxbnznZC2P1b/cGb wNtapKBwZHrkMWpkijr7oWEDeJ0n+eQBiMJ9N051JPLNyIKGsQZdq2vn4d1q5yklmSVC RzT7WonufEYMrfDp5ymFMQyLwFeMPJ6itIwmAORu2eLx8fy44+ftTh8VJv7ngsu+shfp ch8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=rbmh5yUNjpZV6g1TXnEwaMyJAXwP5cdXeNM56svkGzc=; b=AfjUDh1NOHkcQBTBTLu+OGcdgNI9m6EoarPuZOD4gaXaN8QWHYCD/J3txvM0wCP1Yx E9d6+1oF1U1VVYvV6J5E2Dl0AbEsHkRbAE6KsEvyBh5kpVPCg4MygQM0gXqHDWgMCuFc fZqCHk22lYzyilPUe49xBhkCOoDRqyHrC5rr0LuXwG96c3FQaUOxnRQBEPyAZZhLk2dn zCMsKBqekiPpETJXNVY20yU0J+Z+abodTBsRssyUKpd3emEW4Quz9DHhcQirF1iUQujt KFMb+M1IG0VzIBaeXqULivXCrShjc+Sh3PZAYt9vtE3qsTHy9sbYFKHyaW0s3ffXzEwN mP1Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y8-20020aa7ccc8000000b004aaaa4fd154si4975443edt.562.2023.02.06.05.53.18; Mon, 06 Feb 2023 05:53:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230266AbjBFNwB (ORCPT + 99 others); Mon, 6 Feb 2023 08:52:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230337AbjBFNvb (ORCPT ); Mon, 6 Feb 2023 08:51:31 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D298D21A2D for ; Mon, 6 Feb 2023 05:51:10 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pP1tY-0007Hk-Bm; Mon, 06 Feb 2023 14:50:56 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pP1tW-0034eH-8Z; Mon, 06 Feb 2023 14:50:55 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pP1tV-00DaQJ-1A; Mon, 06 Feb 2023 14:50:53 +0100 From: Oleksij Rempel To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Wei Fang , Heiner Kallweit Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Arun.Ramadoss@microchip.com, intel-wired-lan@lists.osuosl.org Subject: [PATCH net-next v5 16/23] net: fec: add support for PHYs with SmartEEE support Date: Mon, 6 Feb 2023 14:50:43 +0100 Message-Id: <20230206135050.3237952-17-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230206135050.3237952-1-o.rempel@pengutronix.de> References: <20230206135050.3237952-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757090017243249754?= X-GMAIL-MSGID: =?utf-8?q?1757090017243249754?= Ethernet controller in i.MX6*/i.MX7* series do not provide EEE support. But this chips are used sometimes in combinations with SmartEEE capable PHYs. So, instead of aborting get/set_eee access on MACs without EEE support, ask PHY if it is able to do the EEE job by using SmartEEE. Signed-off-by: Oleksij Rempel --- drivers/net/ethernet/freescale/fec_main.c | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index c73e25f8995e..00f3703db69d 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -3102,8 +3102,15 @@ fec_enet_get_eee(struct net_device *ndev, struct ethtool_eee *edata) struct fec_enet_private *fep = netdev_priv(ndev); struct ethtool_eee *p = &fep->eee; - if (!(fep->quirks & FEC_QUIRK_HAS_EEE)) - return -EOPNOTSUPP; + if (!(fep->quirks & FEC_QUIRK_HAS_EEE)) { + if (!netif_running(ndev)) + return -ENETDOWN; + + if (!phy_has_smarteee(ndev->phydev)) + return -EOPNOTSUPP; + + return phy_ethtool_get_eee(ndev->phydev, edata); + } if (!netif_running(ndev)) return -ENETDOWN; @@ -3123,8 +3130,15 @@ fec_enet_set_eee(struct net_device *ndev, struct ethtool_eee *edata) struct ethtool_eee *p = &fep->eee; int ret = 0; - if (!(fep->quirks & FEC_QUIRK_HAS_EEE)) - return -EOPNOTSUPP; + if (!(fep->quirks & FEC_QUIRK_HAS_EEE)) { + if (!netif_running(ndev)) + return -ENETDOWN; + + if (!phy_has_smarteee(ndev->phydev)) + return -EOPNOTSUPP; + + return phy_ethtool_set_eee(ndev->phydev, edata); + } if (!netif_running(ndev)) return -ENETDOWN;