From patchwork Mon Feb 6 11:46:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "D. Starke" X-Patchwork-Id: 53197 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2188843wrn; Mon, 6 Feb 2023 03:54:34 -0800 (PST) X-Google-Smtp-Source: AK7set/4FPMv26lBTBLzORD/VOpyLVEMYdAKmpCHF/xSg7ICY8v+LkfPGuzsgbrk6ikjfUvHlB5s X-Received: by 2002:a17:906:a88e:b0:87a:3aff:cffa with SMTP id ha14-20020a170906a88e00b0087a3affcffamr18672762ejb.27.1675684474116; Mon, 06 Feb 2023 03:54:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675684474; cv=none; d=google.com; s=arc-20160816; b=ZOQxK6ugqH5x+g3fepB6l2MRYLca7jebP6v8RfTxrZva8CjvCMUg4A+ufQoHTzPrgm Jm7PD+2z3QGF0oPtXtJ494IlgG8Tnka6yGPYu0p3DbktTCPhbmlsOC3s3w9XQm6Yezp0 ZEhoOTnLdp9l4BjqAdKIaZ4iD0BarYmQgq5GjG8j2XgcYK9ew2yKx4rfQtQ69BCN2//i bsMzDssFSlkmORsB04ll63s2QW5TfS+ZRVeLwljh0Bki1pv7GpUeiZy7x3dDp/CG88t4 HnYfvzeysazfRyxFadcocH4NocorGCmvQKPCMJVBi6qgePqsENo8XL22+f++nG+kDgpq aJcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:feedback-id:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=wS7DCQJ3CnjHhUZAXPDyQtVIoeoWJA5RCvr8dQtB6ns=; b=rsVN5LhQeG6sk5C4Fadol7TRdqJVLs/popPRtLyN8PyZkk70muO6080YX4NEQlcu0q ka8Qa+sQhkKkKtj+xY9GDAs61gGUIRpcsrFep0bkBCJ8sebjTb6HzgoNhn/GHiixCxzj yd4LWI6VKmpupkJjpO5cdAh66VuNq6RrmGq4Gry5+CbUdsnBDdAPiX6yJEE+ntJqff96 rYjG82ctA887+uyVh67vn74oAmwn0UD1/3LdaSa3yUVZAOXnJlSCAtOO/Gd0zegYUx+c XmBJceFA7o+DF62dkwyy5oShRDOlz5VltOfIYgm0VMiF93ZnxyYCtUweqp32b0OR72ph MqzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b="e/KSb6r7"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fq4-20020a1709069d8400b00892bd6aca11si7351580ejc.13.2023.02.06.03.54.11; Mon, 06 Feb 2023 03:54:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b="e/KSb6r7"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229630AbjBFLrl (ORCPT + 99 others); Mon, 6 Feb 2023 06:47:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229628AbjBFLrk (ORCPT ); Mon, 6 Feb 2023 06:47:40 -0500 Received: from mta-64-228.siemens.flowmailer.net (mta-64-228.siemens.flowmailer.net [185.136.64.228]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BB4C30E9 for ; Mon, 6 Feb 2023 03:47:37 -0800 (PST) Received: by mta-64-228.siemens.flowmailer.net with ESMTPSA id 2023020611473405ec702c36a2ec9083 for ; Mon, 06 Feb 2023 12:47:34 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm1; d=siemens.com; i=daniel.starke@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc; bh=wS7DCQJ3CnjHhUZAXPDyQtVIoeoWJA5RCvr8dQtB6ns=; b=e/KSb6r7YnuAcqRH1RaUxjgAutpUc7UdxF4/5oW+APJ3S88wqhSV/2O+sRiy7hpIMlqk2a mmt+Ej/38zRQeMdgP/+bUK6dOkodF5vbt4ODti05gn7qKkzZF/QZ+pvxxARhtM91FaBn2KMg drfdyw+BBUIYuE2sGd+I17qat+L98=; From: "D. Starke" To: linux-serial@vger.kernel.org, gregkh@linuxfoundation.org, jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com Cc: linux-kernel@vger.kernel.org, Daniel Starke Subject: [PATCH v4 1/4] tty: n_gsm: mark unusable ioctl structure fields accordingly Date: Mon, 6 Feb 2023 12:46:03 +0100 Message-Id: <20230206114606.2133-1-daniel.starke@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-314044:519-21489:flowmailer X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757082523059925963?= X-GMAIL-MSGID: =?utf-8?q?1757082523059925963?= From: Daniel Starke gsm_config and gsm_netconfig includes unused fields that have been included to allow future extension without changing the structure size. Unfortunately, no checks have been included for these field. The actual value set by old user space code remains undefined. This means that future extensions can not use these fields without breaking old user space code which may set unexpected values. Mark these fields accordingly to avoid breaking code changes. Signed-off-by: Daniel Starke --- include/uapi/linux/gsmmux.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) v3 -> v4: No changes. Link: https://lore.kernel.org/all/20230203145023.6012-1-daniel.starke@siemens.com/ diff --git a/include/uapi/linux/gsmmux.h b/include/uapi/linux/gsmmux.h index cb8693b39cb7..785d6b253f6d 100644 --- a/include/uapi/linux/gsmmux.h +++ b/include/uapi/linux/gsmmux.h @@ -19,8 +19,7 @@ struct gsm_config unsigned int mtu; unsigned int k; unsigned int i; - unsigned int unused[8]; /* Padding for expansion without - breaking stuff */ + unsigned int unused[8]; /* Can not be used */ }; #define GSMIOC_GETCONF _IOR('G', 0, struct gsm_config) @@ -29,9 +28,9 @@ struct gsm_config struct gsm_netconfig { unsigned int adaption; /* Adaption to use in network mode */ unsigned short protocol;/* Protocol to use - only ETH_P_IP supported */ - unsigned short unused2; + unsigned short unused2; /* Can not be used */ char if_name[IFNAMSIZ]; /* interface name format string */ - __u8 unused[28]; /* For future use */ + __u8 unused[28]; /* Can not be used */ }; #define GSMIOC_ENABLE_NET _IOW('G', 2, struct gsm_netconfig)