From patchwork Mon Feb 6 07:20:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiapeng Chong X-Patchwork-Id: 53049 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2098570wrn; Sun, 5 Feb 2023 23:27:48 -0800 (PST) X-Google-Smtp-Source: AK7set/mXoskmtzIIKRkFcakyW9ozlfbC9TIuPHX9LcJd1Why9lyLfzAagK8BZSEajcaSnm8KEy8 X-Received: by 2002:a50:baa8:0:b0:4aa:a36a:3e44 with SMTP id x37-20020a50baa8000000b004aaa36a3e44mr6271319ede.33.1675668468211; Sun, 05 Feb 2023 23:27:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675668468; cv=none; d=google.com; s=arc-20160816; b=TSAX9eXRtaskZsHym6ltCacGVYE9uYbMcutjrknG9vBmiNfhS5tGRodS/GEzLYQQDU aD3qGjEF7mCd4yedCNGFMPu87IGGOzetIxtend+57b2yb+xpZtP63IOaiB+Cxiy//v0X WbxhO62Ye6yi3Zcuoeq+QhXKzdapeMYdUukyYkVg6gZON6GfLU0PVc4w4aIBnNrQ65jR 76Bqa+R818NL4/Ye+4cgu2QocPwWYSaUOwnP5Nl92ugt77mhWnhpb8xesA90kdGNL1jJ 6hXsAmsT2FP09yoNy3ckKAxHM852BVhZGlNdSVjWLD3Ju1dAQbQoDA1Los+rlj4/rkcB t+VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=JVzB7ecTRBvl/5Y3VVMqarIxNmKNfh8tus1x7TVZ1vk=; b=JkNix+SYMFmE/7rvV00hlrHyn9bGJnMFVejsEm+4kb3Uh2TNaf6YHDzasTFU2YGTD+ BgfWvm5Dub4OJLdoYY+h4ku9/ZTR7BiIH0FDAKhh4mqlC2KdplgM1RFX1tlxrYaWeW8l BiNR/nh2N0K6Y6tVixsH2OAOE4pC6sOOdRevXEhtxe2Gvxufl7uCTDjZVWKsU9eEnHzW Uv/GgjoCtnEyhzMp6IdObhAMdUK0vKTBSMgWt6bo8W8wC61960BQ5H505HKAPpAHPfX3 639tX4lNxcXssjIu2QPfsqd4CQZdl5Bn1p0ldpr7gfSQMZ6ypeQynfYxDGlnB4jHBGVZ PeoA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n21-20020a05640205d500b0049eeaaa3f27si10733672edx.433.2023.02.05.23.27.18; Sun, 05 Feb 2023 23:27:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229525AbjBFHVr (ORCPT + 99 others); Mon, 6 Feb 2023 02:21:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbjBFHVq (ORCPT ); Mon, 6 Feb 2023 02:21:46 -0500 Received: from out30-113.freemail.mail.aliyun.com (out30-113.freemail.mail.aliyun.com [115.124.30.113]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19FEA1ABED; Sun, 5 Feb 2023 23:21:43 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0Vb-4CDB_1675668031; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0Vb-4CDB_1675668031) by smtp.aliyun-inc.com; Mon, 06 Feb 2023 15:21:39 +0800 From: Jiapeng Chong To: linkinjeon@kernel.org Cc: sfrench@samba.org, senozhatsky@chromium.org, tom@talpey.com, linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH] ksmbd: Fix parameter name and comment mismatch Date: Mon, 6 Feb 2023 15:20:29 +0800 Message-Id: <20230206072029.32574-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757065739254130241?= X-GMAIL-MSGID: =?utf-8?q?1757065739254130241?= fs/ksmbd/vfs.c:965: warning: Function parameter or member 'attr_value' not described in 'ksmbd_vfs_setxattr'. Reported-by: Abaci Robot Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3946 Signed-off-by: Jiapeng Chong Acked-by: Namjae Jeon Reviewed-by: Sergey Senozhatsky --- fs/ksmbd/vfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/ksmbd/vfs.c b/fs/ksmbd/vfs.c index aa1300b7bfc2..5ea9229dad2c 100644 --- a/fs/ksmbd/vfs.c +++ b/fs/ksmbd/vfs.c @@ -952,9 +952,9 @@ ssize_t ksmbd_vfs_getxattr(struct mnt_idmap *idmap, * ksmbd_vfs_setxattr() - vfs helper for smb set extended attributes value * @idmap: idmap of the relevant mount * @dentry: dentry to set XATTR at - * @name: xattr name for setxattr - * @value: xattr value to set - * @size: size of xattr value + * @attr_name: xattr name for setxattr + * @attr_value: xattr value to set + * @attr_size: size of xattr value * @flags: destination buffer length * * Return: 0 on success, otherwise error