From patchwork Sat Feb 4 13:30:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pin-yen Lin X-Patchwork-Id: 52775 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1352754wrn; Sat, 4 Feb 2023 05:33:36 -0800 (PST) X-Google-Smtp-Source: AK7set/a4zj36xkTmJiXCueklgOc4aq1xKX0mFeEFpglSFZquLSXys94k4AMEvQnNdnYO2efDmJQ X-Received: by 2002:a17:902:e841:b0:198:a372:3e67 with SMTP id t1-20020a170902e84100b00198a3723e67mr15092674plg.27.1675517616239; Sat, 04 Feb 2023 05:33:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675517616; cv=none; d=google.com; s=arc-20160816; b=BIkCvImbAPE3hhZmkzGlFDNoDbiAtFBQu3h8r3V82aZeh/ntpwUQVlNHnr/D+DL7TP 2e7n12LelAKIYW4bktVip3rmVIyokGbMYDRBc2NiEmVFu6B0Zwk5VRyovGsmZ4L3iF3y HrEhnUtMMOeTXKokOfcVzPkJ7ij9zMpKshibZUbR7KTbalDFyXgRGfVhC1Bmz/tXNAqI 34JJawGkbAQJDaqYRSZuZqpz1mBGK6ivooMH96yh5taOHf1dj4ZN8cU36Vo5vF+s/OPR sjQs02mUp9Fgu7UOXgcQkuQxu+/Su+pU3Iiyp565myeKyuZlmlEMt0J9mEW/4KH29TEv qfwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=bzf2jVYplA8aE3AG7mF8tjqc7YfVHNzTvjn8QCL8QQE=; b=bCM1PD56iNmWwvPeN0g+3QprEYXmthz19ldpP9thrw0iHjokDGpSn04Vi2xJsKSFZW UX5bNKl6NQXDP4Q8UsLqUXvsDEPuyGb7rSlwXdpCQNvvBHbGK8482QTha/kUbsESuCYC tg6RbYJAPrj2F617xygr+ZZz4qXQ1oQZsxw7KManVz+SObih4RxGdraHdfBxnWdl5shf 2tTCYGnIh8xacbMuUvrIK9yvDhbxMc/9hnNS0ANFnv+dg0SaEo3AksZqYe/pKgaeUTh9 gaTTntCk9By+VxDNZQ5j49H+T5nt8UJT3t7Bs2b/AcmLxpj9Y3DeXbrueg51etkXUHHO UuwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=XOar4LHD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v11-20020a63bf0b000000b00478ff3661d1si5607020pgf.440.2023.02.04.05.33.24; Sat, 04 Feb 2023 05:33:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=XOar4LHD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233695AbjBDNbJ (ORCPT + 99 others); Sat, 4 Feb 2023 08:31:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233676AbjBDNbF (ORCPT ); Sat, 4 Feb 2023 08:31:05 -0500 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 153C83647E for ; Sat, 4 Feb 2023 05:31:03 -0800 (PST) Received: by mail-pf1-x42f.google.com with SMTP id 203so5552137pfx.6 for ; Sat, 04 Feb 2023 05:31:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bzf2jVYplA8aE3AG7mF8tjqc7YfVHNzTvjn8QCL8QQE=; b=XOar4LHD9c/G8nWjPa8i0IQvwhxfLXWogWDL1nY00qKfe23sg9JlyEHPfwz+CEeo92 GLaqvjPSWVv4K2TTudUs5ZF5iSuQ0FJ7X/5Y4WWrX/XZH9PLpGL6A0gvh8MEtDhfwc+K TCRFMMiqfzJygsnq2ww+OpoMZmv0Skk8blvjc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bzf2jVYplA8aE3AG7mF8tjqc7YfVHNzTvjn8QCL8QQE=; b=P92aA9qS5BbMmGIY7Gfsd0CPDFOrvi47M64sZsrlPoo85m3Du6w9C9Pe6I++X+biMp Nf7CgOgmsWAycd0bhUB5leW0UDZ+0yG9xpUCPknJCtBLXSoMXrWm3CxGNbch37caXQk6 ioxMW4k6FWE+aeBpJZ3WwjwfaXWSjL+UPSIJfu+4v4fTDXlncMUbFZ2rRsnC6L/2Fa4o wTeAbKAEwmTpOnHFSeTE+ecJcFEHs3CevasEMsGorUgoVMbEHnJH6TkwKymzwe4g3eLQ 38xzEzY+bTbzcHF3bv/rPubvavh12iu/2mvPsrRfQNv8IlOav6L1vt9x0QY5+goQtcTl f4oQ== X-Gm-Message-State: AO0yUKXV0Nxf33OYBuWQHd5ixl1x1PFb8nr3qTCdvSmA/JL+MmPPDkKN cDfu3QY2uk5tvG1g92LUP4GEvQ== X-Received: by 2002:aa7:80c6:0:b0:592:de72:4750 with SMTP id a6-20020aa780c6000000b00592de724750mr11680416pfn.23.1675517462757; Sat, 04 Feb 2023 05:31:02 -0800 (PST) Received: from treapking.tpe.corp.google.com ([2401:fa00:1:10:c1ad:2bdc:7b5a:72e3]) by smtp.gmail.com with ESMTPSA id 144-20020a621596000000b00593ce7ebbaasm3655639pfv.184.2023.02.04.05.30.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Feb 2023 05:31:02 -0800 (PST) From: Pin-yen Lin To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J . Wysocki" , Prashant Malani , Benson Leung , Guenter Roeck Cc: linux-kernel@vger.kernel.org, =?utf-8?q?N=C3=ADcolas_F_=2E_R_=2E_A_=2E_P?= =?utf-8?q?rado?= , Hsin-Yi Wang , devicetree@vger.kernel.org, Pin-yen Lin , Allen Chen , Lyude Paul , linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org, Marek Vasut , Xin Ji , Stephen Boyd , AngeloGioacchino Del Regno , Thomas Zimmermann , Javier Martinez Canillas , chrome-platform@lists.linux.dev, Chen-Yu Tsai Subject: [PATCH v11 2/9] platform/chrome: cros_ec_typec: Purge blocking switch devlinks Date: Sat, 4 Feb 2023 21:30:33 +0800 Message-Id: <20230204133040.1236799-3-treapking@chromium.org> X-Mailer: git-send-email 2.39.1.519.gcb327c4b5f-goog In-Reply-To: <20230204133040.1236799-1-treapking@chromium.org> References: <20230204133040.1236799-1-treapking@chromium.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756907560040222427?= X-GMAIL-MSGID: =?utf-8?q?1756907560040222427?= From: Prashant Malani When using OF graph, the fw_devlink code will create links between the individual port driver (cros-ec-typec here) and the parent device for a Type-C switch (like mode-switch). Since the mode-switch will in turn have the usb-c-connector (i.e the child of the port driver) as a supplier, fw_devlink will not be able to resolve the cyclic dependency correctly. As a result, the mode-switch driver probe() never runs, so mode-switches are never registered. Because of that, the port driver probe constantly fails with -EPROBE_DEFER, because the Type-C connector class requires all switch devices to be registered prior to port registration. To break this deadlock and allow the mode-switch registration to occur, purge all the usb-c-connector nodes' absent suppliers. This eliminates the connector as a supplier for a switch and allows it to be probed. Signed-off-by: Prashant Malani Signed-off-by: Pin-yen Lin Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai Acked-by: Heikki Krogerus --- Changes in v11: - Collected Acked-by tag Changes in v10: - Collected Reviewed-by and Tested-by tags Changes in v7: - Fix the long comment lines Changes in v6: - New in v6 drivers/platform/chrome/cros_ec_typec.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c index 2a7ff14dc37e..302474a647cc 100644 --- a/drivers/platform/chrome/cros_ec_typec.c +++ b/drivers/platform/chrome/cros_ec_typec.c @@ -382,6 +382,16 @@ static int cros_typec_init_ports(struct cros_typec_data *typec) return -EINVAL; } + /* + * OF graph may have set up some device links with switches, + * since connectors have their own compatible. Purge these + * to avoid a deadlock in switch probe (the switch mistakenly + * assumes the connector is a supplier). + */ + if (dev_of_node(dev)) + device_for_each_child_node(dev, fwnode) + fw_devlink_purge_absent_suppliers(fwnode); + /* DT uses "reg" to specify port number. */ port_prop = dev->of_node ? "reg" : "port-number"; device_for_each_child_node(dev, fwnode) {