From patchwork Fri Feb 3 13:50:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Morse X-Patchwork-Id: 52491 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp849074wrn; Fri, 3 Feb 2023 05:53:33 -0800 (PST) X-Google-Smtp-Source: AK7set/pr6kmS8ClvtxsH8CX5RiTT9/HqSBy/TaISatfd22Y/g2gaFujdEPSOkXEhc7rXDw1+apV X-Received: by 2002:a17:907:8e93:b0:878:81d7:9f77 with SMTP id tx19-20020a1709078e9300b0087881d79f77mr11756864ejc.34.1675432413175; Fri, 03 Feb 2023 05:53:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675432413; cv=none; d=google.com; s=arc-20160816; b=xaMqhhU0h5+vD9p5IeDTcxR6ahEkDGXnuFpFgdDGQTPIa7l8wbvrEm2cfWxHoh/U53 hiM+Va8BtefCxmeiPsaIvkvYEgHLkJjbfcdkQFfW9fZm67RmuZ2Iu0rnbAyFkaWGkqvY lfgCm9Nvw4C/Y6SZ4f0p8fzhsYZZxAt+xBQj+3lWax//BflvoSR/itP0MHVjWakwV3as E7HSsHJjFAXwYm/WDyDndebN+MZxR8qMt5ZL4BBmrZj2UvRXCqmxj/y9S/yBCRwn3m5U iB6iQuTm5lReDU35v0JISfmbd0VbMjNfDX5V+VBDgNDU7xeGmvemM7McH+Lx2JisSVhi OnPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=fty5qP4Wl827sfKYP+Kuf890uGaX+Ow3oWwZSROjFz0=; b=sdLxmdQsUopb/ViHi80nby/WN/NXvRtVnkfoGVwaYLqj3rJl/+TTuX7Aeu5zzA7xag uo+M4G5MpL0Tat3nP5i49MvEIlC0NkPQIBzqwF6ymEJ/jcIfeDyS+4loLtfZDJpJCR/P fHuKrPx7O2J201o4Dy4jpD7Bb2FAApHIiZcwDSCkEMXwINKjEMJdEgfAI7XR/sniXubo McPqLtsHCb+eh61gkMDduY4UsSVnXUkak/3UDQP/hcvEaVJXFdp3HViZIo9Bj5E4Y2xt Az4Hot1aWiXwVlLyS6sgam+vuKZH9AnglUnJg/xnGeiQYe6lvVqu9RX6M/MGhMEbAGiz cuLw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fi3-20020a1709073ac300b0087da417217dsi2945030ejc.728.2023.02.03.05.53.08; Fri, 03 Feb 2023 05:53:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233067AbjBCNwU (ORCPT + 99 others); Fri, 3 Feb 2023 08:52:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233022AbjBCNwM (ORCPT ); Fri, 3 Feb 2023 08:52:12 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5D69D7CCB0; Fri, 3 Feb 2023 05:51:55 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 521CC1FB; Fri, 3 Feb 2023 05:52:37 -0800 (PST) Received: from eglon.cambridge.arm.com (eglon.cambridge.arm.com [10.1.196.177]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 843D23F71E; Fri, 3 Feb 2023 05:51:51 -0800 (PST) From: James Morse To: linux-pm@vger.kernel.org, loongarch@lists.linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org Cc: Marc Zyngier , Thomas Gleixner , Lorenzo Pieralisi , Mark Rutland , Sudeep Holla , Borislav Petkov , H Peter Anvin , Dave Hansen , Ingo Molnar , Will Deacon , Catalin Marinas , Huacai Chen , James Morse , Suzuki K Poulose , Oliver Upton , Len Brown , Rafael Wysocki , WANG Xuerui , Salil Mehta , Russell King , Jean-Philippe Brucker Subject: [RFC PATCH 01/32] ia64: Fix build error due to switch case label appearing next to declaration Date: Fri, 3 Feb 2023 13:50:12 +0000 Message-Id: <20230203135043.409192-2-james.morse@arm.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230203135043.409192-1-james.morse@arm.com> References: <20230203135043.409192-1-james.morse@arm.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756818217666853225?= X-GMAIL-MSGID: =?utf-8?q?1756818217666853225?= Since commit aa06a9bd8533 ("ia64: fix clock_getres(CLOCK_MONOTONIC) to report ITC frequency"), gcc 10.1.0 fails to build ia64 with the gnomic: | ../arch/ia64/kernel/sys_ia64.c: In function 'ia64_clock_getres': | ../arch/ia64/kernel/sys_ia64.c:189:3: error: a label can only be part of a statement and a declaration is not a statement | 189 | s64 tick_ns = DIV_ROUND_UP(NSEC_PER_SEC, local_cpu_data->itc_freq); This line appears immediately after a case label in a switch. Move the declarations out of the case, to the top of the function. Signed-off-by: James Morse --- This patch was previously posted as a fix here: https://www.spinics.net/lists/linux-ia64/msg21920.html Its included here to keep the kbuild robot quiet. arch/ia64/kernel/sys_ia64.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/ia64/kernel/sys_ia64.c b/arch/ia64/kernel/sys_ia64.c index f6a502e8f02c..6e948d015332 100644 --- a/arch/ia64/kernel/sys_ia64.c +++ b/arch/ia64/kernel/sys_ia64.c @@ -170,6 +170,9 @@ ia64_mremap (unsigned long addr, unsigned long old_len, unsigned long new_len, u asmlinkage long ia64_clock_getres(const clockid_t which_clock, struct __kernel_timespec __user *tp) { + struct timespec64 rtn_tp; + s64 tick_ns; + /* * ia64's clock_gettime() syscall is implemented as a vdso call * fsys_clock_gettime(). Currently it handles only @@ -185,8 +188,8 @@ ia64_clock_getres(const clockid_t which_clock, struct __kernel_timespec __user * switch (which_clock) { case CLOCK_REALTIME: case CLOCK_MONOTONIC: - s64 tick_ns = DIV_ROUND_UP(NSEC_PER_SEC, local_cpu_data->itc_freq); - struct timespec64 rtn_tp = ns_to_timespec64(tick_ns); + tick_ns = DIV_ROUND_UP(NSEC_PER_SEC, local_cpu_data->itc_freq); + rtn_tp = ns_to_timespec64(tick_ns); return put_timespec64(&rtn_tp, tp); }