From patchwork Fri Feb 3 10:18:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anastasia Belova X-Patchwork-Id: 52454 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp757362wrn; Fri, 3 Feb 2023 02:22:37 -0800 (PST) X-Google-Smtp-Source: AK7set8qFx1lQWqX06c3jZKcO7p8d/bBU1JGffO6wmbzApN+yAo/8fmcFzxjlZ9+o0hWvE0e5T7G X-Received: by 2002:a17:906:c5b:b0:883:be32:cd33 with SMTP id t27-20020a1709060c5b00b00883be32cd33mr11483036ejf.35.1675419757697; Fri, 03 Feb 2023 02:22:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675419757; cv=none; d=google.com; s=arc-20160816; b=JP0XE9ZEmDlvLNXmxesQp+KslT/Ude7UwNnydIHl8jnmMrsb7TiXoSD8OYJscW8go4 FmOuLw7lVsMhneu+xeWoXUv9Vuz0lUtzVJk6jDbZ1cFPQSLYtcQ0QW0bA58oUut/PApz 8/eKD2DIUQR3Yok/yBmwbWKw3DoOTBaXTDj14L1kMuDVEq2MZECiiqKuY88tzbp5HbkI 5QSZYLtsAU61zHrWyZZUiWabFD8yj6QJWfTUzZfb9U4Bdzp+WGxdqTwEAsECfg19OouU O/snbDlXoBixkpOFeKhuP9em72NKJs9pNVQCw/KAiotMxYcFOBet/evaW9TCLZ6HIT3B pUkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=FKIacRob1F3AbdTpoSx1WZjLM4bYe5920RcEL6Llr+g=; b=1A2SF31mVkrfdpWs0f1m6QIbUlbtn+AQokaVd5osNzifYFQXCAe9faIJYfAVTiU/6G SB7qAp2XIf9OM3vyzEXmlqb8zIMT9bZ+qy/8DKLl9pJ3OmC9w6tHYIcOV/ncEywr9jg0 lp1Yr3+Qdmwhmlpb/v6kX68LDVz8+Z19kT+u76/+VowD7iZws1l7VVdCBUNs4RNVWj8E IRouozqf14EAKS4hV+Feb/85vwIAgmIQeCf5Ye96LpLNBNWKffn/YhVwIvYalFcrqkgG LHk9tWvq2jLSA8tBdIODyJ6FnKtWE/kP2dh58DK3TLXV7dZaxRhrRtzYKhA+04dE0njD n8IA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k8-20020a1709062a4800b008787afd881asi2709256eje.458.2023.02.03.02.22.13; Fri, 03 Feb 2023 02:22:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231871AbjBCKTy (ORCPT + 99 others); Fri, 3 Feb 2023 05:19:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233342AbjBCKTo (ORCPT ); Fri, 3 Feb 2023 05:19:44 -0500 Received: from mail.astralinux.ru (mail.astralinux.ru [217.74.38.119]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74F4D8B7E6; Fri, 3 Feb 2023 02:19:08 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by mail.astralinux.ru (Postfix) with ESMTP id BFC5F1863E8A; Fri, 3 Feb 2023 13:18:33 +0300 (MSK) Received: from mail.astralinux.ru ([127.0.0.1]) by localhost (rbta-msk-vsrv-mail01.astralinux.ru [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id hEE99ydb8xu4; Fri, 3 Feb 2023 13:18:33 +0300 (MSK) Received: from localhost (localhost [127.0.0.1]) by mail.astralinux.ru (Postfix) with ESMTP id 7014D1863BFD; Fri, 3 Feb 2023 13:18:33 +0300 (MSK) X-Virus-Scanned: amavisd-new at astralinux.ru Received: from mail.astralinux.ru ([127.0.0.1]) by localhost (rbta-msk-vsrv-mail01.astralinux.ru [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id sntV4lUThDfK; Fri, 3 Feb 2023 13:18:33 +0300 (MSK) Received: from rbta-msk-lt-106062.astralinux.ru (unknown [10.177.20.58]) by mail.astralinux.ru (Postfix) with ESMTPSA id 018591862F44; Fri, 3 Feb 2023 13:18:32 +0300 (MSK) From: Anastasia Belova To: Greg Kroah-Hartman Cc: Anastasia Belova , Jakob Koschel , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH] goku_udc: Add check for NULL in goku_irq Date: Fri, 3 Feb 2023 13:18:28 +0300 Message-Id: <20230203101828.14799-1-abelova@astralinux.ru> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756804948213836768?= X-GMAIL-MSGID: =?utf-8?q?1756804948213836768?= Before dereferencing dev->driver check it for NULL. If an interrupt handler is called after assigning NULL to dev->driver, but before resetting dev->int_enable, NULL-pointer will be dereferenced. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Anastasia Belova --- drivers/usb/gadget/udc/goku_udc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/goku_udc.c b/drivers/usb/gadget/udc/goku_udc.c index bdc56b24b5c9..896bba8b47f1 100644 --- a/drivers/usb/gadget/udc/goku_udc.c +++ b/drivers/usb/gadget/udc/goku_udc.c @@ -1616,8 +1616,9 @@ static irqreturn_t goku_irq(int irq, void *_dev) pm_next: if (stat & INT_USBRESET) { /* hub reset done */ ACK(INT_USBRESET); - INFO(dev, "USB reset done, gadget %s\n", - dev->driver->driver.name); + if (dev->driver) + INFO(dev, "USB reset done, gadget %s\n", + dev->driver->driver.name); } // and INT_ERR on some endpoint's crc/bitstuff/... problem }