From patchwork Fri Feb 3 03:35:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neal Liu X-Patchwork-Id: 52281 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp622030wrn; Thu, 2 Feb 2023 19:38:12 -0800 (PST) X-Google-Smtp-Source: AK7set9npwsIl5zJJAHiy2/i4YRKAIFgIUNfWbpAKXN/KIjlVvW+lhfDvd/WYp0Ukd3OQbOqfl0b X-Received: by 2002:a50:ab14:0:b0:47b:16c7:492c with SMTP id s20-20020a50ab14000000b0047b16c7492cmr8895701edc.25.1675395492060; Thu, 02 Feb 2023 19:38:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675395492; cv=none; d=google.com; s=arc-20160816; b=ncovvkWbmfj7gzuSBGJ4Q/8HbezdwYuHQ+1AM/Wu0tSRsGCgPxORiYrLqmd5EEe7Yr 9ad1CUKdlJ/WpvGrbVf4i2PUwXGrZhLW/j5pBxoZTwVEMzxPo1mQuxPtZ/hxzmE1UW79 a1q7wcZyD/fMg5wknRV1RbEC3AeqI+KmdEql7ftT/yTdD9wkNYpUHKf5ob34AXnBUumm uhZBHR6PnkoFOwduT8+XJ7l2lqKxvloVpqh98k7EyPhVB+4lDVmxJoiBZbHkaABDMNUj yT7hj0B7yXezvOP46X34uycJBmvxTr+w6h3BEGei80lR+rMObGi95gmpCpCT1la8ykLM LG6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=xFV6BWdqAMkwsc8WW+V3tGShG5KkUHOCJN2hMxuRE3o=; b=LN47p+U1EQ21iiOkBIa5eLYuR2206WcvdqJElACOOxKr+ga8bdKA3cq/sy4bLBM4Pk UJBrHjpz1ELrYOi8VkWf5tSYcftWVfSFOiTG5z+py5PoHQWSQ/ZJ2IZCIy0Laq46+aUn oTsuij09UfKLAlM1900uR5lWengPjBokkVklbkv7vf9eKeLLy8ZpujNJAv6Us7+g8yse SIUeFzg1nNbPcgryKxl+EuIrhakfCtn1SN+6TkRRR3W2hGVJ5kV0L+yO+ptoTMjBYhww vn7MYXM7ko+gHaWP3rkk2V+yu+q0G+EivVWAadoGCMFH7OisuBkaaJfAwaHLOLRGpmrF Ligw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d2-20020a056402400200b0049d3f37b767si1475850eda.268.2023.02.02.19.37.47; Thu, 02 Feb 2023 19:38:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230003AbjBCDg1 (ORCPT + 99 others); Thu, 2 Feb 2023 22:36:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229575AbjBCDgX (ORCPT ); Thu, 2 Feb 2023 22:36:23 -0500 Received: from twspam01.aspeedtech.com (twspam01.aspeedtech.com [211.20.114.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38DFA1EBD7 for ; Thu, 2 Feb 2023 19:36:16 -0800 (PST) Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 3133NSqX042892; Fri, 3 Feb 2023 11:23:28 +0800 (GMT-8) (envelope-from neal_liu@aspeedtech.com) Received: from localhost.localdomain (192.168.10.10) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 3 Feb 2023 11:35:17 +0800 From: Neal Liu To: Joel Stanley , Andrew Jeffery , Neal Liu , Herbert Xu , "David S . Miller" CC: , , , Subject: [RESENT PATCH v3 -next] crypto: aspeed: fix type warnings Date: Fri, 3 Feb 2023 11:35:12 +0800 Message-ID: <20230203033512.980497-1-neal_liu@aspeedtech.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [192.168.10.10] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 3133NSqX042892 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS, T_SPF_HELO_TEMPERROR autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756686666861152284?= X-GMAIL-MSGID: =?utf-8?q?1756779503321339527?= This patch fixes following warnings: 1. sparse: incorrect type in assignment (different base types) Fix: change to __le32 type. 2. sparse: cast removes address space '__iomem' of expression Fix: use readb to avoid dereferencing the memory. Signed-off-by: Neal Liu --- Change since v2: remove unnecessary cast. Change since v1: keep iomem marker to remain its purpose. drivers/crypto/aspeed/aspeed-acry.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/aspeed/aspeed-acry.c b/drivers/crypto/aspeed/aspeed-acry.c index 164c524015f0..1f77ebd73489 100644 --- a/drivers/crypto/aspeed/aspeed-acry.c +++ b/drivers/crypto/aspeed/aspeed-acry.c @@ -252,7 +252,7 @@ static int aspeed_acry_rsa_ctx_copy(struct aspeed_acry_dev *acry_dev, void *buf, enum aspeed_rsa_key_mode mode) { const u8 *src = xbuf; - u32 *dw_buf = (u32 *)buf; + __le32 *dw_buf = buf; int nbits, ndw; int i, j, idx; u32 data = 0; @@ -302,7 +302,7 @@ static int aspeed_acry_rsa_ctx_copy(struct aspeed_acry_dev *acry_dev, void *buf, static int aspeed_acry_rsa_transfer(struct aspeed_acry_dev *acry_dev) { struct akcipher_request *req = acry_dev->req; - u8 *sram_buffer = (u8 *)acry_dev->acry_sram; + u8 __iomem *sram_buffer = acry_dev->acry_sram; struct scatterlist *out_sg = req->dst; static u8 dram_buffer[ASPEED_ACRY_SRAM_MAX_LEN]; int leading_zero = 1; @@ -321,11 +321,11 @@ static int aspeed_acry_rsa_transfer(struct aspeed_acry_dev *acry_dev) for (j = ASPEED_ACRY_SRAM_MAX_LEN - 1; j >= 0; j--) { data_idx = acry_dev->data_byte_mapping[j]; - if (sram_buffer[data_idx] == 0 && leading_zero) { + if (readb(sram_buffer + data_idx) == 0 && leading_zero) { result_nbytes--; } else { leading_zero = 0; - dram_buffer[i] = sram_buffer[data_idx]; + dram_buffer[i] = readb(sram_buffer + data_idx); i++; } }