Message ID | 20230202153235.2412790-8-gregkh@linuxfoundation.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp314355wrn; Thu, 2 Feb 2023 07:48:51 -0800 (PST) X-Google-Smtp-Source: AK7set9Svo6nuvjnINBjA1Q42eH1k0JekKsZB187xOSpAEhP/XWeJ1nYRY/L9lJ3qOGBfecRQSox X-Received: by 2002:a17:906:12cc:b0:887:66bc:97 with SMTP id l12-20020a17090612cc00b0088766bc0097mr5916785ejb.49.1675352930995; Thu, 02 Feb 2023 07:48:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675352930; cv=none; d=google.com; s=arc-20160816; b=wWncb0DZgYRCfCXWp5dMX8NnVmHorINly72dq8GNgBNHTtYGKORMwR0KKL98ZJnEPe AmOnlkoR9WLrVwhXSJKND06wu8WhOXCxW80u9YDuY4OLwO9/SipHDFDzEIQuna1D9ViP JY5BGGHPtOA98KNJiUkvBPmecQbp0ZcUeGniPeo8uDAgpLM+kGwGGjTr/6pjn64Xs1/9 iUjOhpMIBn3bvp0HbcGsR1Mz+7Hd9t8KjTMORybc732V6udfiaZYuN6osf3G8fJQ8fbl VN6fArZv4qq0G46dYZvdRNtD6aTOAkK6jn2XI+obumsqG1aN+0EkDDq603OE7Egz1wsi 9MmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=XsjxSWJAKT2TY25UM8NNZGPScu6atJg0ykBVd/RSJFo=; b=scyYsVH7JsjPWMhqbRhik7kB9EFqOhkEOEgzkL823BLBFiqtXkGfbZ8oBb3/NRyDII pIlAoL/MgRJtNvcZNq9bkQuEpxa1JeVasloSlNknX18ULgipViKnQmsgToWec+RPNAuN CKdRdczz+VFNYR9j88+K5Q4GumP3GGhW63yWOvM1blh0wMY/sE7do7Fr3fUX0J3O42JM xOTj8M/C0Ga39FnmaxFgBR+Jdzx4STkK6IseF8u3/ULLqGUSEkMj0dY43DzDnAx/p6xR qqkctjdu/acWVVk9AIwwXsaDCfUpP1epYmFsQDperobkDrNb22Vim72WR5XUXw9nUC+T ntJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=KtEH7vhp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 5-20020a170906020500b0088f1ecec549si2775404ejd.995.2023.02.02.07.48.27; Thu, 02 Feb 2023 07:48:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=KtEH7vhp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232270AbjBBPk6 (ORCPT <rfc822;il.mystafa@gmail.com> + 99 others); Thu, 2 Feb 2023 10:40:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232391AbjBBPky (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 2 Feb 2023 10:40:54 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9037EBB9D; Thu, 2 Feb 2023 07:40:30 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 74A2C61B8C; Thu, 2 Feb 2023 15:33:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C54CC433EF; Thu, 2 Feb 2023 15:33:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675351993; bh=OCpQGd9y36W01Js+1AiolPPhc/FDiwwFSG64ouudZug=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KtEH7vhpb2gAmASrAaDeEBopioNdxclZKkTX7mUVj6INLSzh8G5eTL1+IguvHPu02 gfH+ZYc1bWES9rretKPDf19QyNUwUIzRAsyibdHI4jRQe1gYPCGQvzBQhf7e/IFy8W TOGpzuL3ZlWBmB6LHJkjbj5mghGUkzObB+CNXp6c= From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-usb@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jakob Koschel <jakobkoschel@gmail.com>, linux-kernel@vger.kernel.org Subject: [PATCH 08/13] USB: gadget: gr_udc: fix memory leak with using debugfs_lookup() Date: Thu, 2 Feb 2023 16:32:30 +0100 Message-Id: <20230202153235.2412790-8-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230202153235.2412790-1-gregkh@linuxfoundation.org> References: <20230202153235.2412790-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1020; i=gregkh@linuxfoundation.org; h=from:subject; bh=OCpQGd9y36W01Js+1AiolPPhc/FDiwwFSG64ouudZug=; b=owGbwMvMwCRo6H6F97bub03G02pJDMm3r0+6Jjrf0IQv3T1LNdVebeNUmRsbr/fMWSLx8o5sYMfp en7rjlgWBkEmBlkxRZYv23iO7q84pOhlaHsaZg4rE8gQBi5OAZiIxWGG+TFX25p4vs5aIeC55XN9VO 7r+G07ZzPMj/CSbLzMalPfWxzscXd/XH+DtRA7AA== X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756734875234525527?= X-GMAIL-MSGID: =?utf-8?q?1756734875234525527?= |
Series |
[01/13] USB: chipidea: fix memory leak with using debugfs_lookup()
|
|
Commit Message
Greg KH
Feb. 2, 2023, 3:32 p.m. UTC
When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time. To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic
at once.
Cc: Jakob Koschel <jakobkoschel@gmail.com>
Cc: linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/usb/gadget/udc/gr_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/gr_udc.c b/drivers/usb/gadget/udc/gr_udc.c index 22096f8505de..52c12c96c275 100644 --- a/drivers/usb/gadget/udc/gr_udc.c +++ b/drivers/usb/gadget/udc/gr_udc.c @@ -215,7 +215,7 @@ static void gr_dfs_create(struct gr_udc *dev) static void gr_dfs_delete(struct gr_udc *dev) { - debugfs_remove(debugfs_lookup(dev_name(dev->dev), usb_debug_root)); + debugfs_lookup_and_remove(dev_name(dev->dev), usb_debug_root); } #else /* !CONFIG_USB_GADGET_DEBUG_FS */