Message ID | 20230202153235.2412790-7-gregkh@linuxfoundation.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp313585wrn; Thu, 2 Feb 2023 07:47:21 -0800 (PST) X-Google-Smtp-Source: AK7set+O5KDCNZPadjRC3O7gN/nbePcWIOpaxEmQR4iS4/RLl4y2VZ5iI9WCg0NslxEB+iPDMwKm X-Received: by 2002:a05:6402:1643:b0:492:8c77:7dad with SMTP id s3-20020a056402164300b004928c777dadmr6430911edx.8.1675352841291; Thu, 02 Feb 2023 07:47:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675352841; cv=none; d=google.com; s=arc-20160816; b=S5Imm81yN5LMxlw/XN+Tux7v8nEBsS4zNGucspXDo1NzTBoAUokQxmGCj6CNGZQpI9 nJ1GOT2k6d0/4CYmTayXsw6HuKHHjW+sw6W0z7igR6UYK4guNfLjebQkLDFDUMbZOhJS dB9+4YCZeh8iuWJJW4KXQ4TuN8LjJpUg0Ia7GFnuPifL66N+4a0KUggGl+3+g7SX44jU m8IF24hhnZXblRitzhk2eYyW24WtlMOC9Bqud1NspX7Sc/n1gCrxz24TE9EHNiSAWBwY zBaK0jdYt9BSol/dl/EBe7mN/i1Zbbs86PSLPOw9md2oFAm7RSzTDfvl/XnUgxCseYBS tT2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=EC/iqnxF7XmRPZti0Eeda3HRsGm7M6Y6PuU8HBPgu4Y=; b=ybbsCinsQ9hT5BKKXoM/5eaWWxQ2WF2Ds3VltwWZo8D5F87gnLroqAm/W9CPnFDSfF XB7vojSQGCD66NSEkW45dBV0eBxkrjkcn4qqYCJcn3SiVJQHEDjgdAotsV6z4hK14Jew /anqzY6T1pT08wyIuQZkWB16JvjYAS/JxsUDF5dgXBsOb2+SlJuTDaWyOZ6A9qBYu7/q qqssfujRrikFZCIYBB447mH9UNMxr8ymqjib/oY2SViFoYyBRlyXAW5j2mVaU0d4+yMU ioYFbP4uH6klqjrb3wNTq6TuAdlvsEw78anPjcVoePwg3Hi06P5brtrTE0PPiCc90/ZD z9gw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=LplWbCoZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h9-20020a05640250c900b004a7f88d929csi1145418edb.411.2023.02.02.07.46.57; Thu, 02 Feb 2023 07:47:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=LplWbCoZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232782AbjBBPgR (ORCPT <rfc822;il.mystafa@gmail.com> + 99 others); Thu, 2 Feb 2023 10:36:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233326AbjBBPfw (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 2 Feb 2023 10:35:52 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF50B6950F; Thu, 2 Feb 2023 07:35:24 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A48A9B82688; Thu, 2 Feb 2023 15:33:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7BA6C433D2; Thu, 2 Feb 2023 15:33:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675351991; bh=Qxq2Azs1q6cerOsyDuVhXTx/eaL+5JdsQi0iF0CnjCM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LplWbCoZniMJ+QI5Yk9OwYw25kggfG4Kskew/LZOkVpBv2XqHiLaXUiJt8EHrhDJQ Jd1KAvKSR20MSpB5JVzUqudftE2JVSduqaZWvp2guQE/ZW28/r+hWSSW5X1prbK39f BR1jx7GfUykBM6hurXFacQ3amAv0Y9juiql8p6Io= From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-usb@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Vincent Mailhol <mailhol.vincent@wanadoo.fr>, linux-kernel@vger.kernel.org Subject: [PATCH 07/13] USB: isp1362: fix memory leak with using debugfs_lookup() Date: Thu, 2 Feb 2023 16:32:29 +0100 Message-Id: <20230202153235.2412790-7-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230202153235.2412790-1-gregkh@linuxfoundation.org> References: <20230202153235.2412790-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1077; i=gregkh@linuxfoundation.org; h=from:subject; bh=Qxq2Azs1q6cerOsyDuVhXTx/eaL+5JdsQi0iF0CnjCM=; b=owGbwMvMwCRo6H6F97bub03G02pJDMm3r08KE39+eWe0WSJPkEaPwhUJz3v3i54F3NsX0a7PuqWx VretI5aFQZCJQVZMkeXLNp6j+ysOKXoZ2p6GmcPKBDKEgYtTACZy5wzDgqYZc2tYd+bFZRWc5+TlaV jDYq8wkWFB84XEhLdilWmdtyWCv0Xu3+RRsWwDAA== X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756734781360557194?= X-GMAIL-MSGID: =?utf-8?q?1756734781360557194?= |
Series |
[01/13] USB: chipidea: fix memory leak with using debugfs_lookup()
|
|
Commit Message
Greg KH
Feb. 2, 2023, 3:32 p.m. UTC
When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time. To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic
at once.
Cc: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Cc: linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/usb/host/isp1362-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/isp1362-hcd.c b/drivers/usb/host/isp1362-hcd.c index 0e14d1d07709..b0da143ef4be 100644 --- a/drivers/usb/host/isp1362-hcd.c +++ b/drivers/usb/host/isp1362-hcd.c @@ -2170,7 +2170,7 @@ static void create_debug_file(struct isp1362_hcd *isp1362_hcd) static void remove_debug_file(struct isp1362_hcd *isp1362_hcd) { - debugfs_remove(debugfs_lookup("isp1362", usb_debug_root)); + debugfs_lookup_and_remove("isp1362", usb_debug_root); } /*-------------------------------------------------------------------------*/