From patchwork Thu Feb 2 15:32:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 52028 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp312745wrn; Thu, 2 Feb 2023 07:45:45 -0800 (PST) X-Google-Smtp-Source: AK7set8GacJZUsq36zGbXuONesgtWM9lqp5WE1EOGeJyatusMhjZERqS09pQ63fbU+231nUmLu1a X-Received: by 2002:a17:907:3f21:b0:878:702c:bd86 with SMTP id hq33-20020a1709073f2100b00878702cbd86mr2706909ejc.74.1675352745348; Thu, 02 Feb 2023 07:45:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675352745; cv=none; d=google.com; s=arc-20160816; b=Bg/ugOw7xL4uDHXaNLjuxfulD4NQQAXoVQJCcq1PWX/QccIzfQ00kkXbByfrgN0MDv FortQgxTfmypUqaOzo1nk4XZKXOPs5ZhWN/HYJOzqpduaTsN6qiY5zuWUCyXzLiMb/Ss ER8M94zqGUkzG7ZpIFoMYGk/aj2+3cSFK8aqKzUkpt/RhIo+nDbbWFprlK1zewL5u6Ty 40fV+LAs62H1cmrhIg8gi0bjfzoqz9OWoe5f9zilXHMfO2iVx+GVLXbfYfzdhQvbGSIW Qqr04AoqN45seBBSkvpLNsCPbeO8jnV2l26lHfHXK/1oZ15yoCtJn5xXwf6oFJkB06Eq B5dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=XhmZviZ1sloav7ZxAWDSUZsisQ3egSlkZdWhNDvmosE=; b=d/yHDzjjXHXDAfmqZ5Qw+ezA3UCaY7Xvj8U8NV+KR35WlBRDasW+J4PyRaoDVA9lfv lYoWGnrWQkK8OWt2OVbuwB4sqZfJ5QqEodfBtGPLMnmE0GIEnqUQiShKFUjzyzPD+a4G aImv9hIVHqALuQL/WuHbj0sfu3d2GywoQsTD5s+1zMMseyKQHxncKflth8nTBtHrx2k/ YhIRBcW/m6hAPVKEHddkXYxtjkfhyNPFzsgwKVVb/+7sbTDABdGYPmId0XNWG4LHU8uH Ey5gJbMFn3VR1rXxWc44jyTREDN3SEad9AF1NkOzCOArJvVmsHSy8mnijP29xLzwPMCl BZgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Ew6EyN55; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l20-20020aa7c3d4000000b004a22cb2b970si17284446edr.535.2023.02.02.07.45.21; Thu, 02 Feb 2023 07:45:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Ew6EyN55; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233294AbjBBPfv (ORCPT + 99 others); Thu, 2 Feb 2023 10:35:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231359AbjBBPfX (ORCPT ); Thu, 2 Feb 2023 10:35:23 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58FE9279A4; Thu, 2 Feb 2023 07:34:52 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3E09B61BDF; Thu, 2 Feb 2023 15:33:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3AF08C4339B; Thu, 2 Feb 2023 15:33:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675351988; bh=gODC2aLPKGO7RjywvEnuzK1998oMNqPjX9wx4dajC7Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ew6EyN5506MnHVqYz2CemnwHj5fWpBLRetRyY74DQ4nkuQZmwxyn6lecT32koQS8I 5rlX5tVWYRtnipOi2fVegH2Eme8Xixin23vU6XHIBCzC4cr6xNDkmZOqGTwHxOkAB2 Eo38+NwUCPPoy4pjrqZnyEg93mfC3cdfyxeJtpKQ= From: Greg Kroah-Hartman To: linux-usb@vger.kernel.org Cc: Greg Kroah-Hartman , Olav Kongas , linux-kernel@vger.kernel.org Subject: [PATCH 06/13] USB: isp116x: fix memory leak with using debugfs_lookup() Date: Thu, 2 Feb 2023 16:32:28 +0100 Message-Id: <20230202153235.2412790-6-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230202153235.2412790-1-gregkh@linuxfoundation.org> References: <20230202153235.2412790-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=974; i=gregkh@linuxfoundation.org; h=from:subject; bh=gODC2aLPKGO7RjywvEnuzK1998oMNqPjX9wx4dajC7Y=; b=owGbwMvMwCRo6H6F97bub03G02pJDMm3r08Uiec9yDfJUnr675JHvMU8Py89qJv6zMFpSYNett2t /XZiHbEsDIJMDLJiiixftvEc3V9xSNHL0PY0zBxWJpAhDFycAjARu1sM8/Q/aIbJnl49Qyp0B79HwO obvrMWRDLML99U+Wt1+fXQFWGxByQkH2x9L+6iBAA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756734680341594042?= X-GMAIL-MSGID: =?utf-8?q?1756734680341594042?= When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. To make things simpler, just call debugfs_lookup_and_remove() instead which handles all of the logic at once. Cc: Olav Kongas Cc: linux-usb@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/host/isp116x-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c index 4f564d71bb0b..49ae01487af4 100644 --- a/drivers/usb/host/isp116x-hcd.c +++ b/drivers/usb/host/isp116x-hcd.c @@ -1205,7 +1205,7 @@ static void create_debug_file(struct isp116x *isp116x) static void remove_debug_file(struct isp116x *isp116x) { - debugfs_remove(debugfs_lookup(hcd_name, usb_debug_root)); + debugfs_lookup_and_remove(hcd_name, usb_debug_root); } #else