From patchwork Thu Feb 2 15:32:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 52043 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp314794wrn; Thu, 2 Feb 2023 07:49:46 -0800 (PST) X-Google-Smtp-Source: AK7set+f+pn/cJsMIVKS96r/rqAMIj4DrRtcI7Wx/6DnAt992nhA7He17Kb2iNMJPAVu7Vsoy5ez X-Received: by 2002:a17:906:5450:b0:87b:daca:aa1a with SMTP id d16-20020a170906545000b0087bdacaaa1amr6153408ejp.45.1675352986729; Thu, 02 Feb 2023 07:49:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675352986; cv=none; d=google.com; s=arc-20160816; b=xxiq/adUWwoV80PLN1frs/TFidcZjqBhyPAaeY17jTt6ylookl3qddu0S/Gzxty9PM 4566i4oeB0UipDEsdBlt4z+Ry0JEbxi7gdu1H30Z6I7XciWhluDpnZqfzLhrw3ppJ8x3 z+CPJtY0hkNbM4SdzXL1DdG1z9yEAA5U9/VwAY4koSi+/GgFvwTunxoUXg66PdVpNL/6 1gOcMIee50SyokD7QZ9sUwsDqEK6tpjvYTDYINlHG1wjnq/eMFXWQglT2WSTAKEAzF9q xlxr0sU7sd5oAAPsk4nNPjS1uaOWWqPuxCRnjkBJzoMa4YOqcIGCM1CRCPR3bV/AQVFs X/1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6KLHRsG/qAC0VkkcAngnwzLXW8g7OtWMWDiIOLkXEfo=; b=wQGJAUW0pTucUoHfYClKVRpqkuVJnb7lsg0zY4Y0y9oqhCLco5+nnRbpPOXwGcAp2C wjvRIytwsFWb9juGv8wuJxGnirFDugdOoUSiwZmq/GW+w4HRYdVUhNYAGiYe0CKn+nA6 jZT/sXG01thYOQJeexNkK/+hDeuC9+CI6CtNGlkeJE/yxtExzsPWIlmMAKzUvZ7Nt8lI sw3jgLIIs5MuQ85dn6ae3CJKUuG6m1Fi3/9tddUacOYQWEOFeFP4rt+0TEq4DDBfIuum VC0cEsR9P6tHYW9niYsKO0U6EdjXq69MqRVtN1IlCPAoQAspnVqUfTYP95A/hOFzXKm+ esuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="L/d22WHa"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fp29-20020a1709069e1d00b00886a0d683acsi14974521ejc.33.2023.02.02.07.49.23; Thu, 02 Feb 2023 07:49:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="L/d22WHa"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231897AbjBBPnV (ORCPT + 99 others); Thu, 2 Feb 2023 10:43:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231482AbjBBPnS (ORCPT ); Thu, 2 Feb 2023 10:43:18 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85CCA27D46; Thu, 2 Feb 2023 07:42:55 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B829461BE2; Thu, 2 Feb 2023 15:32:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA6DFC4339B; Thu, 2 Feb 2023 15:32:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675351976; bh=9jlFcZReaRqGG5HOvntUdmyxy0CRaO52IN9kpSRb2vs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L/d22WHalF5IHieEA4ZC3AdeKcY3j4jnBr2gh1Zj2mWqDDsuQpS0haOplVBNpPmLH OjrXrrg3HRti65BZYpgzkNgZE3SWX0VYdxW2gnkLUGX4SBq1QQxt5aMMUfia4foUeg X62puFv1JX/3I+0OBWuz5wnVwwHj9ze7NTHweqtw= From: Greg Kroah-Hartman To: linux-usb@vger.kernel.org Cc: Greg Kroah-Hartman , Krzysztof Kozlowski , Alim Akhtar , Linus Walleij , Jakob Koschel , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 13/13] USB: gadget: s3c2410_udc: fix memory leak with using debugfs_lookup() Date: Thu, 2 Feb 2023 16:32:35 +0100 Message-Id: <20230202153235.2412790-13-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230202153235.2412790-1-gregkh@linuxfoundation.org> References: <20230202153235.2412790-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1327; i=gregkh@linuxfoundation.org; h=from:subject; bh=9jlFcZReaRqGG5HOvntUdmyxy0CRaO52IN9kpSRb2vs=; b=owGbwMvMwCRo6H6F97bub03G02pJDMm3r09eL5hl8nPLpjW9Ex/53eWat+utokDKkYcxQV9a05Yt YKnX7YhlYRBkYpAVU2T5so3n6P6KQ4pehranYeawMoEMYeDiFICJPLZmmF+7cu2Ca7vnFfyz2Hta8r FI2dHca7MY5nAaKEa/PxRfsrPmDYv45xgu2w7R9QA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756734933308267325?= X-GMAIL-MSGID: =?utf-8?q?1756734933308267325?= When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. To make things simpler, just call debugfs_lookup_and_remove() instead which handles all of the logic at once. Cc: Krzysztof Kozlowski Cc: Alim Akhtar Cc: Linus Walleij Cc: Jakob Koschel Cc: linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/udc/s3c2410_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/s3c2410_udc.c b/drivers/usb/gadget/udc/s3c2410_udc.c index 8c57b191e52b..3525a3c260a7 100644 --- a/drivers/usb/gadget/udc/s3c2410_udc.c +++ b/drivers/usb/gadget/udc/s3c2410_udc.c @@ -1881,7 +1881,7 @@ static int s3c2410_udc_remove(struct platform_device *pdev) return -EBUSY; usb_del_gadget_udc(&udc->gadget); - debugfs_remove(debugfs_lookup("registers", s3c2410_udc_debugfs_root)); + debugfs_lookup_and_remove("registers", s3c2410_udc_debugfs_root); if (udc->vbus_gpiod) free_irq(gpiod_to_irq(udc->vbus_gpiod), udc);