Message ID | 20230202141520.40003-1-avromanov@sberdevices.ru |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp263675wrn; Thu, 2 Feb 2023 06:17:05 -0800 (PST) X-Google-Smtp-Source: AK7set+s6D7qayYWECU6xtRSxmC2F4s5OPY6jTiy0Ew74Xj/ZZNNCkvtPdkETowRnRu1cpTXE3eP X-Received: by 2002:a17:906:b812:b0:88c:7a36:d11e with SMTP id dv18-20020a170906b81200b0088c7a36d11emr5886666ejb.25.1675347425354; Thu, 02 Feb 2023 06:17:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675347425; cv=none; d=google.com; s=arc-20160816; b=lf/ZM+z49ouGL87u3kMS718oc2NN1BPGG6wQxhqgZekMogWr5fkkgRqV2DYujuW7Sp 2zCQ9HDjycL6XvyoGDlQ9/G6Sbb9XW4Psc+2C0inhFn4gFgNpnJS/zPieOPqhLkIe1No 80m8ebgyfhYZbAgUjvrc0LWVBQquLx8a3yaCppnTYQeQ2dQo3jFnMIkGlZqVCZCw0VAp iu7ZiysFVyKt5MCceo7IK+FaB1+B8iDscW5dZXmwoLxah8naiFv3vu7kZKGQGhUNHg5c dS4ql9hNzHeSZZZLd+XIcsaNAnfunghGYmkSZ3RTe6XjBgkd+RvjavpvoiRhJKzJLne7 xuaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=x+mS3XduZ3+b7heAKDTw6F4UI2ioHdw4aSRUeHVmiWA=; b=kmM+EOg7DMtndsLj4VIh0wz2S3QKJfW/5kHKSA+zbY9yoEEkN5/pU088z5G/Y+tY9q 6d0R/i+Jn/sAm4EurIkVC23frTqFz/4b7RnJ99W0IZGcIrpFZ1kBW15l+OsdTFh2Xc+M fN6qi0YHF0SYG5Kv5Od3HDM/KLpbIgjhWtVAYY5ktXuFeAkKPJwfgGngaHcjEZK2vjGp WNgUkYe51itVjdhOH6aMXWI6XGxKPspEMWjWK1Vk4RDtSk+YxjQ7qftU0zhje1e08Wa4 /v7Jk3WLeMyJPx9eInlM16DFFBeuMCZLL7e9mxpFSgIPSmKFcaaKhSR2dho3j9XaELLo SbCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b="bEwIf/ur"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id um7-20020a170907cb0700b0087760357eacsi24841851ejc.949.2023.02.02.06.16.38; Thu, 02 Feb 2023 06:17:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b="bEwIf/ur"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232124AbjBBOPi (ORCPT <rfc822;il.mystafa@gmail.com> + 99 others); Thu, 2 Feb 2023 09:15:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230230AbjBBOPg (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 2 Feb 2023 09:15:36 -0500 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACB46E3A7; Thu, 2 Feb 2023 06:15:32 -0800 (PST) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id 3A07D5FD02; Thu, 2 Feb 2023 17:15:29 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1675347329; bh=x+mS3XduZ3+b7heAKDTw6F4UI2ioHdw4aSRUeHVmiWA=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=bEwIf/urHTx8gra33bGPcLFTDkqa2q49MKxqfvDDN7+xRuSYh8mH2xq57OlWffiv3 qr6+wfGcLWULLuhbAHfW7G5/A3KbgZ3nfz2iEkn1AseOStKl9DrYtIyyKGYqoVHLE7 EF7did1CWKLCvsVvbzsZkuZLZ56ciKlq0fQfTriFVVQLaohxBZ8adV75IIOOIR6ycr QGm1SKanRrirlH31vQWmC3yyr7FVHzF93g0CmXwsAY4hBj1oaCNjjDJWNS87rItvW0 iRzWTqEKfZXeKhB43BAgjlOn/+oK2hNaXJ13qeh90C1PbAzYMKmu1fjw7ML0d3/CO9 MOtgsOHO+Y6xQ== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Thu, 2 Feb 2023 17:15:28 +0300 (MSK) From: Alexey Romanov <avromanov@sberdevices.ru> To: <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <neil.armstrong@linaro.org>, <khilman@baylibre.com>, <jbrunet@baylibre.com>, <martin.blumenstingl@googlemail.com> CC: <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-amlogic@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <kernel@sberdevices.ru>, Alexey Romanov <avromanov@sberdevices.ru> Subject: [PATCH v1 1/2] arm64: dts: meson-a1: add gpio_intc node Date: Thu, 2 Feb 2023 17:15:20 +0300 Message-ID: <20230202141520.40003-1-avromanov@sberdevices.ru> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.16.1.6] X-ClientProxiedBy: S-MS-EXCH02.sberdevices.ru (172.16.1.5) To S-MS-EXCH01.sberdevices.ru (172.16.1.4) X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2023/02/02 10:55:00 #20831577 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756729102026423387?= X-GMAIL-MSGID: =?utf-8?q?1756729102026423387?= |
Series |
[v1,1/2] arm64: dts: meson-a1: add gpio_intc node
|
|
Commit Message
Alexey Romanov
Feb. 2, 2023, 2:15 p.m. UTC
Add gpio interrupt controller node.
Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>
---
arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
Comments
Sorry, this patch has the wrong subject (I am tolking about1/2), there is no second patch. On Thu, Feb 02, 2023 at 05:15:20PM +0300, Alexey Romanov wrote: > Add gpio interrupt controller node. > > Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru> > --- > arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > index 6268c323a810..a04ddf0f4cd3 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > @@ -158,6 +158,16 @@ clkc_pll: pll-clock-controller@7c80 { > <&clkc_periphs CLKID_XTAL_HIFIPLL>; > clock-names = "xtal_fixpll", "xtal_hifipll"; > }; > + > + gpio_intc: interrupt-controller@0440 { > + compatible = "amlogic,meson-a1-gpio-intc", > + "amlogic,meson-gpio-intc"; > + reg = <0x0 0x0440 0x0 0x14>; > + interrupt-controller; > + #interrupt-cells = <2>; > + amlogic,channel-interrupts = > + <49 50 51 52 53 54 55 56>; > + }; > }; > > gic: interrupt-controller@ff901000 { > -- > 2.38.1 >
Hi Alexey, On Thu, Feb 2, 2023 at 3:15 PM Alexey Romanov <avromanov@sberdevices.ru> wrote: > > Add gpio interrupt controller node. > > Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru> I have no way to verify the register offset or interrupt numbers. Overall it looks good though, so: Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Best regards, Martin
Hello Martin, On Sun, Feb 05, 2023 at 12:05:46AM +0100, Martin Blumenstingl wrote: > Hi Alexey, > > On Thu, Feb 2, 2023 at 3:15 PM Alexey Romanov <avromanov@sberdevices.ru> wrote: > > > > Add gpio interrupt controller node. > > > > Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru> > I have no way to verify the register offset or interrupt numbers. > Overall it looks good though, so: > Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> We've verified interrupt numbers and register offsets on the our device board based on A1 (A113L) + A113L datasheet.
Le 02/02/2023 à 15:15, Alexey Romanov a écrit : > Add gpio interrupt controller node. > > Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru> > --- > arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > index 6268c323a810..a04ddf0f4cd3 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > @@ -158,6 +158,16 @@ clkc_pll: pll-clock-controller@7c80 { > <&clkc_periphs CLKID_XTAL_HIFIPLL>; > clock-names = "xtal_fixpll", "xtal_hifipll"; > }; > + > + gpio_intc: interrupt-controller@0440 { > + compatible = "amlogic,meson-a1-gpio-intc", > + "amlogic,meson-gpio-intc"; > + reg = <0x0 0x0440 0x0 0x14>; > + interrupt-controller; > + #interrupt-cells = <2>; > + amlogic,channel-interrupts = > + <49 50 51 52 53 54 55 56>; > + }; > }; > > gic: interrupt-controller@ff901000 { Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> I'll take it once v6.3-rc1 is tagged. Thanks, Neil
Hello, Neil! On Wed, Feb 08, 2023 at 01:34:04PM +0100, Neil Armstrong wrote: > Le 02/02/2023 à 15:15, Alexey Romanov a écrit : > > Add gpio interrupt controller node. > > > > Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru> > > --- > > arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > > index 6268c323a810..a04ddf0f4cd3 100644 > > --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > > +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > > @@ -158,6 +158,16 @@ clkc_pll: pll-clock-controller@7c80 { > > <&clkc_periphs CLKID_XTAL_HIFIPLL>; > > clock-names = "xtal_fixpll", "xtal_hifipll"; > > }; > > + > > + gpio_intc: interrupt-controller@0440 { > > + compatible = "amlogic,meson-a1-gpio-intc", > > + "amlogic,meson-gpio-intc"; > > + reg = <0x0 0x0440 0x0 0x14>; > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + amlogic,channel-interrupts = > > + <49 50 51 52 53 54 55 56>; > > + }; > > }; > > gic: interrupt-controller@ff901000 { > > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> > > > I'll take it once v6.3-rc1 is tagged. > > > Thanks, > > Neil v6.3 is tagged, but we didn't find my patch in Amlogic branch. Did you happen to forget about him? -- Thank you, Alexey
On 02/02/2023 15:15, Alexey Romanov wrote: > Add gpio interrupt controller node. > > Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru> > --- > arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > index 6268c323a810..a04ddf0f4cd3 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > @@ -158,6 +158,16 @@ clkc_pll: pll-clock-controller@7c80 { > <&clkc_periphs CLKID_XTAL_HIFIPLL>; > clock-names = "xtal_fixpll", "xtal_hifipll"; > }; > + > + gpio_intc: interrupt-controller@0440 { > + compatible = "amlogic,meson-a1-gpio-intc", > + "amlogic,meson-gpio-intc"; > + reg = <0x0 0x0440 0x0 0x14>; > + interrupt-controller; > + #interrupt-cells = <2>; > + amlogic,channel-interrupts = > + <49 50 51 52 53 54 55 56>; > + }; > }; > > gic: interrupt-controller@ff901000 { The [PATCH 1/2] highly confused b4, anyway it's applied on v6.4/arm64-dt. Thanks, Neil
> The [PATCH 1/2] highly confused b4, anyway it's applied on v6.4/arm64-dt. > > Thanks, > Neil Oh, sorry for the noise. Thank you, Neil!
diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi index 6268c323a810..a04ddf0f4cd3 100644 --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi @@ -158,6 +158,16 @@ clkc_pll: pll-clock-controller@7c80 { <&clkc_periphs CLKID_XTAL_HIFIPLL>; clock-names = "xtal_fixpll", "xtal_hifipll"; }; + + gpio_intc: interrupt-controller@0440 { + compatible = "amlogic,meson-a1-gpio-intc", + "amlogic,meson-gpio-intc"; + reg = <0x0 0x0440 0x0 0x14>; + interrupt-controller; + #interrupt-cells = <2>; + amlogic,channel-interrupts = + <49 50 51 52 53 54 55 56>; + }; }; gic: interrupt-controller@ff901000 {