Message ID | 20230202141221.2293012-1-gregkh@linuxfoundation.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp263029wrn; Thu, 2 Feb 2023 06:16:03 -0800 (PST) X-Google-Smtp-Source: AK7set89Nu8rdiFxgSiO9s/Ma3y2DU//Rz9VryKAd2w5zNO+T/dpVsbe3AxLyYncBYbepXsXav/t X-Received: by 2002:aa7:d402:0:b0:4a1:7a78:13f with SMTP id z2-20020aa7d402000000b004a17a78013fmr6312105edq.27.1675347363287; Thu, 02 Feb 2023 06:16:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675347363; cv=none; d=google.com; s=arc-20160816; b=XnoooEtqn8SZOV4Lss5cZffFdM4BJARf7+bYTMunz3XaS0Fz0LRat5/5sAjwI5D+cO 3UY2mqhGGdIY5YPiqelKBu52YRbwssF6I68whYpWJzER840QnowyvqtwsCp/7yFSs05H HXfepphylgKHyZh2KaHwwlsUc32BdKnPpk8pFhPapvpjoFN3HItllU9dXeN+tflyQNhb qppTISkcQrIh6jK470RQTUG3KIb85tBPj9D9goodnIlzPwnxxKFcAhi57BNl/mp+/pI7 xMmAuuHD3hffprpkIQcIpOmE5nlh/JphaJfpNwOmRYGSYL24pYMam21jN6gnHX4oCEHW dqiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=g9N+Dx5puhXB0DXOIG7kAKGi2lSHkqXHZ8zB9DrzwtA=; b=r8yd5JTfT96DK7Oil3jPTN+um3vJ+ceTHLnsMbCeWplVfUnvWHszxD26YHUeRb9aTh a3Q6W2CQQoGjsCSnIhtwqTy6gqKq4jJLo/NtoXmK9H1ezKS7tdkyuVygDORuReiomtQ4 3/JSz6/0geOYgmSoXszZ/Sk4hgiZ4VwWUTf3Vs3/NlG6tztYafLMoCNktdrk2TwKYEOx pkDi31Ax7jgKxMwuAaSFqQTeJAkvWHGorBz6M9YzFusqPFr9EULNhNV2TWNdLpwubK85 GEgzWd4ed9pDr4BVGl+pcz7v2RGVTgRR+egIB9Rml1V/WDhRJ6KywjYQoM0kxaMirFTy NItA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="nrkehhi/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e13-20020a056402190d00b004a24475fdd4si19776644edz.376.2023.02.02.06.15.39; Thu, 02 Feb 2023 06:16:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="nrkehhi/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232145AbjBBOMu (ORCPT <rfc822;il.mystafa@gmail.com> + 99 others); Thu, 2 Feb 2023 09:12:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232124AbjBBOMq (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 2 Feb 2023 09:12:46 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDC5C8F25B; Thu, 2 Feb 2023 06:12:29 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 78A7A61B6F; Thu, 2 Feb 2023 14:12:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B8A0C433EF; Thu, 2 Feb 2023 14:12:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675347148; bh=CKWzMGXU0WqJTApZJUD8QlCgcpBKwEoffsnd8sluork=; h=From:To:Cc:Subject:Date:From; b=nrkehhi/oELFgt26QD6zVBIoMjtIVlbv6FpkZaMLEiWYLbkmR5ft1RFPhTwXr2c6t PVvsBptp8Qaw3KbC7EhdhZ19uSPLr2P/w8XhHlBc1fywrkha8gjR0g8ywcZIVX1U2T vf7S4ubu6zFHqwBR7ERhEchVnKlZ4JR1QvSiZ4A0= From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-serial@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jirislaby@kernel.org>, linux-kernel@vger.kernel.org Subject: [PATCH] tty: pcn_uart: fix memory leak with using debugfs_lookup() Date: Thu, 2 Feb 2023 15:12:21 +0100 Message-Id: <20230202141221.2293012-1-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1060; i=gregkh@linuxfoundation.org; h=from:subject; bh=CKWzMGXU0WqJTApZJUD8QlCgcpBKwEoffsnd8sluork=; b=owGbwMvMwCRo6H6F97bub03G02pJDMm3jxydnnBQ4N4Cdb2ui869guouaaZhfzS3Xq7xuPZR9PQ6 gxfsHbEsDIJMDLJiiixftvEc3V9xSNHL0PY0zBxWJpAhDFycAjARuWsMC6ZyFT70nLuvod+Sq7ZEdS tj7MvQUoZ51ucKz155Gn8lrf/0m071OxmnpnVvAwA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756729036729680326?= X-GMAIL-MSGID: =?utf-8?q?1756729036729680326?= |
Series |
tty: pcn_uart: fix memory leak with using debugfs_lookup()
|
|
Commit Message
Greg KH
Feb. 2, 2023, 2:12 p.m. UTC
When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time. To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic
at once.
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: linux-serial@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/tty/serial/pch_uart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c index 9576ba8bbc40..cc83b772b7ca 100644 --- a/drivers/tty/serial/pch_uart.c +++ b/drivers/tty/serial/pch_uart.c @@ -1775,7 +1775,7 @@ static void pch_uart_exit_port(struct eg20t_port *priv) char name[32]; snprintf(name, sizeof(name), "uart%d_regs", priv->port.line); - debugfs_remove(debugfs_lookup(name, NULL)); + debugfs_lookup_and_remove(name, NULL); uart_remove_one_port(&pch_uart_driver, &priv->port); free_page((unsigned long)priv->rxbuf.buf); }