Message ID | 20230202141100.2291188-1-gregkh@linuxfoundation.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp263064wrn; Thu, 2 Feb 2023 06:16:06 -0800 (PST) X-Google-Smtp-Source: AK7set87bZKueEczJp3IxrE6ogENGFjXcSTCA39i7oyFZBKvgQ9GAeWZ54GLZFRAnGD3nXxbs2tE X-Received: by 2002:a17:906:4993:b0:88a:b6ca:7d3d with SMTP id p19-20020a170906499300b0088ab6ca7d3dmr6462971eju.8.1675347366595; Thu, 02 Feb 2023 06:16:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675347366; cv=none; d=google.com; s=arc-20160816; b=FjrqflPM07dZa52NpU/HYcbR+HI3NM3Ki3snqXPApRtJaCB1SaVKJXqd6blViMIBKx T4WRIjNNwc7OVqbU/kBTPi92H3wxU6f6rRsPkIZG+RQ6tX6TGcHlchcKTcce5KLtKECv KGXo/AVlqKSQVkBweZWjX49pVAGRhCQsDON0gaUdp15W6Sg60M/IWi9c/L5ZF4L46BaC pDG6d9vMg6GVZOr5XAv3r4i8VdaAUStmEVcTjL1Rsquy029ItoWBVz3b93Ru+AZDbDfX VBQYsLcmv7wh8I0KyUA8z+xQ+sY+oOHyuRS5XpLmSLnjm1CRbepuwBcDqoJ6P2RLL/Jy 9LbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=nK/dK31Yh5fSmLHoIG/nGPWM2IAafMXhJQtdox9YaY8=; b=BY4iQbp8nkyzXTynpTXaKjUDX7JVRmawMdVPL0mnFzQB+HBgID/GH2/zdgaqfuXN1Y RSe+HZR+eARRW6D+2EueGTJXd8BLJK7o248YyD/JZS6IG2jcpvYPsnyzU5+RlfllYzbM RencsJP4xJCm+vw5ODhxvk90aD9li9X5+jEFGIqcfDNU6Q2Y1D2EiXDWldUD/3BoRA6W wEzOTweLuCuk/TilSLJbaJf0R/OdC+4h4M1ubtGS5LItlm85DCM+TAYhZ9XkzOc2+Tel /ZQKHuWOgXhLju1Yg9Jk2mRilVSHB2zthdlFDo+v6bvNt4Ray75p1h0Ez0O1v9i6yG6y zeBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=lAnVZyNH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n14-20020a17090673ce00b00885a48cffe9si19362021ejl.617.2023.02.02.06.15.42; Thu, 02 Feb 2023 06:16:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=lAnVZyNH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231660AbjBBOLP (ORCPT <rfc822;il.mystafa@gmail.com> + 99 others); Thu, 2 Feb 2023 09:11:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbjBBOLM (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 2 Feb 2023 09:11:12 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B62DE88F13 for <linux-kernel@vger.kernel.org>; Thu, 2 Feb 2023 06:11:11 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 74458B8266A for <linux-kernel@vger.kernel.org>; Thu, 2 Feb 2023 14:11:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BEB0BC4339B; Thu, 2 Feb 2023 14:11:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675347069; bh=gBdaWyT3fPaApgmaz3AU3hrMLEA89JaIs6+g1TDSppM=; h=From:To:Cc:Subject:Date:From; b=lAnVZyNHprfWqUF/wAqyHEyrJuuxchV5O5U28OSvwGQlf2CaqDMHZCzNczPMXBDWw ajW0AHu9KpeHrFCC3s1GxpgkCrzxmfA/pqdm03PPrsVuhEmBMgsWJggY8oP/qi5u1a KDtKm/huij4AqTnAuz7ijqO9qPuuW0bp9AOfoiC4= From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Nadav Amit <namit@vmware.com>, VMware PV-Drivers Reviewers <pv-drivers@vmware.com>, Arnd Bergmann <arnd@arndb.de> Subject: [PATCH] misc: vmw_balloon: fix memory leak with using debugfs_lookup() Date: Thu, 2 Feb 2023 15:11:00 +0100 Message-Id: <20230202141100.2291188-1-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1089; i=gregkh@linuxfoundation.org; h=from:subject; bh=gBdaWyT3fPaApgmaz3AU3hrMLEA89JaIs6+g1TDSppM=; b=owGbwMvMwCRo6H6F97bub03G02pJDMm3j5ScCXXcbd9hLvzNuSpMKnGtT0GjQ//lP4JuC3dN817K rb2zI5aFQZCJQVZMkeXLNp6j+ysOKXoZ2p6GmcPKBDKEgYtTACbyRoVhQYtV4NdfeQIruB+c+HWlUy 5wWum8SQwLlhUyN316M8Or+MSmy6uqpKe8eVITAQA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756729040595092090?= X-GMAIL-MSGID: =?utf-8?q?1756729040595092090?= |
Series |
misc: vmw_balloon: fix memory leak with using debugfs_lookup()
|
|
Commit Message
Greg KH
Feb. 2, 2023, 2:11 p.m. UTC
When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time. To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic at
once.
Cc: Nadav Amit <namit@vmware.com>
Cc: VMware PV-Drivers Reviewers <pv-drivers@vmware.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/misc/vmw_balloon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c index 61a2be712bf7..9ce9b9e0e9b6 100644 --- a/drivers/misc/vmw_balloon.c +++ b/drivers/misc/vmw_balloon.c @@ -1709,7 +1709,7 @@ static void __init vmballoon_debugfs_init(struct vmballoon *b) static void __exit vmballoon_debugfs_exit(struct vmballoon *b) { static_key_disable(&balloon_stat_enabled.key); - debugfs_remove(debugfs_lookup("vmmemctl", NULL)); + debugfs_lookup_and_remove("vmmemctl", NULL); kfree(b->stats); b->stats = NULL; }