From patchwork Thu Feb 2 09:23:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maarten Zanders X-Patchwork-Id: 51819 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2388:b0:96:219d:e725 with SMTP id i8csp184871dyf; Thu, 2 Feb 2023 01:27:38 -0800 (PST) X-Google-Smtp-Source: AK7set84kbjJ1Sz33ZMdAD0lnkwwF+0hj2H+govGBeG1N7YEPw/7Ai4N/HzAV9p10pX3umF+07Y+ X-Received: by 2002:a17:902:ea0d:b0:196:7664:39b with SMTP id s13-20020a170902ea0d00b001967664039bmr7346813plg.4.1675330058008; Thu, 02 Feb 2023 01:27:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675330057; cv=none; d=google.com; s=arc-20160816; b=JalLzeJIWbQRvt9rL2BCFei3+59mbzZr1ZmuGN8VAnHXr9hp7KqP7RYlE2pXHp6eA5 SAN9nku1G9tmK3upUC9Ocsx5uAs8QGABqDZkIUDYYIboPhGniCejRBWxAUtkVH0xDgDz c0iu/E707cxSIz7rz8T7D556t6fGOZpcwHIJbAARANSd84IJp3rPS6rCBEhgeIifCe6e MlbUdaK/oede98/39K1i/rf9484PI31esWljqjFNPHxNuLXm2OpQW96cLN7rLvSaoyPb EYqmqMh3/CxOo5XNhHRkrAR1g65TI8kZDge6xnQBMgm3ByLiemCg9sMOZTaSsW+GaPjb BRxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=eJR3j7UgcHI8drkrJokvDJuY/mtil1DqdGHf4t4Su9s=; b=D7Ir4Vymsl+Xl9PhgB7QMMroe8dLHbKF/reVkehmY3HnvD0OFDhNJsq0VZXTyPAkui PAlhsAn3FbOk9brN8umt8/e54GCATAf3BJlQ/Yt/yLFwzVvQvJWFaYeDcBPiPHG9d3a+ ZbDm8tgmSk4H45PRRfSGWGTzTG0hWyLe8l8+BCnBf68kOLQiODGZS54UGMkz2mc4KQ3n 0ndO6Lq9klei558/1hgEII5D1enCVuMQh5j/mtXXwblQMIRR/Z8vJlzFv5ImDwKbQs7J rKWcz9NNmXFmnUFg5tpbLjt7FVBPedPqeP/dmK2b8rUaMiUmvoERyLLaDno4dmTG/lxT QQzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mind.be header.s=google header.b=HFf1Yg0h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ik9-20020a170902ab0900b00193353fb077si22365466plb.346.2023.02.02.01.27.03; Thu, 02 Feb 2023 01:27:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mind.be header.s=google header.b=HFf1Yg0h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232161AbjBBJYI (ORCPT + 99 others); Thu, 2 Feb 2023 04:24:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232004AbjBBJX7 (ORCPT ); Thu, 2 Feb 2023 04:23:59 -0500 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61BEC6F702 for ; Thu, 2 Feb 2023 01:23:57 -0800 (PST) Received: by mail-ej1-x62d.google.com with SMTP id lu11so4182908ejb.3 for ; Thu, 02 Feb 2023 01:23:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mind.be; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eJR3j7UgcHI8drkrJokvDJuY/mtil1DqdGHf4t4Su9s=; b=HFf1Yg0hiyf7Ud6/Vt8BibDYkQo2daDFPEzRUHOyb+CttMOo56Ev8Nw0q1kBnA3tly 5fKuFv3zk5LcnqlGRNae5lfl+iE+GKVrR92DTUpj1bTcj6OnZVbxXRYfRlxP6bsFBWli hHcAmvRRw9hjAG64KlevLHERnv3rn1OcuV68ak7avmw4DN7QQWIJBlr/6xpwQTYstimw tdRDqek2jERGQrZS6/hEUt2mSmUu9ugJInRStSh43SRza+qnsyPXNMApfDJzcJml6DKy /XQ5IzagkYFix8fFKXDE+2lpgr3zqzmauGMhL83Oi0IolTGUZi/aV7Fiu1tqKGwcVPa2 M1Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eJR3j7UgcHI8drkrJokvDJuY/mtil1DqdGHf4t4Su9s=; b=mQUWZQ0jGhWq7QPgc67F+3Aw/NF6p9fdzaf5ujEl0g5XL9cG4GODHTlg7z8grtmynf h0PTDuVzljqIdnd2Mjpb/Yy8Z/FGNYWoAceMW1H3XdKyRQ55igET6dplWEbQkjJn63M0 rmmzOFWPrOjrxOLiQH3MdhTdSr5mr9QpvqGzQGFep0DAyArgW/qoO4V0hvvOHmgBG7cE jI7nSzXlNHW3zJUOCDK5v5+XkxAmthl4Y6icrq/o+eVFYaLQfFhsEij8N5HyiREFxPTt WF2h868XO2Mrnfp27YsAjyse2RXJcIWULB3jQfVBuhv+VKUUdHyiYNGNzZRQu0r4raF+ dxEA== X-Gm-Message-State: AO0yUKXDMzSf4TDQ8EPa4n187AEcrqw3FYkKUq+rxT47VZChgIFG6efg vKJnvQx6Ha4MyIl9MZYRCV41l2coGURdbAly X-Received: by 2002:a17:906:2a50:b0:888:c0b4:7f08 with SMTP id k16-20020a1709062a5000b00888c0b47f08mr5537360eje.29.1675329835902; Thu, 02 Feb 2023 01:23:55 -0800 (PST) Received: from dtpc.zanders.be (78-22-137-109.access.telenet.be. [78.22.137.109]) by smtp.gmail.com with ESMTPSA id j4-20020a170906474400b00856ad9108e7sm11372658ejs.70.2023.02.02.01.23.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Feb 2023 01:23:55 -0800 (PST) From: Maarten Zanders To: Pavel Machek , Lee Jones , Rob Herring , Krzysztof Kozlowski , Jacek Anaszewski Cc: Maarten Zanders , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/2] leds: lp55xx: configure internal charge pump Date: Thu, 2 Feb 2023 10:23:25 +0100 Message-Id: <20230202092325.21241-3-maarten.zanders@mind.be> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20230202092325.21241-1-maarten.zanders@mind.be> References: <20230202092325.21241-1-maarten.zanders@mind.be> MIME-Version: 1.0 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756710888225541385?= X-GMAIL-MSGID: =?utf-8?q?1756710891116995002?= The LP55xx range of devices have an internal charge pump which can (automatically) increase the output voltage towards the LED's, boosting the output voltage to 4.5V. Implement this option from the devicetree. When the setting is not present it will operate in automatic mode as before. Tested on LP55231. Datasheet analysis shows that LP5521, LP5523 and LP8501 are identical in topology and are modified in the same way. Signed-off-by: Maarten Zanders --- drivers/leds/leds-lp5521.c | 12 ++++++------ drivers/leds/leds-lp5523.c | 18 +++++++++++++----- drivers/leds/leds-lp55xx-common.c | 14 ++++++++++++++ drivers/leds/leds-lp8501.c | 8 ++++++-- include/linux/platform_data/leds-lp55xx.h | 3 +++ 5 files changed, 42 insertions(+), 13 deletions(-) diff --git a/drivers/leds/leds-lp5521.c b/drivers/leds/leds-lp5521.c index 19478d9c19a7..76c6b81afb38 100644 --- a/drivers/leds/leds-lp5521.c +++ b/drivers/leds/leds-lp5521.c @@ -58,14 +58,11 @@ /* CONFIG register */ #define LP5521_PWM_HF 0x40 /* PWM: 0 = 256Hz, 1 = 558Hz */ #define LP5521_PWRSAVE_EN 0x20 /* 1 = Power save mode */ -#define LP5521_CP_MODE_OFF 0 /* Charge pump (CP) off */ -#define LP5521_CP_MODE_BYPASS 8 /* CP forced to bypass mode */ -#define LP5521_CP_MODE_1X5 0x10 /* CP forced to 1.5x mode */ -#define LP5521_CP_MODE_AUTO 0x18 /* Automatic mode selection */ +#define LP5521_CP_MODE_MASK 0x18 /* Charge pump mode */ +#define LP5521_CP_MODE_SHIFT 3 #define LP5521_R_TO_BATT 0x04 /* R out: 0 = CP, 1 = Vbat */ #define LP5521_CLK_INT 0x01 /* Internal clock */ -#define LP5521_DEFAULT_CFG \ - (LP5521_PWM_HF | LP5521_PWRSAVE_EN | LP5521_CP_MODE_AUTO) +#define LP5521_DEFAULT_CFG (LP5521_PWM_HF | LP5521_PWRSAVE_EN) /* Status */ #define LP5521_EXT_CLK_USED 0x08 @@ -310,6 +307,9 @@ static int lp5521_post_init_device(struct lp55xx_chip *chip) if (!lp55xx_is_extclk_used(chip)) val |= LP5521_CLK_INT; + val |= (chip->pdata->charge_pump_mode << LP5521_CP_MODE_SHIFT) & + LP5521_CP_MODE_MASK; + ret = lp55xx_write(chip, LP5521_REG_CONFIG, val); if (ret) return ret; diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c index e08e3de1428d..b5d10d4252e6 100644 --- a/drivers/leds/leds-lp5523.c +++ b/drivers/leds/leds-lp5523.c @@ -57,8 +57,12 @@ #define LP5523_AUTO_INC 0x40 #define LP5523_PWR_SAVE 0x20 #define LP5523_PWM_PWR_SAVE 0x04 -#define LP5523_CP_AUTO 0x18 +#define LP5523_CP_MODE_MASK 0x18 +#define LP5523_CP_MODE_SHIFT 3 #define LP5523_AUTO_CLK 0x02 +#define LP5523_DEFAULT_CONFIG \ + (LP5523_AUTO_INC | LP5523_PWR_SAVE |\ + LP5523_AUTO_CLK | LP5523_PWM_PWR_SAVE) #define LP5523_EN_LEDTEST 0x80 #define LP5523_LEDTEST_DONE 0x80 @@ -125,6 +129,7 @@ static void lp5523_set_led_current(struct lp55xx_led *led, u8 led_current) static int lp5523_post_init_device(struct lp55xx_chip *chip) { int ret; + int val; ret = lp55xx_write(chip, LP5523_REG_ENABLE, LP5523_ENABLE); if (ret) @@ -133,10 +138,13 @@ static int lp5523_post_init_device(struct lp55xx_chip *chip) /* Chip startup time is 500 us, 1 - 2 ms gives some margin */ usleep_range(1000, 2000); - ret = lp55xx_write(chip, LP5523_REG_CONFIG, - LP5523_AUTO_INC | LP5523_PWR_SAVE | - LP5523_CP_AUTO | LP5523_AUTO_CLK | - LP5523_PWM_PWR_SAVE); + val = LP5523_DEFAULT_CONFIG; + + val |= (chip->pdata->charge_pump_mode << LP5523_CP_MODE_SHIFT) & + LP5523_CP_MODE_MASK; + + ret = lp55xx_write(chip, LP5523_REG_CONFIG, val); + if (ret) return ret; diff --git a/drivers/leds/leds-lp55xx-common.c b/drivers/leds/leds-lp55xx-common.c index c1940964067a..086033860a6f 100644 --- a/drivers/leds/leds-lp55xx-common.c +++ b/drivers/leds/leds-lp55xx-common.c @@ -19,6 +19,8 @@ #include #include +#include + #include "leds-lp55xx-common.h" /* External clock rate */ @@ -691,6 +693,18 @@ struct lp55xx_platform_data *lp55xx_of_populate_pdata(struct device *dev, i++; } + ret = of_property_read_u8(np, "ti,charge-pump-mode", + &pdata->charge_pump_mode); + if (ret) { + pdata->charge_pump_mode = LP55XX_CP_AUTO; + } else { + if (pdata->charge_pump_mode > LP55XX_CP_AUTO) { + dev_err(dev, "invalid charge pump mode %d\n", + pdata->charge_pump_mode); + return ERR_PTR(-EINVAL); + } + } + of_property_read_string(np, "label", &pdata->label); of_property_read_u8(np, "clock-mode", &pdata->clock_mode); diff --git a/drivers/leds/leds-lp8501.c b/drivers/leds/leds-lp8501.c index ae11a02c0ab2..f0e70e116919 100644 --- a/drivers/leds/leds-lp8501.c +++ b/drivers/leds/leds-lp8501.c @@ -53,10 +53,11 @@ #define LP8501_PWM_PSAVE BIT(7) #define LP8501_AUTO_INC BIT(6) #define LP8501_PWR_SAVE BIT(5) -#define LP8501_CP_AUTO 0x18 +#define LP8501_CP_MODE_MASK 0x18 +#define LP8501_CP_MODE_SHIFT 3 #define LP8501_INT_CLK BIT(0) #define LP8501_DEFAULT_CFG \ - (LP8501_PWM_PSAVE | LP8501_AUTO_INC | LP8501_PWR_SAVE | LP8501_CP_AUTO) + (LP8501_PWM_PSAVE | LP8501_AUTO_INC | LP8501_PWR_SAVE) #define LP8501_REG_RESET 0x3D #define LP8501_RESET 0xFF @@ -102,6 +103,9 @@ static int lp8501_post_init_device(struct lp55xx_chip *chip) if (chip->pdata->clock_mode != LP55XX_CLOCK_EXT) val |= LP8501_INT_CLK; + val |= (chip->pdata->charge_pump_mode << LP8501_CP_MODE_SHIFT) & + LP8501_CP_MODE_MASK; + ret = lp55xx_write(chip, LP8501_REG_CONFIG, val); if (ret) return ret; diff --git a/include/linux/platform_data/leds-lp55xx.h b/include/linux/platform_data/leds-lp55xx.h index 3441064713a3..9a738979e1ce 100644 --- a/include/linux/platform_data/leds-lp55xx.h +++ b/include/linux/platform_data/leds-lp55xx.h @@ -73,6 +73,9 @@ struct lp55xx_platform_data { /* Clock configuration */ u8 clock_mode; + /* Charge pump mode */ + u8 charge_pump_mode; + /* optional enable GPIO */ struct gpio_desc *enable_gpiod;