[07/17] dt-bindings: iommu: apple,sart: Add apple,t8112-sart compatible string

Message ID 20230202-asahi-t8112-dt-v1-7-cb5442d1c229@jannau.net
State New
Headers
Series Device trees for Apple M2 (t8112) based devices |

Commit Message

Janne Grunau Feb. 12, 2023, 3:41 p.m. UTC
  "apple,t8112-sart" as found on the Apple M2 SoC appears to be SART3 as
well. To allow for later discovered incompatibilities use
'"apple,t8112-sart", "apple,t6000-sart"' as compatible string.

Signed-off-by: Janne Grunau <j@jannau.net>

---
This trivial dt-bindings update should be merged through the asahi-soc
tree to ensure validation of the Apple M2 (t8112) devicetrees in this
series.
---
 Documentation/devicetree/bindings/iommu/apple,sart.yaml | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
  

Comments

Krzysztof Kozlowski Feb. 13, 2023, 11:13 a.m. UTC | #1
On 12/02/2023 16:41, Janne Grunau wrote:
> "apple,t8112-sart" as found on the Apple M2 SoC appears to be SART3 as
> well. To allow for later discovered incompatibilities use
> '"apple,t8112-sart", "apple,t6000-sart"' as compatible string.
> 
> Signed-off-by: Janne Grunau <j@jannau.net>
> 
> ---
> This trivial dt-bindings update should be merged through the asahi-soc
> tree to ensure validation of the Apple M2 (t8112) devicetrees in this
> series.

Same comment as in other cases.

> ---
>  Documentation/devicetree/bindings/iommu/apple,sart.yaml | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iommu/apple,sart.yaml b/Documentation/devicetree/bindings/iommu/apple,sart.yaml
> index 1524fa3094ef..07d2d68a87df 100644
> --- a/Documentation/devicetree/bindings/iommu/apple,sart.yaml
> +++ b/Documentation/devicetree/bindings/iommu/apple,sart.yaml
> @@ -28,9 +28,14 @@ description:
>  
>  properties:
>    compatible:
> -    enum:
> -      - apple,t6000-sart
> -      - apple,t8103-sart
> +    oneOf:
> +      - items:
> +          - const: apple,t8112-sart
> +          - const: apple,t6000-sart
> +      - items:

Drop items.

> +          enum:
> +            - apple,t6000-sart
> +            - apple,t8103-sart
>  
>    reg:
>      maxItems: 1
> 

Best regards,
Krzysztof
  
Janne Grunau Feb. 13, 2023, 1:23 p.m. UTC | #2
On 2023-02-13 12:13:55 +0100, Krzysztof Kozlowski wrote:
> On 12/02/2023 16:41, Janne Grunau wrote:
> > "apple,t8112-sart" as found on the Apple M2 SoC appears to be SART3 as
> > well. To allow for later discovered incompatibilities use
> > '"apple,t8112-sart", "apple,t6000-sart"' as compatible string.
> > 
> > Signed-off-by: Janne Grunau <j@jannau.net>
> > 
> > ---
> > This trivial dt-bindings update should be merged through the asahi-soc
> > tree to ensure validation of the Apple M2 (t8112) devicetrees in this
> > series.
> 
> Same comment as in other cases.

dropped from all commits and cover letter.

> > ---
> >  Documentation/devicetree/bindings/iommu/apple,sart.yaml | 11 ++++++++---
> >  1 file changed, 8 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iommu/apple,sart.yaml b/Documentation/devicetree/bindings/iommu/apple,sart.yaml
> > index 1524fa3094ef..07d2d68a87df 100644
> > --- a/Documentation/devicetree/bindings/iommu/apple,sart.yaml
> > +++ b/Documentation/devicetree/bindings/iommu/apple,sart.yaml
> > @@ -28,9 +28,14 @@ description:
> >  
> >  properties:
> >    compatible:
> > -    enum:
> > -      - apple,t6000-sart
> > -      - apple,t8103-sart
> > +    oneOf:
> > +      - items:
> > +          - const: apple,t8112-sart
> > +          - const: apple,t6000-sart
> > +      - items:
> 
> Drop items.

done

> > +          enum:
> > +            - apple,t6000-sart
> > +            - apple,t8103-sart
> >  
> >    reg:
> >      maxItems: 1
> > 

thanks
  

Patch

diff --git a/Documentation/devicetree/bindings/iommu/apple,sart.yaml b/Documentation/devicetree/bindings/iommu/apple,sart.yaml
index 1524fa3094ef..07d2d68a87df 100644
--- a/Documentation/devicetree/bindings/iommu/apple,sart.yaml
+++ b/Documentation/devicetree/bindings/iommu/apple,sart.yaml
@@ -28,9 +28,14 @@  description:
 
 properties:
   compatible:
-    enum:
-      - apple,t6000-sart
-      - apple,t8103-sart
+    oneOf:
+      - items:
+          - const: apple,t8112-sart
+          - const: apple,t6000-sart
+      - items:
+          enum:
+            - apple,t6000-sart
+            - apple,t8103-sart
 
   reg:
     maxItems: 1