| Message ID | 20230202-asahi-t8112-dt-v1-16-cb5442d1c229@jannau.net |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1949289wrn;
Sun, 12 Feb 2023 07:45:13 -0800 (PST)
X-Google-Smtp-Source:
AK7set/qnpvXRdsAJFpkpcwrRVmP7zZdolv1xofL1XPtJnRDR4Xi5e4fO8yooC/nBUj1zAz+MHQb
X-Received: by 2002:a05:6a20:a006:b0:bf:58d1:ce95 with SMTP id
p6-20020a056a20a00600b000bf58d1ce95mr12929729pzj.20.1676216713067;
Sun, 12 Feb 2023 07:45:13 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1676216713; cv=none;
d=google.com; s=arc-20160816;
b=QA99msnxvdF7zw7ze0VDM9DHv3JaV1RtI+b1XlWckr1L1GtS/kI0aeRbiiJSKIMGwy
nuvrKMmoUNV5vyBnxt5XQmLou0dr2+9Knf9yBd4TsTzFe+NP8YLCEUZEwGnYCnV0E/FX
iFjE9Xbcq6TWL0Eet3BnXuOhxTqd/G2yTRSS3H/RyVwSRZxBYRw1tnTi12zS5uNNn9uz
A9lmKxoikITLFOE7n2J2GRYxjQ14D83r1Va3LDTJvfihyJS+fWOwKe4Z/V1D/ushx8s5
Z33nWO0BT+kuEakyVD9k1bCm2Lky0qwmfa0xS57oSMOCdNMOvb/tF4JzXSrEMjpxL+ti
UKbA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from;
bh=fogyXuIHqVsc7ugJL0sAywZb6e4YqUQA4r2GMH5iWP4=;
b=ICKQj8hpYCWhUQXDo7fHyur1ozVbJs/7CBDTzOI4d933bfdaR2M/0aQvjJmSPJUndx
wbYOi0liasa/R4fNmprpBVFddtuvg+hijiPDXk8zkZcbOoc1pVe7Mcfhvcdkbz1wb6na
xxRNIrxJnSmnnCb3uHGh99ajS0cFV7xmbEtXbv6h9yjFuknuqabxlwrEmTymRGPeWfuP
2HSxo/boxfB3nAJcc8LTeDzDXEdOXftk9s6FI/X38C+/OD5b2Cw0h2xPhLt4NSPZmxEz
Dcu0vCQ70hZrTMUrBg5AQZnD9fJ5dhnYNJAg9IQh0PNggyfJia4+6IRacXxSqTpkrPHe
JEaw==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
w15-20020a63a74f000000b004e009a12872si9181732pgo.254.2023.02.12.07.45.00;
Sun, 12 Feb 2023 07:45:13 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229754AbjBLPmN (ORCPT <rfc822;tebrre53rla2o@gmail.com>
+ 99 others); Sun, 12 Feb 2023 10:42:13 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39910 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229799AbjBLPlo (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Sun, 12 Feb 2023 10:41:44 -0500
Received: from soltyk.jannau.net (soltyk.jannau.net [144.76.91.90])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACF5ACC11;
Sun, 12 Feb 2023 07:41:38 -0800 (PST)
Received: from robin.home.jannau.net (p579ad32f.dip0.t-ipconnect.de
[87.154.211.47])
by soltyk.jannau.net (Postfix) with ESMTPSA id 35BBD26F795;
Sun, 12 Feb 2023 16:41:37 +0100 (CET)
From: Janne Grunau <j@jannau.net>
To: Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Mark Kettenis <kettenis@openbsd.org>
Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 16/17] dt-bindings: arm: apple: Add t8112 j413/j473/j493
compatibles
Date: Sun, 12 Feb 2023 16:41:26 +0100
Message-Id: <20230202-asahi-t8112-dt-v1-16-cb5442d1c229@jannau.net>
X-Mailer: git-send-email 2.39.1
In-Reply-To: <20230202-asahi-t8112-dt-v1-0-cb5442d1c229@jannau.net>
References: <20230202-asahi-t8112-dt-v1-0-cb5442d1c229@jannau.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
X-Mailer: b4 0.12.1
X-Developer-Signature: v=1; a=openpgp-sha256; l=1495; i=j@jannau.net;
h=from:subject:message-id; bh=LZlfmrMLh355hrUXDWcy/Nqo+IlGvelXqULXx2QN1vU=;
b=owGbwMvMwCG2UNrmdq9+ahrjabUkhuSX7Cd1W5Vm6KsVCumuuC4RJqnrceWhffae///vnrSf6
BWhcWVNRykLgxgHg6yYIkuS9ssOhtU1ijG1D8Jg5rAygQxh4OIUgIkcmMfwP9uyPe7jJbv98xj5
kx7+O7ztKLfUyYNFWk0qe7lc6szcvBgZbnnn9S7r2+nfIq2qYRA+My7Q49ztVYEdZ6QzxRdHy0j
wAQA=
X-Developer-Key: i=j@jannau.net; a=openpgp;
fpr=8B336A6BE4E5695E89B8532B81E806F586338419
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE,
SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1757640615961490242?=
X-GMAIL-MSGID: =?utf-8?q?1757640615961490242?=
|
| Series |
Device trees for Apple M2 (t8112) based devices
|
|
Commit Message
Janne Grunau
Feb. 12, 2023, 3:41 p.m. UTC
This adds the following apple,t8112 platforms:
- apple,j413 - MacBook Air (M2, 2022)
- apple,j473 - Mac mini (M2, 2023)
- apple,j493 - MacBook Pro (13-inch, M2, 2022)
Signed-off-by: Janne Grunau <j@jannau.net>
---
Documentation/devicetree/bindings/arm/apple.yaml | 15 +++++++++++++++
1 file changed, 15 insertions(+)
Comments
On 12/02/2023 16:41, Janne Grunau wrote: > This adds the following apple,t8112 platforms: > > - apple,j413 - MacBook Air (M2, 2022) > - apple,j473 - Mac mini (M2, 2023) > - apple,j493 - MacBook Pro (13-inch, M2, 2022) > > Signed-off-by: Janne Grunau <j@jannau.net> > --- > Documentation/devicetree/bindings/arm/apple.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/apple.yaml b/Documentation/devicetree/bindings/arm/apple.yaml > index da78c69774f2..883fd67e3752 100644 > --- a/Documentation/devicetree/bindings/arm/apple.yaml > +++ b/Documentation/devicetree/bindings/arm/apple.yaml > @@ -19,6 +19,12 @@ description: | > - MacBook Air (M1, 2020) > - iMac (24-inch, M1, 2021) > > + Devices based on the "M2" SoC: > + > + - MacBook Air (M2, 2022) > + - MacBook Pro (13-inch, M2, 2022) > + - Mac mini (M2, 2023) Aren't you now repeating exactly what is in the schema? Keep only one... > + > And devices based on the "M1 Pro", "M1 Max" and "M1 Ultra" SoCs: > > - MacBook Pro (14-inch, M1 Pro, 2021) > @@ -70,6 +76,15 @@ properties: > - const: apple,t8103 > - const: apple,arm-platform > > + - description: Apple M2 SoC based platforms > + items: > + - enum: > + - apple,j413 # MacBook Air (M2, 2022) > + - apple,j473 # Mac mini (M2, 2023) > + - apple,j493 # MacBook Pro (13-inch, M2, 2022) Best regards, Krzysztof
On 2023-02-13 12:15:55 +0100, Krzysztof Kozlowski wrote: > On 12/02/2023 16:41, Janne Grunau wrote: > > This adds the following apple,t8112 platforms: > > > > - apple,j413 - MacBook Air (M2, 2022) > > - apple,j473 - Mac mini (M2, 2023) > > - apple,j493 - MacBook Pro (13-inch, M2, 2022) > > > > Signed-off-by: Janne Grunau <j@jannau.net> > > --- > > Documentation/devicetree/bindings/arm/apple.yaml | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/apple.yaml b/Documentation/devicetree/bindings/arm/apple.yaml > > index da78c69774f2..883fd67e3752 100644 > > --- a/Documentation/devicetree/bindings/arm/apple.yaml > > +++ b/Documentation/devicetree/bindings/arm/apple.yaml > > @@ -19,6 +19,12 @@ description: | > > - MacBook Air (M1, 2020) > > - iMac (24-inch, M1, 2021) > > > > + Devices based on the "M2" SoC: > > + > > + - MacBook Air (M2, 2022) > > + - MacBook Pro (13-inch, M2, 2022) > > + - Mac mini (M2, 2023) > > Aren't you now repeating exactly what is in the schema? Keep only one... yes but I think the duplication is OK. I consider the description for human consumption and the schema for computer consumption. The comments in the schema are aids to for editing the schema. This follows the existing pattern for M1 and M1 Pro/Max/Ultra based devices in this file. Janne
On 12/02/2023 16:41, Janne Grunau wrote: > - MacBook Pro (14-inch, M1 Pro, 2021) > @@ -70,6 +76,15 @@ properties: > - const: apple,t8103 > - const: apple,arm-platform > > + - description: Apple M2 SoC based platforms > + items: > + - enum: > + - apple,j413 # MacBook Air (M2, 2022) > + - apple,j473 # Mac mini (M2, 2023) > + - apple,j493 # MacBook Pro (13-inch, M2, 2022) > + - const: apple,t8112 > + - const: apple,arm-platform Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/apple.yaml b/Documentation/devicetree/bindings/arm/apple.yaml index da78c69774f2..883fd67e3752 100644 --- a/Documentation/devicetree/bindings/arm/apple.yaml +++ b/Documentation/devicetree/bindings/arm/apple.yaml @@ -19,6 +19,12 @@ description: | - MacBook Air (M1, 2020) - iMac (24-inch, M1, 2021) + Devices based on the "M2" SoC: + + - MacBook Air (M2, 2022) + - MacBook Pro (13-inch, M2, 2022) + - Mac mini (M2, 2023) + And devices based on the "M1 Pro", "M1 Max" and "M1 Ultra" SoCs: - MacBook Pro (14-inch, M1 Pro, 2021) @@ -70,6 +76,15 @@ properties: - const: apple,t8103 - const: apple,arm-platform + - description: Apple M2 SoC based platforms + items: + - enum: + - apple,j413 # MacBook Air (M2, 2022) + - apple,j473 # Mac mini (M2, 2023) + - apple,j493 # MacBook Pro (13-inch, M2, 2022) + - const: apple,t8112 + - const: apple,arm-platform + - description: Apple M1 Pro SoC based platforms items: - enum: