From patchwork Wed Feb 1 21:49:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Diederik de Haas X-Patchwork-Id: 51580 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp530671wrn; Wed, 1 Feb 2023 13:54:10 -0800 (PST) X-Google-Smtp-Source: AK7set92n1qVr37EfSJzXYbtdI73Uv42x3EaOxCZuvlFptdQplR1tLCfR63QTamI/23evX68G4hd X-Received: by 2002:a17:906:9610:b0:887:dea8:b025 with SMTP id s16-20020a170906961000b00887dea8b025mr4837024ejx.65.1675288450046; Wed, 01 Feb 2023 13:54:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675288450; cv=none; d=google.com; s=arc-20160816; b=eeA6DoZ5mRg2MXEEhe6LW/qdgnqIcv/mwfxzvuGBj9H8Hnf2A+2BnvfhS4K3N9ND3Z TFDeOBerIlclTUa/jn51onRjwslJrQFu4JD4rwo/enfpat/m4Kisp34cvN+SjQT19tmJ Y9HyQR9aMzp++TWyfJJM/FiACJb+q0zQIJyJGmzkcJ3S9osf85drnzHmaktPBG8DFq+5 jwH+0hbywa60OMcqcl+YKEH4hwrVHL1GR9GKm4Ek3NTaR/OBk8tyCMi5duqp7wTNUHJF J+i56wmRnra2Pst7BGHId4xwMdPNFj/ElXFdI3JzfVYaLdOOwv5ttX9jXgBNVchXWdkM Ytiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=h+XTgTAcp7xkDDp8Z5lB0DCJJ65Fz+11F3g/c0ynED4=; b=lLDqq4/gBcHS/9t4Zg1yplQW+9p2NgVja7HWTDOI2DFSzmfesQsZEEFnT7rge5MYAv B5RsCWCFmuVKrdATFojwpeDd1yGp2LcpUX/7487nywazTxXWUbqyAM02NqpUIz16xv5z XSWt+EZhVteUwSEoqa2QXehCnk+XWpQpyURtz4w6g1UsAVxByV1w48SLWG5zImO1f9H/ bvSQsqrPOcpT/kETbtWsRRT8M7a0T6i/wsC4pCwvO5wsJGOwRD2ZHMetrGwp1TvLGkk6 SfOkmGDvUOuTDTf3UFe3pRF2xfG4OllP6eLELIREZoaLxUwl29iZsOtOcLfM+KCUxDtt 7tBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id if10-20020a170906df4a00b0088e0dce76afsi2514096ejc.979.2023.02.01.13.53.24; Wed, 01 Feb 2023 13:54:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231330AbjBAVux (ORCPT + 99 others); Wed, 1 Feb 2023 16:50:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231276AbjBAVuu (ORCPT ); Wed, 1 Feb 2023 16:50:50 -0500 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::221]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D81BA86BF; Wed, 1 Feb 2023 13:50:46 -0800 (PST) Received: (Authenticated sender: didi.debian@cknow.org) by mail.gandi.net (Postfix) with ESMTPSA id 7CDE3240002; Wed, 1 Feb 2023 21:50:42 +0000 (UTC) From: Diederik de Haas To: Carsten Haitzler , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo Cc: Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Diederik de Haas Subject: [PATCH 2/2] perf test: Replace legacy `...` with $(...) Date: Wed, 1 Feb 2023 22:49:45 +0100 Message-Id: <20230201214945.127474-3-didi.debian@cknow.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230201214945.127474-1-didi.debian@cknow.org> References: <20230201214945.127474-1-didi.debian@cknow.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756667261659217875?= X-GMAIL-MSGID: =?utf-8?q?1756667261659217875?= As detailed in https://www.shellcheck.net/wiki/SC2006: The use of `...` is legacy syntax with several issues: 1. It has a series of undefined behaviors related to quoting in POSIX. 2. It imposes a custom escaping mode with surprising results. 3. It's exceptionally hard to nest. $(...) command substitution has none of these problems, and is therefore strongly encouraged. Signed-off-by: Diederik de Haas --- tools/perf/tests/shell/lib/coresight.sh | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tools/perf/tests/shell/lib/coresight.sh b/tools/perf/tests/shell/lib/coresight.sh index 7e27e5c5bc9c..6c3d34ec64d8 100644 --- a/tools/perf/tests/shell/lib/coresight.sh +++ b/tools/perf/tests/shell/lib/coresight.sh @@ -58,9 +58,9 @@ perf_dump_aux_verify() { # compiler may produce different code depending on the compiler and # optimization options, so this is rough just to see if we're # either missing almost all the data or all of it - ATOM_FX_NUM=`grep -c I_ATOM_F "$DUMP"` - ASYNC_NUM=`grep -c I_ASYNC "$DUMP"` - TRACE_INFO_NUM=`grep -c I_TRACE_INFO "$DUMP"` + ATOM_FX_NUM=$(grep -c I_ATOM_F "$DUMP") + ASYNC_NUM=$(grep -c I_ASYNC "$DUMP") + TRACE_INFO_NUM=$(grep -c I_TRACE_INFO "$DUMP") rm -f "$DUMP" # Arguments provide minimums for a pass @@ -96,18 +96,18 @@ perf_dump_aux_tid_verify() { # The TID test tools will print a TID per stdout line that are being # tested - TIDS=`cat "$2"` + TIDS=$(cat "$2") # Scan the perf report to find the TIDs that are actually CID in hex # and build a list of the ones found - FOUND_TIDS=`perf report --stdio --dump -i "$1" | \ + FOUND_TIDS=$(perf report --stdio --dump -i "$1" | \ grep -o "CID=0x[0-9a-z]\+" | sed 's/CID=//g' | \ - uniq | sort | uniq` + uniq | sort | uniq) # No CID=xxx found - maybe your kernel is reporting these as # VMID=xxx so look there if test -z "$FOUND_TIDS"; then - FOUND_TIDS=`perf report --stdio --dump -i "$1" | \ + FOUND_TIDS=$(perf report --stdio --dump -i "$1" | \ grep -o "VMID=0x[0-9a-z]\+" | sed 's/VMID=//g' | \ - uniq | sort | uniq` + uniq | sort | uniq) fi # Iterate over the list of TIDs that the test says it has and find @@ -116,7 +116,7 @@ perf_dump_aux_tid_verify() { for TID2 in $TIDS; do FOUND="" for TIDHEX in $FOUND_TIDS; do - TID=`printf "%i" $TIDHEX` + TID=$(printf "%i" $TIDHEX) if test "$TID" -eq "$TID2"; then FOUND="y" break