From patchwork Wed Feb 1 21:49:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Diederik de Haas X-Patchwork-Id: 51579 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp530366wrn; Wed, 1 Feb 2023 13:53:17 -0800 (PST) X-Google-Smtp-Source: AK7set81lUdGpYqx9yfK9r8dgcz1bkVdS4zMorKLzZbypiwRX3xSHyMLnVK8UD73a0W2ZP25B6Fs X-Received: by 2002:a17:906:4b57:b0:87b:d41b:67dc with SMTP id j23-20020a1709064b5700b0087bd41b67dcmr3351836ejv.74.1675288397746; Wed, 01 Feb 2023 13:53:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675288397; cv=none; d=google.com; s=arc-20160816; b=edSaxyVimP1trS1Fp7p5qNfMH28A9gTljOXPwIiyszmrHONdKCqZZ0RvPQIL1ganoy tafHbsPHuqxxP5tr8b0vOFLdW3BLrXxbdxQQ9S5bH//OE9G5GXq1Z/NOC08IPO+o6SIk Nr9UWq4/69PGbw0iSx1LRFWrMpA1lo2NizDW0jJGogt1pQpVelElNYumoJRpoCHEFR7x pVyxAWhcAhu1d3GH3Er2DQGzWF5fNNlUr+RmM8/qy5PMLJi8KhToEV6kBrePwb8/KuDl 9j2nEZnnFdJhPPYeO99z8uN+j2madhEGKVRUatQaQ1AWcQiMv4bsDVnt1JvAVdOV7sv/ +pOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=tCAxvihNusRq/ytmYAX8DrKPf+YA8fYFNPxYfIce7vc=; b=o3D5Ttpb2IvjghRcbFBK4Djm8UsNCLyq/HQaWcaayE+o+UzDiV4GxFtYu4c9WfGtKw 9UiEwLz7ZRsKFXiOCKbuezoS66j+Z/T7fXgbIeGv55DGLrDrTSew0+wIoaSyU/DsKvSW BclmNABOofEhmH+yFK0QzCm/gHlHgrFO1a/ceOcNH+KQd7n7yNzaAvlo/h4q+9VbmtJV LQC4n05rytteKevu93rpjgwLCnRhgBW+vqF4bQSwZFVW+sYyoG7KJkXG4Zh00TJIhY63 6OqRd/OUmhhkVFdVfUtmptlFzVm2/lNPJh6CjVKa6IYca630pBl9qMw1FbcUJ+1DBY64 Qrmw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 13-20020a170906004d00b0088787e25104si13411228ejg.232.2023.02.01.13.52.54; Wed, 01 Feb 2023 13:53:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230444AbjBAVul (ORCPT + 99 others); Wed, 1 Feb 2023 16:50:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229539AbjBAVuj (ORCPT ); Wed, 1 Feb 2023 16:50:39 -0500 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 277264C1E; Wed, 1 Feb 2023 13:50:37 -0800 (PST) Received: (Authenticated sender: didi.debian@cknow.org) by mail.gandi.net (Postfix) with ESMTPSA id 7B04F240008; Wed, 1 Feb 2023 21:50:32 +0000 (UTC) From: Diederik de Haas To: Carsten Haitzler , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo Cc: Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Diederik de Haas Subject: [PATCH 1/2] perf test: Replace 'grep | wc -l' with 'grep -c' Date: Wed, 1 Feb 2023 22:49:44 +0100 Message-Id: <20230201214945.127474-2-didi.debian@cknow.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230201214945.127474-1-didi.debian@cknow.org> References: <20230201214945.127474-1-didi.debian@cknow.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756667206987706811?= X-GMAIL-MSGID: =?utf-8?q?1756667206987706811?= To count the number of results from grep, use the '-c' parameter instead of piping it to 'wc'. See also https://www.shellcheck.net/wiki/SC2126 Signed-off-by: Diederik de Haas --- tools/perf/tests/shell/lib/coresight.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/perf/tests/shell/lib/coresight.sh b/tools/perf/tests/shell/lib/coresight.sh index 45a1477256b6..7e27e5c5bc9c 100644 --- a/tools/perf/tests/shell/lib/coresight.sh +++ b/tools/perf/tests/shell/lib/coresight.sh @@ -58,9 +58,9 @@ perf_dump_aux_verify() { # compiler may produce different code depending on the compiler and # optimization options, so this is rough just to see if we're # either missing almost all the data or all of it - ATOM_FX_NUM=`grep I_ATOM_F "$DUMP" | wc -l` - ASYNC_NUM=`grep I_ASYNC "$DUMP" | wc -l` - TRACE_INFO_NUM=`grep I_TRACE_INFO "$DUMP" | wc -l` + ATOM_FX_NUM=`grep -c I_ATOM_F "$DUMP"` + ASYNC_NUM=`grep -c I_ASYNC "$DUMP"` + TRACE_INFO_NUM=`grep -c I_TRACE_INFO "$DUMP"` rm -f "$DUMP" # Arguments provide minimums for a pass