From patchwork Wed Feb 1 20:43:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Usama Arif X-Patchwork-Id: 51561 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp502797wrn; Wed, 1 Feb 2023 12:47:12 -0800 (PST) X-Google-Smtp-Source: AK7set9Icg1K838VnYv9RwnwoRtm/1DjhB3yPmwewLnNmWIZNIJ5yQ5Y1dXTrkGdODInL866O7/q X-Received: by 2002:a05:6a00:2491:b0:593:ec73:424d with SMTP id c17-20020a056a00249100b00593ec73424dmr4439921pfv.8.1675284432623; Wed, 01 Feb 2023 12:47:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675284432; cv=none; d=google.com; s=arc-20160816; b=DeDR++zk+dZdWuTCIckWueSgSd1+GPcSrESaGZdnBePkg+TLA0JBfDiGNLIif2fY9m Ejb6+At9htaO0LPLMdGjYdbHRtpYU0KGE2jt8V+es6RsXtgcjjBNWIp/yx0H1w70oGbc avoSbs+CP7NOPuJ3brayu7sQeDXF6ponC/XbHtGMANqcVI/B6iUG8uEP3LCZOoP5ut14 cDWzBRSWixzr3f/GBh9plbBWR2lZQx25aayuT2rb3qgoPtCKJs8qVNI/33op9LFVOOtY 29fCuEjBSn6EFh/nG2VUz6gMS3JkQ3L012HWfOP2PK60waAK8jEuXV+Sd7U07X+PXYRH hBpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Si9kzr7Ck9J5FJkWCPsjkhUgmegMqi5GAbSuKxlmi/Y=; b=LXI6bvcIDFhYM33ixDObh1KkZ9fCEJZNgKfwohJIY0lHMST8UYVqZC5ciRxv3te5Fo KPkDoE+Om7uv8REGP/ftC7Gt6eMcUJge0FJrgCGuE+qqbs/WDzr0O/SKmAImd9/ZO1tQ 8tqlMAfcEJsHzo7DPdq01Y6tZ3DWCW6SDLzvaqa8SO3tYrBh+lj9ikoD1lX7s57EIay/ GAZ5ccFHJJwEHbAmqqgP63BndsWxCO9nz0rG5EFVlOTB3l0ApEk3OaJwjQzRV1MhaPjc 3TgMwaZtCxbjL/44oBLrrYG2kbfRVxC86qdKcBfJWTA8xMmjU4gJv8oRXX1dQEBDs9+W fb+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b="sXMxj/CK"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a204-20020a621ad5000000b00592591f1972si19480878pfa.64.2023.02.01.12.46.56; Wed, 01 Feb 2023 12:47:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b="sXMxj/CK"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231778AbjBAUqL (ORCPT + 99 others); Wed, 1 Feb 2023 15:46:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231357AbjBAUpf (ORCPT ); Wed, 1 Feb 2023 15:45:35 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4148978AEB for ; Wed, 1 Feb 2023 12:44:56 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id t7so10140833wrp.5 for ; Wed, 01 Feb 2023 12:44:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Si9kzr7Ck9J5FJkWCPsjkhUgmegMqi5GAbSuKxlmi/Y=; b=sXMxj/CKJBGFdLzPqQuDQiOPwKF/J04CKNI5iVbGlsHYa+yHZsQXZ/welJivcDAh78 03XN/aIk9smRRSJBbVcD8A7xCJQW537kgAuRtyai14FS8t0ukXFaqkwlkudC99dkmvdN rtlhlvW0kPQwaNg8Yz96FxnRXUt/hZZ4kDgRUlcTj6wrqyrl6sv/drdH7ZlZp7N0xpgr 7/F+R8t/koV++BDvOKRHqSKkhTRC4E1+ivjSfL+Y8IvbVH6WudoBt9K7CLfIp39iEZO0 iRMQLwcQy13UYZ9od7HzZ4VJNpiv6qQnkv1bEA/lGY/7VjTyfJn1TzJcGWgdw61ICEHi 8K6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Si9kzr7Ck9J5FJkWCPsjkhUgmegMqi5GAbSuKxlmi/Y=; b=mSl9Ss1kYMYSWhn52Oie8qyeElB5+MZGhihCtrtDR3yt3YOF0VQybmXSSfRo17jV6m FmONZgnZMjRGHCvSSBa+9AxFyQvsw8cRzEa06nYIyL/M22sdcqJHL1XGKes7pyDkc2Ie /PnNBSHxrDmgTX//ak8QNApIxUS35xL93m9c0HMLiadwFOkBnaYfNawJ2gc0hX/BeuoJ uMsR9dgDMU4AThXUWfbTdILs8BlaS68zaM8NCzQRMndFj3p7WIV3gbng8s8sXBXHlEua jq5jn9AxoyjEMmXYF5OEQEUVpcd+oTweo+cZoO+7TaroXo8S1eUvmbTBWSCT6hhuFnGi VatA== X-Gm-Message-State: AO0yUKXI7S/7qIMNpVOBT3pwG9tqbuVq7KwXg0b+TnpLQey5QDyF/b5E 0izwzK0UsJMCriR/LSVgxrctIQ== X-Received: by 2002:adf:fb8f:0:b0:2c1:28dc:1566 with SMTP id a15-20020adffb8f000000b002c128dc1566mr99026wrr.41.1675284294722; Wed, 01 Feb 2023 12:44:54 -0800 (PST) Received: from usaari01.cust.communityfibre.co.uk ([2a02:6b6a:b566:0:7611:c340:3d8d:d46c]) by smtp.gmail.com with ESMTPSA id n15-20020a5d598f000000b002bdff778d87sm19993584wri.34.2023.02.01.12.44.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 12:44:54 -0800 (PST) From: Usama Arif To: dwmw2@infradead.org, tglx@linutronix.de Cc: mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, x86@kernel.org, pbonzini@redhat.com, paulmck@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, rcu@vger.kernel.org, mimoja@mimoja.de, hewenliang4@huawei.com, thomas.lendacky@amd.com, seanjc@google.com, pmenzel@molgen.mpg.de, fam.zheng@bytedance.com, punit.agrawal@bytedance.com, simon.evans@bytedance.com, liangma@liangbit.com, David Woodhouse Subject: [PATCH 8/9] x86/mtrr: Avoid repeated save of MTRRs on boot-time CPU bringup Date: Wed, 1 Feb 2023 20:43:37 +0000 Message-Id: <20230201204338.1337562-9-usama.arif@bytedance.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230201204338.1337562-1-usama.arif@bytedance.com> References: <20230201204338.1337562-1-usama.arif@bytedance.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756663049415156923?= X-GMAIL-MSGID: =?utf-8?q?1756663049415156923?= From: David Woodhouse There's no need to repeatedly save the BSP's MTRRs for each AP we bring up at boot time. And there's no need to use smp_call_function_single() even for the one time we *do* want to do it. Signed-off-by: David Woodhouse --- arch/x86/kernel/cpu/mtrr/mtrr.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/x86/kernel/cpu/mtrr/mtrr.c b/arch/x86/kernel/cpu/mtrr/mtrr.c index 2746cac9d8a9..2884017586f1 100644 --- a/arch/x86/kernel/cpu/mtrr/mtrr.c +++ b/arch/x86/kernel/cpu/mtrr/mtrr.c @@ -814,11 +814,20 @@ void mtrr_ap_init(void) */ void mtrr_save_state(void) { + static bool mtrr_saved; int first_cpu; if (!mtrr_enabled()) return; + if (system_state < SYSTEM_RUNNING) { + if (!mtrr_saved) { + mtrr_save_fixed_ranges(NULL); + mtrr_saved = true; + } + return; + } + first_cpu = cpumask_first(cpu_online_mask); smp_call_function_single(first_cpu, mtrr_save_fixed_ranges, NULL, 1); }