From patchwork Wed Feb 1 20:43:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Usama Arif X-Patchwork-Id: 51553 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp502431wrn; Wed, 1 Feb 2023 12:46:20 -0800 (PST) X-Google-Smtp-Source: AK7set+98+mDwktre9w56JEiusHHS83b79jxLcvq7VR9IgJ6du/sFvsQ67GxB0kQxjPTdz82itlz X-Received: by 2002:a17:90b:180f:b0:22b:e5b9:43e9 with SMTP id lw15-20020a17090b180f00b0022be5b943e9mr3861529pjb.25.1675284380516; Wed, 01 Feb 2023 12:46:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675284380; cv=none; d=google.com; s=arc-20160816; b=w7BvzsjptKwGShyDYC38QEUJtbgbxGVHNh6Ix3OkqRK0sD88dUCYzBNQgwzRMehraM iXk6IPv9iiGszli3rDTyvv8Ct+0xsYHJwv0wRbCyugYuztIKqiBCyuJr31xh8QovdOqE 3gSeKQO33D1cYKpWIGa/GpPK44qGYXXRX385nb6OYYv5ZqsVd6oRlD3ax5C4VNbe4G2V s2BAccmZxmBk6CCZr9xE+ZXHBHqo3C6Gj41E22n3NpesSze9Lgbwrh98CZhx7TUw9Fa1 iOPF7QkabFdLnIWor6BvBuk4f+cwFoaqXOxpGTINGmx4Xa5uCHKt8kqMQaAzz9DI6rcF 0BBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cVGzQu3A2f4Qgo78q6jxGuOz9gIN1MMwXavNYjSHKBU=; b=ODKXFXacRvhaj/3aODg/tywafw0Ke5A/iSMFZEkeghzlxQdi8T/7q885gPhP3GJzKB 4XKvVBkuCs3uPnDca61QGex2FJrxp2JwXFvsMyEMgJ5a5+9SwEtrENGB2iF+xFGCSwro WNXcAKWVs7gTThGEmzGJ3JeeK+Um/pAZfXdfqN3Dp57PLDJJ/xw2NVaCuzlRSuVKNT7d IY9rJ5TycxvDurNiTkaWx2Sj/+jTkTDIqiCAmxWcUvE90dNKBB8l8WvcnF9ExQHEinIt 1wFeytNUCEXIiRezo/SyYMs6Z1ymCSbf0f3/rZA8E9H3xy9fY5efCsflRuU28DSPhnuK 3XTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=1pmygf+5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gg24-20020a17090b0a1800b0022915c0c7e2si2611099pjb.64.2023.02.01.12.46.08; Wed, 01 Feb 2023 12:46:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=1pmygf+5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230095AbjBAUpe (ORCPT + 99 others); Wed, 1 Feb 2023 15:45:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230218AbjBAUpU (ORCPT ); Wed, 1 Feb 2023 15:45:20 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A02D77DF0 for ; Wed, 1 Feb 2023 12:44:50 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id m7so18494373wru.8 for ; Wed, 01 Feb 2023 12:44:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cVGzQu3A2f4Qgo78q6jxGuOz9gIN1MMwXavNYjSHKBU=; b=1pmygf+5X1mOOTRudl4VcLIfZwAStujjk3QFGa6j7KBal48TQf/affncmOD3//kkMI rcmGFccJCavXlkXytWAbcm6emsOHDwsjt6vCZUF43+rfAZGCQ79xzEj6NExy3AWl2TIH yqq4qgKbDrRXWSdk/Q6LTGijK2ZwPQRhSwcI44pdzEE7QTuapkzHDgxfAFcajF4pFeiU c+DydIzDTjs9qzHUYHbj4pjAqVKeSBkn3qUBcz10GgDBL1+qKVKQYV54cTXisUVhB59K zisPp3vUaSdjviwrmlQIpnH9yGM9tfJ3vGj1rRhx0PEZ2z+5ua/QBLLFDvzwKxEmVQh9 qy/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cVGzQu3A2f4Qgo78q6jxGuOz9gIN1MMwXavNYjSHKBU=; b=7OfAyEn47Zg174E3qhMxxu1noSQsz2DWAbNPQrvdQ0J5s75eCWvrkChWv8iU75/j/D ZIvXAGWipTuL2+gzTHzmBc942393mcwFNzDrv1G+opJAoHnMke3DU3MhVAoyXbY6ziZJ N8XI6rR/Amszc33CxrIIl+N94LVLXedXKxfJrdybx5vi4VAjPaqsvKdv1foC2qGS4kI+ wifDnMgyBXoLMR7/tm41ucPm/bM8a0YjTT88APoYYc5KT3/7fty8hpZK/Dhb9K++Y7Jq AVKmoY3M9O0YN5s2djA/fh1lwTHEdLT7r6LfFjYOgN/w1ASI5W+5sxt5L5uy61e5RR7c hABQ== X-Gm-Message-State: AO0yUKW+6arreEgvogjcFKky2iiveMSCoF1q4jKD6aEJyaS1VIqC7lYJ HSY4A8jaO8zGGA0xpmJHxKp3FA== X-Received: by 2002:a05:6000:1004:b0:2bf:d332:e123 with SMTP id a4-20020a056000100400b002bfd332e123mr3000451wrx.62.1675284288852; Wed, 01 Feb 2023 12:44:48 -0800 (PST) Received: from usaari01.cust.communityfibre.co.uk ([2a02:6b6a:b566:0:7611:c340:3d8d:d46c]) by smtp.gmail.com with ESMTPSA id n15-20020a5d598f000000b002bdff778d87sm19993584wri.34.2023.02.01.12.44.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 12:44:48 -0800 (PST) From: Usama Arif To: dwmw2@infradead.org, tglx@linutronix.de Cc: mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, x86@kernel.org, pbonzini@redhat.com, paulmck@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, rcu@vger.kernel.org, mimoja@mimoja.de, hewenliang4@huawei.com, thomas.lendacky@amd.com, seanjc@google.com, pmenzel@molgen.mpg.de, fam.zheng@bytedance.com, punit.agrawal@bytedance.com, simon.evans@bytedance.com, liangma@liangbit.com, David Woodhouse Subject: [PATCH 2/9] cpu/hotplug: Move idle_thread_get() to Date: Wed, 1 Feb 2023 20:43:31 +0000 Message-Id: <20230201204338.1337562-3-usama.arif@bytedance.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230201204338.1337562-1-usama.arif@bytedance.com> References: <20230201204338.1337562-1-usama.arif@bytedance.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756662994443695910?= X-GMAIL-MSGID: =?utf-8?q?1756662994443695910?= From: David Woodhouse Instead of relying purely on the special-case wrapper in bringup_cpu() to pass the idle thread to __cpu_up(), expose idle_thread_get() so that the architecture code can obtain it directly when necessary. This will be useful when the existing __cpu_up() is split into multiple phases, only *one* of which will actually need the idle thread. If the architecture code is to register its new pre-bringup states with the cpuhp core, having a special-case wrapper to pass extra arguments is non-trivial and it's easier just to let the arch register its function pointer to be invoked with the standard API. Signed-off-by: David Woodhouse --- include/linux/smpboot.h | 7 +++++++ kernel/smpboot.h | 2 -- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/include/linux/smpboot.h b/include/linux/smpboot.h index 9d1bc65d226c..3862addcaa34 100644 --- a/include/linux/smpboot.h +++ b/include/linux/smpboot.h @@ -5,6 +5,13 @@ #include struct task_struct; + +#ifdef CONFIG_GENERIC_SMP_IDLE_THREAD +struct task_struct *idle_thread_get(unsigned int cpu); +#else +static inline struct task_struct *idle_thread_get(unsigned int cpu) { return NULL; } +#endif + /* Cookie handed to the thread_fn*/ struct smpboot_thread_data; diff --git a/kernel/smpboot.h b/kernel/smpboot.h index 34dd3d7ba40b..60c609318ad6 100644 --- a/kernel/smpboot.h +++ b/kernel/smpboot.h @@ -5,11 +5,9 @@ struct task_struct; #ifdef CONFIG_GENERIC_SMP_IDLE_THREAD -struct task_struct *idle_thread_get(unsigned int cpu); void idle_thread_set_boot_cpu(void); void idle_threads_init(void); #else -static inline struct task_struct *idle_thread_get(unsigned int cpu) { return NULL; } static inline void idle_thread_set_boot_cpu(void) { } static inline void idle_threads_init(void) { } #endif