From patchwork Wed Feb 1 14:58:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 51373 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp325394wrn; Wed, 1 Feb 2023 07:01:30 -0800 (PST) X-Google-Smtp-Source: AK7set+0/INS6kw98wORdd9yjFcaBY+bawXvtfYe9iito9Da++AyASxObCo3DVCebFi5Zbn3V9N5 X-Received: by 2002:a17:90b:4c47:b0:22c:7e2a:efc5 with SMTP id np7-20020a17090b4c4700b0022c7e2aefc5mr2486128pjb.37.1675263690226; Wed, 01 Feb 2023 07:01:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675263690; cv=none; d=google.com; s=arc-20160816; b=vyv63FzOTW3eAd6qCok9fZdZY768R9gdaC1JJXaC6Fa5OlBIwO94Vg756lxtjhXcXP tD52hKnfzFEu4224E2EiJ3G9ot13fqbHHddNsa+vXYf5eBJTvzn1IdPYW+23dQyzirgX KqEIQuN3oGsgs+K7ZytEXZdLUADg6xw0LlpVl1mTVBwN7/o2KnVGn2aledrqtPD5nrlV qm1dXNfXWZdjYvRCyztNgFQPWirRn2JxON/P5ZIe0cfOrCce8Qq3SbCdUXrLGBfuQ0Nw fbK95zhLlB8zIK0jT21UoHSfDjF823rqPIGeZGGnxHeNF+h9A1+I5uIRSNRbIwtjLXE4 /2vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=SLk4uSBFotmnc+dasetRUvH0sOidjQR5xYHHp0XtVyo=; b=m9KQ2q+r7vK1y20hs3WgN2hy2WluTDFfKJsvQsnWq3j2CfKBSORlRuItFAlmcJlU+B 47J+NpOkQMDDP4juDbFrt76sopBarIyQF27wutzQD5+8ylVdD9/Vr818o5I4nmjdVutE RyJEPdCQ8MN+WQNxGEALVeuOg4quo5100zp/zKGx3+VdmdqSzPbkFBy9iYzPHsAP5cEo CpEou7JJLNBaPd5wzKbkJ6+k6ZS/A1+778tpJh3UtMuglOq1qeV+wffv6gaBVZEpL3A1 a9vHanqLfVGtD9SJ8I5uK1EhEvvCBZXTbZMKzMpN0kRWhOz1r7M6m91/TkPdafHE3mpN Dfjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pi13-20020a17090b1e4d00b0022bac52ab07si2196740pjb.16.2023.02.01.07.01.17; Wed, 01 Feb 2023 07:01:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231501AbjBAO7f (ORCPT + 99 others); Wed, 1 Feb 2023 09:59:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231956AbjBAO7F (ORCPT ); Wed, 1 Feb 2023 09:59:05 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8208C6AC96 for ; Wed, 1 Feb 2023 06:59:03 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pNEZY-0002rV-0D; Wed, 01 Feb 2023 15:58:52 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pNEZV-001w14-Pv; Wed, 01 Feb 2023 15:58:48 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pNEZT-009hVZ-CN; Wed, 01 Feb 2023 15:58:47 +0100 From: Oleksij Rempel To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Wei Fang , Heiner Kallweit Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Arun.Ramadoss@microchip.com, intel-wired-lan@lists.osuosl.org Subject: [PATCH net-next v4 07/23] net: phy: c45: migrate to genphy_c45_write_eee_adv() Date: Wed, 1 Feb 2023 15:58:29 +0100 Message-Id: <20230201145845.2312060-8-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230201145845.2312060-1-o.rempel@pengutronix.de> References: <20230201145845.2312060-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756641299081510053?= X-GMAIL-MSGID: =?utf-8?q?1756641299081510053?= Migrate from genphy_config_eee_advert() to genphy_c45_write_eee_adv(). It should work as before except write operation to the EEE adv registers will be done only if some EEE abilities was detected. If some driver will have a regression, related driver should provide own .get_features callback. See micrel.c:ksz9477_get_features() as example. Signed-off-by: Oleksij Rempel --- drivers/net/phy/phy-c45.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c index 9582c8bf74ec..6149e8c3243f 100644 --- a/drivers/net/phy/phy-c45.c +++ b/drivers/net/phy/phy-c45.c @@ -262,7 +262,11 @@ int genphy_c45_an_config_aneg(struct phy_device *phydev) linkmode_and(phydev->advertising, phydev->advertising, phydev->supported); - changed = genphy_config_eee_advert(phydev); + ret = genphy_c45_write_eee_adv(phydev, phydev->supported_eee); + if (ret < 0) + return ret; + else if (ret) + changed = true; if (genphy_c45_baset1_able(phydev)) return genphy_c45_baset1_an_config_aneg(phydev); @@ -950,6 +954,11 @@ int genphy_c45_pma_read_abilities(struct phy_device *phydev) } } + /* This is optional functionality. If not supported, we may get an error + * which should be ignored. + */ + genphy_c45_read_eee_abilities(phydev); + return 0; } EXPORT_SYMBOL_GPL(genphy_c45_pma_read_abilities);