From patchwork Wed Feb 1 14:58:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 51392 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp327255wrn; Wed, 1 Feb 2023 07:03:54 -0800 (PST) X-Google-Smtp-Source: AK7set8YDOuLj5u8uMZS1HgWk6SYkZ/Gve+V0ATIKjKiTVL0LfQUb4zKp9nD6PSOA7F8e5byh/cr X-Received: by 2002:a17:903:1246:b0:196:19af:a7f3 with SMTP id u6-20020a170903124600b0019619afa7f3mr3899750plh.39.1675263833991; Wed, 01 Feb 2023 07:03:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675263833; cv=none; d=google.com; s=arc-20160816; b=zpnEWpvGniy+o3cKj8TyZzLro3MTgX2Sa+tUYsV00CKXjBRJ9SVDhTUOeAie10OhOV Ic/JpNxYJtmRQjZG1owU2KmpBqkUW5ndtlLKxcURSapxf6i2UIxObE4RMpg8iGnbeXEn oAYMRnStZwzk88S+pgDhjqxIxFX/iFpD5DqKCcpgv8WReeQ2M/Jd99cia//mcP/BgfBA UnxMH1ru8GK20YaJeakMubJAR4+qfWdLlqLzz4YDBOsK4V4pUaT+956YGCv6xrZFiSKH pnbAAccQx10hnlBvm0es1X2u9YCrQ8d2QQ+V6vgQZ2jAdA3PQnfXLp99eNaQQ7YmEfDR 5s/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=nB5tjboHQI7de6gymIcCzARf4OaaG4tXe9B3qWoNXCE=; b=GAxOIiz5D8YOwKdCKZn/APVp8u660PPJGfbYOhBJ4iGvV48+RiG56f52UF3EQaqdw1 fmmZwlEIUMbTv3LHSXx7T64mS17RheAPO1WO8y8t/ta/SIxtM5LhDTFH9sx1wIjQFpRS dC5GKrNVtjbDJNvUOShz/fVssOu+6cp7twAfYq4zpzf70Qya+dcZUMO9fJ29GgBzPfjp 2EvY9LP8Bd6ae7m+4uu4IRHkkOdi97PLiKHG5vNIm8CdscKvfQ2mUETeVBAHADTv4YoV 7yKuqTL9P2jW38VckwXlUt1cxVtIQ9/XGcAbAWBKGhsSdxMMDnGEa+Rr12TVIIgNJWjG 1cXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j5-20020a170903024500b00194c7603bb9si22376341plh.104.2023.02.01.07.03.41; Wed, 01 Feb 2023 07:03:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232916AbjBAPAm (ORCPT + 99 others); Wed, 1 Feb 2023 10:00:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232806AbjBAO7i (ORCPT ); Wed, 1 Feb 2023 09:59:38 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 289936ACAA for ; Wed, 1 Feb 2023 06:59:08 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pNEZY-0002rZ-0E; Wed, 01 Feb 2023 15:58:52 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pNEZW-001w1E-Hn; Wed, 01 Feb 2023 15:58:49 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pNEZT-009hVQ-Bo; Wed, 01 Feb 2023 15:58:47 +0100 From: Oleksij Rempel To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Wei Fang , Heiner Kallweit Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Arun.Ramadoss@microchip.com, intel-wired-lan@lists.osuosl.org Subject: [PATCH net-next v4 06/23] net: phy: c22: migrate to genphy_c45_write_eee_adv() Date: Wed, 1 Feb 2023 15:58:28 +0100 Message-Id: <20230201145845.2312060-7-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230201145845.2312060-1-o.rempel@pengutronix.de> References: <20230201145845.2312060-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756641449947153169?= X-GMAIL-MSGID: =?utf-8?q?1756641449947153169?= Migrate from genphy_config_eee_advert() to genphy_c45_write_eee_adv(). It should work as before except write operation to the EEE adv registers will be done only if some EEE abilities was detected. If some driver will have a regression, related driver should provide own .get_features callback. See micrel.c:ksz9477_get_features() as example. Signed-off-by: Oleksij Rempel --- drivers/net/phy/phy_device.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 3651f1fd8fc9..0c47fa765b69 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -2231,7 +2231,10 @@ int __genphy_config_aneg(struct phy_device *phydev, bool changed) { int err; - if (genphy_config_eee_advert(phydev)) + err = genphy_c45_write_eee_adv(phydev, phydev->supported_eee); + if (err < 0) + return err; + else if (err) changed = true; err = genphy_setup_master_slave(phydev); @@ -2653,6 +2656,11 @@ int genphy_read_abilities(struct phy_device *phydev) phydev->supported, val & ESTATUS_1000_XFULL); } + /* This is optional functionality. If not supported, we may get an error + * which should be ignored. + */ + genphy_c45_read_eee_abilities(phydev); + return 0; } EXPORT_SYMBOL(genphy_read_abilities);