From patchwork Wed Feb 1 13:29:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emanuele Giuseppe Esposito X-Patchwork-Id: 51328 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp279170wrn; Wed, 1 Feb 2023 05:32:30 -0800 (PST) X-Google-Smtp-Source: AK7set/i2oTtgI+fRgSLLDCJNAeL7B5vfsokDDCnJ2LJdoomVmJq5kii2qWPVjwJGigsvFvJtNXI X-Received: by 2002:a17:90b:4c47:b0:22b:b1cd:cce with SMTP id np7-20020a17090b4c4700b0022bb1cd0ccemr2261816pjb.33.1675258350336; Wed, 01 Feb 2023 05:32:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675258350; cv=none; d=google.com; s=arc-20160816; b=rBu0rmCP6K2Fulfm1mDtj1YAMd9tRu2kq3XgIitKa3eaOErlF0IGbIgavNelvsRov1 TsFcDvM+rJAm91qxExYSASTw+hIw9zrfqc+IjXoWwqvkKBnSmcicB0/IrMQ/6F5287cp UAHv5gCat03aRNl+91TuA13soFQfsD355lRfboCd0Rmzc/jlVR8KsBUljAHbleatKR2d q2AV9hH5d9WSKEIeqm0WAp1p8j15bs42MoeTfHBGHg0ZX7LjFF5FLDItH7i8yLKDCMob x1d5YxBMQ9hqRC3nx1Wc6ytfBWHiUEL58frgl8NvVgVZww3zDk7c/eRYBxfux/Hl0Vpf 00Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=BHlHNKgyQKHJdr2+kCJrUmuRwsOYKakAfKoGgM7YMEs=; b=MOgDp9tjCdtkUkTe9eGbAHi9xaUoHv0uWLNRoBdiQbIst99Key61awJBMNrInrYsRw 12KbZemW1P0bH0Fi+kq8Oq0iustO02RZ6WMegyldZtNWTmPE4KinXtmzFGvp9CwuDpkZ WSKFjRA5h8Ff55upb7MWWCwCpJBEc4FEUgjYkdewK0Vw0jefjL4ty6T8GAeKZUUMh6YD ZA4CbgeeTFvJC/dOtoPTVXByctwlabBWEOJrX1Y1qkpS9cglYD3plVHwdbigi8XMst1n Hm78k7VmmrANcPMWt1/JopGC8sTrLxANq0VJZCIqto5prKXI5bLzBal4rLQCoE1I+hFZ IRlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CDnZ3gwU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o7-20020a637307000000b004774a024588si18957041pgc.719.2023.02.01.05.32.18; Wed, 01 Feb 2023 05:32:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CDnZ3gwU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232228AbjBANaB (ORCPT + 99 others); Wed, 1 Feb 2023 08:30:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232259AbjBAN3x (ORCPT ); Wed, 1 Feb 2023 08:29:53 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0C94410B4 for ; Wed, 1 Feb 2023 05:29:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675258153; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BHlHNKgyQKHJdr2+kCJrUmuRwsOYKakAfKoGgM7YMEs=; b=CDnZ3gwU9SdNNqGxrQiOa5TFrXIEy0FIZ/Zy+/CF+4ILMjG0uwe+TnY8cfltrBI2hfo9WR Owu3GEun/LMXDwYY+LiWkckEia33SHw4qTdz+ELh0wNADLdJnSYOnOoXzHxkNxmvp/I1ND KrXSHAF/9amvw3eNVELSF5WAFt88dVU= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-347-9U5y46XbM4GnkLcPdeGhew-1; Wed, 01 Feb 2023 08:29:12 -0500 X-MC-Unique: 9U5y46XbM4GnkLcPdeGhew-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1A7A63C02548; Wed, 1 Feb 2023 13:29:10 +0000 (UTC) Received: from virtlab701.virt.lab.eng.bos.redhat.com (virtlab701.virt.lab.eng.bos.redhat.com [10.19.152.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id B244C40C2064; Wed, 1 Feb 2023 13:29:09 +0000 (UTC) From: Emanuele Giuseppe Esposito To: kvm@vger.kernel.org Cc: Jim Mattson , Ben Serebrin , Peter Shier , Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Maxim Levitsky , x86@kernel.org, "H. Peter Anvin" , linux-kernel@vger.kernel.org, Emanuele Giuseppe Esposito Subject: [PATCH 3/3] kvm: x86: Advertise FLUSH_L1D to user space Date: Wed, 1 Feb 2023 08:29:05 -0500 Message-Id: <20230201132905.549148-4-eesposit@redhat.com> In-Reply-To: <20230201132905.549148-1-eesposit@redhat.com> References: <20230201132905.549148-1-eesposit@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756635699966710865?= X-GMAIL-MSGID: =?utf-8?q?1756635699966710865?= FLUSH_L1D was already added in 11e34e64e4103, but the feature is not visible to userspace yet. The bit definition: CPUID.(EAX=7,ECX=0):EDX[bit 28] If the feature is supported by the host, kvm should support it too so that userspace can choose whether to expose it to the guest or not. One disadvantage of not exposing it is that the guest will report a non existing vulnerability in /sys/devices/system/cpu/vulnerabilities/mmio_stale_data because the mitigation is present only if the guest supports (FLUSH_L1D and MD_CLEAR) or FB_CLEAR. Signed-off-by: Emanuele Giuseppe Esposito --- arch/x86/kvm/cpuid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index 2a9f1e200dbc..9c70cbb663a2 100644 --- a/arch/x86/kvm/cpuid.c +++ b/arch/x86/kvm/cpuid.c @@ -649,7 +649,7 @@ void kvm_set_cpu_caps(void) F(SPEC_CTRL_SSBD) | F(ARCH_CAPABILITIES) | F(INTEL_STIBP) | F(MD_CLEAR) | F(AVX512_VP2INTERSECT) | F(FSRM) | F(SERIALIZE) | F(TSXLDTRK) | F(AVX512_FP16) | - F(AMX_TILE) | F(AMX_INT8) | F(AMX_BF16) + F(AMX_TILE) | F(AMX_INT8) | F(AMX_BF16) | F(FLUSH_L1D) ); /* TSC_ADJUST and ARCH_CAPABILITIES are emulated in software. */