Message ID | 20230201125642.624255-1-gregkh@linuxfoundation.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp271976wrn; Wed, 1 Feb 2023 05:17:02 -0800 (PST) X-Google-Smtp-Source: AK7set+2iAYpDmhl0gwOk9jQWEFzyYabt8bYPAekFthC4vy6VI41fiqa6DLg0fycLlGauu8aWExu X-Received: by 2002:a17:90b:3911:b0:230:2045:3ba6 with SMTP id ob17-20020a17090b391100b0023020453ba6mr2292841pjb.2.1675257422335; Wed, 01 Feb 2023 05:17:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675257422; cv=none; d=google.com; s=arc-20160816; b=xktZE54D9QyeoZH11sjhdn3FQvTEyS7ZLrx4aJKoCI0olKwyP7qwe7UamyWRWB16o3 pCmg3X/dTopRApA3V/pMQl1GSBrMv+P5jffzLcx7xST6NjsLQCEVT4krCaOipn+KRlo5 ddvlDJmXXptPRgdHWzmu1QSt8BHOI1wNzTMX0OyOBozBBSxGJ4anVuAyh6P6VptVkv2O ZnM5ipruLbEDqefKiV3yNYMQkyPHnKDPQaICja0HImoCZX1pwTLQiAoahIs2ZGSGqzK0 yJ8cmg8xGYjJrFNKfa4qn71JWT/aC4j175ISiwH1jYSeUG8O98JFfWaY2ZpjvvbBU1Oz JVKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Nj/wgHl2b+fYuYnNncM7XkIOayZ0R+fzs/Jxc8gzXeA=; b=y6lrwDgNBnBI22gfX7+9DwLnOnm0a09wsPLCW5dbwEBYZ3vWecg/P6i5IT8lk/JLt1 sVgd6rpTvSSyHEykLNBfq7JvJX62uHqhnQ5DhoONmHk0mYG0ndLFjuaEUyJMv1WY6rDB PpDhEFS/RZt0T/B/S5KDr4576eLr/9JQXvAplRUxpcj9v3iW8Q8flRtqC8fWHqZrhOAV WIu1erLNQmjH8BmX5Ii2MIcseCxtgFxhG9P9wBzCaPAs5NBr6IJqvYnNjtqZZKWrxxtN Nxau1G1GfDymWEpVP4OAjKUfcUDee/34BUN9oxEZIUvF2ZFZ+sV8O77S+/vmyW1Wc3B9 sPeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=uCeFZDpA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e8-20020a17090a9a8800b0022387a1f9a5si1662541pjp.134.2023.02.01.05.16.50; Wed, 01 Feb 2023 05:17:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=uCeFZDpA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231564AbjBAM4x (ORCPT <rfc822;duw91626@gmail.com> + 99 others); Wed, 1 Feb 2023 07:56:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbjBAM4v (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 1 Feb 2023 07:56:51 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F37844C33; Wed, 1 Feb 2023 04:56:49 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AD2B8B82164; Wed, 1 Feb 2023 12:56:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB208C433D2; Wed, 1 Feb 2023 12:56:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675256207; bh=cM5MtNWV+d8D8YxWSV+fcLmFAHndu+7kCKP50Gsy+Ss=; h=From:To:Cc:Subject:Date:From; b=uCeFZDpARJQWvcjjupzg/14o9OvKZi6lO7FQOa/K9+V8nBiCcwhp0s9H/SoiKad8F IPV0TNrP6u9MytuFndp0C22da+OuubwgClRYpDPAQKfgv/HaOf4Do1ZyzlgKEepsWC IwFkjnnPaDtZi/ROHrcQM6jmimdTl8MX4ov2TPxs= From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-kernel@vger.kernel.org Cc: linux-sh@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, Hans de Goede <hdegoede@redhat.com>, "Rafael J. Wysocki" <rafael@kernel.org>, Linux Kernel Functional Testing <lkft@linaro.org>, Naresh Kamboju <naresh.kamboju@linaro.org> Subject: [PATCH] maple: remove unneeded maple_bus_uevent() callback. Date: Wed, 1 Feb 2023 13:56:42 +0100 Message-Id: <20230201125642.624255-1-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1619; i=gregkh@linuxfoundation.org; h=from:subject; bh=cM5MtNWV+d8D8YxWSV+fcLmFAHndu+7kCKP50Gsy+Ss=; b=owGbwMvMwCRo6H6F97bub03G02pJDMm3EjsEH1sfFFzeVc/LcDOwRG+J7butvl8rzTyWP130Y+qO bf4hHbEsDIJMDLJiiixftvEc3V9xSNHL0PY0zBxWJpAhDFycAjCRnPMMc2W0dWPrr5df1inbtumDj8 H2J69bmxkWNF651Z5l7F/14jXz2fuHTiQsMbi+HwA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756634726659319854?= X-GMAIL-MSGID: =?utf-8?q?1756634726659319854?= |
Series |
maple: remove unneeded maple_bus_uevent() callback.
|
|
Commit Message
Greg KH
Feb. 1, 2023, 12:56 p.m. UTC
The driver core recently changed the uevent bus callback to take a const
pointer, and the maple_bus_uevent() was not correctly fixed up. Instead
of fixing the function parameter types, just remove the callback
entirely as it does not do anything, so it is not necessary.
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Rich Felker <dalias@libc.org>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Fixes: 2a81ada32f0e ("driver core: make struct bus_type.uevent() take a const *")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
sh maintainers, I'll take this through my tree as that's where the
offending commit is that causes the build breakage.
drivers/sh/maple/maple.c | 7 -------
1 file changed, 7 deletions(-)
Comments
On Wed, 1 Feb 2023 at 13:56, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > The driver core recently changed the uevent bus callback to take a const > pointer, and the maple_bus_uevent() was not correctly fixed up. Instead > of fixing the function parameter types, just remove the callback > entirely as it does not do anything, so it is not necessary. > > Cc: Yoshinori Sato <ysato@users.sourceforge.jp> > Cc: Rich Felker <dalias@libc.org> > Cc: Hans de Goede <hdegoede@redhat.com> > Cc: "Rafael J. Wysocki" <rafael@kernel.org> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org> > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> > Fixes: 2a81ada32f0e ("driver core: make struct bus_type.uevent() take a const *") > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Thank you for the quick fix. Tested-by: Anders Roxell <anders.roxell@linaro.org> Cheers, Anders > --- > sh maintainers, I'll take this through my tree as that's where the > offending commit is that causes the build breakage. > > drivers/sh/maple/maple.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/sh/maple/maple.c b/drivers/sh/maple/maple.c > index e24e220e56ee..e05473c5c267 100644 > --- a/drivers/sh/maple/maple.c > +++ b/drivers/sh/maple/maple.c > @@ -760,12 +760,6 @@ static int maple_match_bus_driver(struct device *devptr, > return 0; > } > > -static int maple_bus_uevent(struct device *dev, > - struct kobj_uevent_env *env) > -{ > - return 0; > -} > - > static void maple_bus_release(struct device *dev) > { > } > @@ -782,7 +776,6 @@ static struct maple_driver maple_unsupported_device = { > struct bus_type maple_bus_type = { > .name = "maple", > .match = maple_match_bus_driver, > - .uevent = maple_bus_uevent, > }; > EXPORT_SYMBOL_GPL(maple_bus_type); > > -- > 2.39.1 >
Hi Greg! On Wed, 2023-02-01 at 13:56 +0100, Greg Kroah-Hartman wrote: > The driver core recently changed the uevent bus callback to take a const > pointer, and the maple_bus_uevent() was not correctly fixed up. Instead > of fixing the function parameter types, just remove the callback > entirely as it does not do anything, so it is not necessary. > > Cc: Yoshinori Sato <ysato@users.sourceforge.jp> > Cc: Rich Felker <dalias@libc.org> > Cc: Hans de Goede <hdegoede@redhat.com> > Cc: "Rafael J. Wysocki" <rafael@kernel.org> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org> > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> > Fixes: 2a81ada32f0e ("driver core: make struct bus_type.uevent() take a const *") > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > sh maintainers, I'll take this through my tree as that's where the > offending commit is that causes the build breakage. > > drivers/sh/maple/maple.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/sh/maple/maple.c b/drivers/sh/maple/maple.c > index e24e220e56ee..e05473c5c267 100644 > --- a/drivers/sh/maple/maple.c > +++ b/drivers/sh/maple/maple.c > @@ -760,12 +760,6 @@ static int maple_match_bus_driver(struct device *devptr, > return 0; > } > > -static int maple_bus_uevent(struct device *dev, > - struct kobj_uevent_env *env) > -{ > - return 0; > -} > - > static void maple_bus_release(struct device *dev) > { > } > @@ -782,7 +776,6 @@ static struct maple_driver maple_unsupported_device = { > struct bus_type maple_bus_type = { > .name = "maple", > .match = maple_match_bus_driver, > - .uevent = maple_bus_uevent, > }; > EXPORT_SYMBOL_GPL(maple_bus_type); Through which tree is this supposed to be picked up? FWIW, we have set up a new SH tree now, but I am not designated as an official SH maintainer yet which is what I would like to become in order to support Rich Felker. Adrian
On Wed, Feb 01, 2023 at 08:05:21PM +0100, John Paul Adrian Glaubitz wrote: > Hi Greg! > > On Wed, 2023-02-01 at 13:56 +0100, Greg Kroah-Hartman wrote: > > The driver core recently changed the uevent bus callback to take a const > > pointer, and the maple_bus_uevent() was not correctly fixed up. Instead > > of fixing the function parameter types, just remove the callback > > entirely as it does not do anything, so it is not necessary. > > > > Cc: Yoshinori Sato <ysato@users.sourceforge.jp> > > Cc: Rich Felker <dalias@libc.org> > > Cc: Hans de Goede <hdegoede@redhat.com> > > Cc: "Rafael J. Wysocki" <rafael@kernel.org> > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org> > > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> > > Fixes: 2a81ada32f0e ("driver core: make struct bus_type.uevent() take a const *") > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > --- > > sh maintainers, I'll take this through my tree as that's where the > > offending commit is that causes the build breakage. > > > > drivers/sh/maple/maple.c | 7 ------- > > 1 file changed, 7 deletions(-) > > > > diff --git a/drivers/sh/maple/maple.c b/drivers/sh/maple/maple.c > > index e24e220e56ee..e05473c5c267 100644 > > --- a/drivers/sh/maple/maple.c > > +++ b/drivers/sh/maple/maple.c > > @@ -760,12 +760,6 @@ static int maple_match_bus_driver(struct device *devptr, > > return 0; > > } > > > > -static int maple_bus_uevent(struct device *dev, > > - struct kobj_uevent_env *env) > > -{ > > - return 0; > > -} > > - > > static void maple_bus_release(struct device *dev) > > { > > } > > @@ -782,7 +776,6 @@ static struct maple_driver maple_unsupported_device = { > > struct bus_type maple_bus_type = { > > .name = "maple", > > .match = maple_match_bus_driver, > > - .uevent = maple_bus_uevent, > > }; > > EXPORT_SYMBOL_GPL(maple_bus_type); > > Through which tree is this supposed to be picked up? As the comment below the --- line said above: sh maintainers, I'll take this through my tree as that's where the offending commit is that causes the build breakage. So I took it :) thanks, greg k-h
diff --git a/drivers/sh/maple/maple.c b/drivers/sh/maple/maple.c index e24e220e56ee..e05473c5c267 100644 --- a/drivers/sh/maple/maple.c +++ b/drivers/sh/maple/maple.c @@ -760,12 +760,6 @@ static int maple_match_bus_driver(struct device *devptr, return 0; } -static int maple_bus_uevent(struct device *dev, - struct kobj_uevent_env *env) -{ - return 0; -} - static void maple_bus_release(struct device *dev) { } @@ -782,7 +776,6 @@ static struct maple_driver maple_unsupported_device = { struct bus_type maple_bus_type = { .name = "maple", .match = maple_match_bus_driver, - .uevent = maple_bus_uevent, }; EXPORT_SYMBOL_GPL(maple_bus_type);