Message ID | 20230131141756.RFT.v2.1.I723a3761d57ea60c5dd754c144aed6c3b2ea6f5a@changeid |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp69409wrn; Tue, 31 Jan 2023 14:34:46 -0800 (PST) X-Google-Smtp-Source: AK7set+lvVsQ6mtRR1IAf2BLN/OoCE/h7LhgX+1HnsvSE5s9MtyMzJ6YL75pxxtiWju0sLgb+s7J X-Received: by 2002:a17:906:a1c5:b0:88b:bf70:2e79 with SMTP id bx5-20020a170906a1c500b0088bbf702e79mr26002ejb.30.1675204485854; Tue, 31 Jan 2023 14:34:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675204485; cv=none; d=google.com; s=arc-20160816; b=DbTL4Y3fr47Ru6FUY0S8Op4qKsHxz/lymEumgwrXq9pNaSpSF03nU0Vo/oDqYrARcC asgtZYaBGEwpkeUjdKgQfJbH78YJM80mM5YLwMJDbqaxmyLairIeV76NOdjHveT274kS 4UCdCU5CfCX2wWSdOoV0ExrgSfZuFcFobAMN1c6Tt8k0WBhKRvnh17S6JqkFyfyc/B5z ywTjVse0PZQZJ77HWU+ZJSMdJIVySxsAShkCeu0cDlLBqgREJS0KYiAJ0j2cSjtcPkUx dkC3gvYVWhXRJ6T/ZdgisexxD1ho6EnY34H0rFVV5nvVepnxrGx6fGi4gWCvC8apLJrE m+ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=nDJfgGY2Uq4pkbdaiIQ1ONvu1Aumpm8UVU5btqep3hU=; b=hTyqZKE/cILFefO18CisrGUQkwS6Mes56t0t9pqxxJYuyQAfOev7NjQ3iMRO26Yi3n Z7fzcJTFMheG8LaTUkaVvvoshT7DMpczhw3UTAiPSM7oCjP+s/TYOxiosfbEWLsqMNGX 0nCUAHfnRC5kDhHrJyM5bhbqs7yeGZqLBjgqOXJZ+TyyjUpBNquLybYZQ1kmhpsJGIRW YenTPXabAjYhwgO8212RRs1gniX+JFylGO5NVv4GgxYTm2MlVUg6YP67CqAY4ZbX2obG BqnzAwImVxbxU26ZkjZu8y+XIUINshFY+q9x9AKq0qVkNEP1eia8eD7ew1a7NtM6oFnd xnQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="C//XxpbC"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bf10-20020a170906c50a00b0088bf3542ea4si4101569ejb.992.2023.01.31.14.34.22; Tue, 31 Jan 2023 14:34:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="C//XxpbC"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229889AbjAaWW6 (ORCPT <rfc822;maxin.john@gmail.com> + 99 others); Tue, 31 Jan 2023 17:22:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229875AbjAaWWz (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 31 Jan 2023 17:22:55 -0500 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B6DF5AB6A for <linux-kernel@vger.kernel.org>; Tue, 31 Jan 2023 14:22:21 -0800 (PST) Received: by mail-pl1-x62a.google.com with SMTP id be8so16568250plb.7 for <linux-kernel@vger.kernel.org>; Tue, 31 Jan 2023 14:22:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nDJfgGY2Uq4pkbdaiIQ1ONvu1Aumpm8UVU5btqep3hU=; b=C//XxpbCdZukvZqKglW8c6wuEVing1SDTbUUogS/ymch/qoW0vbXqPjsij+7C39bKM cz2v/jqa/PU4i47Iz53rPk2Vw3mNsCvZevPClswFn03twuQH9OPEeoCTzI0WxPUHRVN+ yilQTQAnqMoG4QmPIPzwSaV9MSqokzOW+hEIU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nDJfgGY2Uq4pkbdaiIQ1ONvu1Aumpm8UVU5btqep3hU=; b=YqHSGgKpIGYB1a1CqL0lqUNXu8Re/co6T0CkTHKPUthIqvualKlznCOsac1z6FHPPd Qx5GK4ZGohWDKoeSGuFwmWpXBJG1bxbaYkQVccDbWKr2hUpSoepS9CC0XrTYQEW5KN13 sTPomlXNcvm2fOKcEKaHSmshAlWv+rpula/WDYeUegUaqBuya50SE66lyueqOo0Dvokw udR+koaUN/WJqSnCONz5B7sTnbcJXIR455X0SOA9LuN3SaJ+HTonmOlZpOQl/FxlpWCw 50i2PW7uEKYeSOQW+bjtULgVobYcFjXXpAWOclJhNMrB/sAfda1Wk+T2lPEauClJtvap Oqxw== X-Gm-Message-State: AO0yUKXoDMGDKJ5n4lbnKEwno7Tsu3efHw7ptjthK0Xr7iciBhbJkp+a QSr01wMP2ZcW3WJjN4qTCbpl9A== X-Received: by 2002:a17:903:138c:b0:192:d625:ecc4 with SMTP id jx12-20020a170903138c00b00192d625ecc4mr495493plb.18.1675203738010; Tue, 31 Jan 2023 14:22:18 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:138e:73d3:502:64f]) by smtp.gmail.com with ESMTPSA id d18-20020a170903231200b0019339f3368asm10377471plh.3.2023.01.31.14.22.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Jan 2023 14:22:17 -0800 (PST) From: Douglas Anderson <dianders@chromium.org> To: dri-devel@lists.freedesktop.org, Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: Andrzej Hajda <andrzej.hajda@intel.com>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Sean Paul <sean@poorly.run>, Jonas Karlman <jonas@kwiboo.se>, Vinod Koul <vkoul@kernel.org>, Robert Foss <robert.foss@linaro.org>, linux-arm-msm@vger.kernel.org, Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>, freedreno@lists.freedesktop.org, Stephen Boyd <swboyd@chromium.org>, Neil Armstrong <neil.armstrong@linaro.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Dave Stevenson <dave.stevenson@raspberrypi.com>, Douglas Anderson <dianders@chromium.org>, linux-kernel@vger.kernel.org Subject: [RFT PATCH v2 1/3] drm/bridge: tc358762: Set pre_enable_prev_first Date: Tue, 31 Jan 2023 14:18:24 -0800 Message-Id: <20230131141756.RFT.v2.1.I723a3761d57ea60c5dd754c144aed6c3b2ea6f5a@changeid> X-Mailer: git-send-email 2.39.1.456.gfc5497dd1b-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756579219007858883?= X-GMAIL-MSGID: =?utf-8?q?1756579219007858883?= |
Series |
[RFT,v2,1/3] drm/bridge: tc358762: Set pre_enable_prev_first
|
|
Commit Message
Doug Anderson
Jan. 31, 2023, 10:18 p.m. UTC
Set the "pre_enable_prev_first" as provided by commit 4fb912e5e190
("drm/bridge: Introduce pre_enable_prev_first to alter bridge init
order"). This should allow us to revert commit ec7981e6c614
("drm/msm/dsi: don't powerup at modeset time for parade-ps8640") and
commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset
time").
Cc: Dave Stevenson <dave.stevenson@raspberrypi.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
(no changes since v1)
drivers/gpu/drm/bridge/tc358762.c | 1 +
1 file changed, 1 insertion(+)
Comments
On Tue, 31 Jan 2023 at 22:22, Douglas Anderson <dianders@chromium.org> wrote: > > Set the "pre_enable_prev_first" as provided by commit 4fb912e5e190 > ("drm/bridge: Introduce pre_enable_prev_first to alter bridge init > order"). This should allow us to revert commit ec7981e6c614 > ("drm/msm/dsi: don't powerup at modeset time for parade-ps8640") and > commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset > time"). I see no reference in the TC358762 datasheet to requiring the DSI interface to be in any particular state. However, setting this flag does mean that the DSI host doesn't need to power up and down for each host_transfer request from tc358762_pre_enable/tc358762_init, so on that basis I'm good with it. Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > Cc: Dave Stevenson <dave.stevenson@raspberrypi.com> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > (no changes since v1) > > drivers/gpu/drm/bridge/tc358762.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc358762.c > index 0b6a28436885..77f7f7f54757 100644 > --- a/drivers/gpu/drm/bridge/tc358762.c > +++ b/drivers/gpu/drm/bridge/tc358762.c > @@ -229,6 +229,7 @@ static int tc358762_probe(struct mipi_dsi_device *dsi) > ctx->bridge.funcs = &tc358762_bridge_funcs; > ctx->bridge.type = DRM_MODE_CONNECTOR_DPI; > ctx->bridge.of_node = dev->of_node; > + ctx->bridge.pre_enable_prev_first = true; > > drm_bridge_add(&ctx->bridge); > > -- > 2.39.1.456.gfc5497dd1b-goog >
Hi, On Wed, Feb 1, 2023 at 1:51 AM Dave Stevenson <dave.stevenson@raspberrypi.com> wrote: > > On Tue, 31 Jan 2023 at 22:22, Douglas Anderson <dianders@chromium.org> wrote: > > > > Set the "pre_enable_prev_first" as provided by commit 4fb912e5e190 > > ("drm/bridge: Introduce pre_enable_prev_first to alter bridge init > > order"). This should allow us to revert commit ec7981e6c614 > > ("drm/msm/dsi: don't powerup at modeset time for parade-ps8640") and > > commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset > > time"). > > I see no reference in the TC358762 datasheet to requiring the DSI > interface to be in any particular state. > However, setting this flag does mean that the DSI host doesn't need to > power up and down for each host_transfer request from > tc358762_pre_enable/tc358762_init, so on that basis I'm good with it. > > Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > > > Cc: Dave Stevenson <dave.stevenson@raspberrypi.com> > > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > --- > > > > (no changes since v1) > > > > drivers/gpu/drm/bridge/tc358762.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc358762.c > > index 0b6a28436885..77f7f7f54757 100644 > > --- a/drivers/gpu/drm/bridge/tc358762.c > > +++ b/drivers/gpu/drm/bridge/tc358762.c > > @@ -229,6 +229,7 @@ static int tc358762_probe(struct mipi_dsi_device *dsi) > > ctx->bridge.funcs = &tc358762_bridge_funcs; > > ctx->bridge.type = DRM_MODE_CONNECTOR_DPI; > > ctx->bridge.of_node = dev->of_node; > > + ctx->bridge.pre_enable_prev_first = true; > > > > drm_bridge_add(&ctx->bridge); Abhinav asked what the plan was for landing this [1]. Since this isn't urgent, I guess the plan is to land patch #1 in drm-misc-next. Then we sit and wait until it percolates into mainline and, once it does, then patch #2 and #3 can land. Since I have Dave's review I can commit this to drm-misc-next myself. My plan will be to wait until Thursday or Friday of this week (to give people a bit of time to object) and then land patch #1. Then I'll snooze things for a while and poke Abhinav and Dmitry to land patch #2 / #3 when I notice it in mainline. If, at any point, someone comes out of the woodwork and yells that this is breaking them then, worst case, we can revert. [1] https://lore.kernel.org/r/1f204585-88e2-abae-1216-92f739ac9e91@quicinc.com/
On 28/02/2023 02:26, Doug Anderson wrote: > Hi, > > On Wed, Feb 1, 2023 at 1:51 AM Dave Stevenson > <dave.stevenson@raspberrypi.com> wrote: >> >> On Tue, 31 Jan 2023 at 22:22, Douglas Anderson <dianders@chromium.org> wrote: >>> >>> Set the "pre_enable_prev_first" as provided by commit 4fb912e5e190 >>> ("drm/bridge: Introduce pre_enable_prev_first to alter bridge init >>> order"). This should allow us to revert commit ec7981e6c614 >>> ("drm/msm/dsi: don't powerup at modeset time for parade-ps8640") and >>> commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset >>> time"). >> >> I see no reference in the TC358762 datasheet to requiring the DSI >> interface to be in any particular state. >> However, setting this flag does mean that the DSI host doesn't need to >> power up and down for each host_transfer request from >> tc358762_pre_enable/tc358762_init, so on that basis I'm good with it. >> >> Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com> >> >>> Cc: Dave Stevenson <dave.stevenson@raspberrypi.com> >>> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> >>> Signed-off-by: Douglas Anderson <dianders@chromium.org> >>> --- >>> >>> (no changes since v1) >>> >>> drivers/gpu/drm/bridge/tc358762.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc358762.c >>> index 0b6a28436885..77f7f7f54757 100644 >>> --- a/drivers/gpu/drm/bridge/tc358762.c >>> +++ b/drivers/gpu/drm/bridge/tc358762.c >>> @@ -229,6 +229,7 @@ static int tc358762_probe(struct mipi_dsi_device *dsi) >>> ctx->bridge.funcs = &tc358762_bridge_funcs; >>> ctx->bridge.type = DRM_MODE_CONNECTOR_DPI; >>> ctx->bridge.of_node = dev->of_node; >>> + ctx->bridge.pre_enable_prev_first = true; >>> >>> drm_bridge_add(&ctx->bridge); > > Abhinav asked what the plan was for landing this [1]. Since this isn't > urgent, I guess the plan is to land patch #1 in drm-misc-next. Then we > sit and wait until it percolates into mainline and, once it does, then > patch #2 and #3 can land. > > Since I have Dave's review I can commit this to drm-misc-next myself. > My plan will be to wait until Thursday or Friday of this week (to give > people a bit of time to object) and then land patch #1. Then I'll > snooze things for a while and poke Abhinav and Dmitry to land patch #2 > / #3 when I notice it in mainline. If, at any point, someone comes out > of the woodwork and yells that this is breaking them then, worst case, > we can revert. This plan sounds good to me. > > [1] https://lore.kernel.org/r/1f204585-88e2-abae-1216-92f739ac9e91@quicinc.com/
On 01/02/2023 00:18, Douglas Anderson wrote: > Set the "pre_enable_prev_first" as provided by commit 4fb912e5e190 > ("drm/bridge: Introduce pre_enable_prev_first to alter bridge init > order"). This should allow us to revert commit ec7981e6c614 > ("drm/msm/dsi: don't powerup at modeset time for parade-ps8640") and > commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset > time"). > > Cc: Dave Stevenson <dave.stevenson@raspberrypi.com> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> > Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Hi, On Mon, Feb 27, 2023 at 5:24 PM Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > On 28/02/2023 02:26, Doug Anderson wrote: > > Hi, > > > > On Wed, Feb 1, 2023 at 1:51 AM Dave Stevenson > > <dave.stevenson@raspberrypi.com> wrote: > >> > >> On Tue, 31 Jan 2023 at 22:22, Douglas Anderson <dianders@chromium.org> wrote: > >>> > >>> Set the "pre_enable_prev_first" as provided by commit 4fb912e5e190 > >>> ("drm/bridge: Introduce pre_enable_prev_first to alter bridge init > >>> order"). This should allow us to revert commit ec7981e6c614 > >>> ("drm/msm/dsi: don't powerup at modeset time for parade-ps8640") and > >>> commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset > >>> time"). > >> > >> I see no reference in the TC358762 datasheet to requiring the DSI > >> interface to be in any particular state. > >> However, setting this flag does mean that the DSI host doesn't need to > >> power up and down for each host_transfer request from > >> tc358762_pre_enable/tc358762_init, so on that basis I'm good with it. > >> > >> Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > >> > >>> Cc: Dave Stevenson <dave.stevenson@raspberrypi.com> > >>> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > >>> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> > >>> Signed-off-by: Douglas Anderson <dianders@chromium.org> > >>> --- > >>> > >>> (no changes since v1) > >>> > >>> drivers/gpu/drm/bridge/tc358762.c | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc358762.c > >>> index 0b6a28436885..77f7f7f54757 100644 > >>> --- a/drivers/gpu/drm/bridge/tc358762.c > >>> +++ b/drivers/gpu/drm/bridge/tc358762.c > >>> @@ -229,6 +229,7 @@ static int tc358762_probe(struct mipi_dsi_device *dsi) > >>> ctx->bridge.funcs = &tc358762_bridge_funcs; > >>> ctx->bridge.type = DRM_MODE_CONNECTOR_DPI; > >>> ctx->bridge.of_node = dev->of_node; > >>> + ctx->bridge.pre_enable_prev_first = true; > >>> > >>> drm_bridge_add(&ctx->bridge); > > > > Abhinav asked what the plan was for landing this [1]. Since this isn't > > urgent, I guess the plan is to land patch #1 in drm-misc-next. Then we > > sit and wait until it percolates into mainline and, once it does, then > > patch #2 and #3 can land. > > > > Since I have Dave's review I can commit this to drm-misc-next myself. > > My plan will be to wait until Thursday or Friday of this week (to give > > people a bit of time to object) and then land patch #1. Then I'll > > snooze things for a while and poke Abhinav and Dmitry to land patch #2 > > / #3 when I notice it in mainline. If, at any point, someone comes out > > of the woodwork and yells that this is breaking them then, worst case, > > we can revert. > > This plan sounds good to me. Pushed to drm-misc-next: 55cac10739d5 drm/bridge: tc358762: Set pre_enable_prev_first If my math is right then I'd expect that to get into mainline for 6.4-rc1. I guess that means it'll be in Linus's tree mid-May. I'll schedule a reminder to suggest landing at patches #2 and #3 again in late May. -Doug
On Thu, 2 Mar 2023 at 19:26, Doug Anderson <dianders@chromium.org> wrote: > > Hi, > > On Mon, Feb 27, 2023 at 5:24 PM Dmitry Baryshkov > <dmitry.baryshkov@linaro.org> wrote: > > > > On 28/02/2023 02:26, Doug Anderson wrote: > > > Hi, > > > > > > On Wed, Feb 1, 2023 at 1:51 AM Dave Stevenson > > > <dave.stevenson@raspberrypi.com> wrote: > > >> > > >> On Tue, 31 Jan 2023 at 22:22, Douglas Anderson <dianders@chromium.org> wrote: > > >>> > > >>> Set the "pre_enable_prev_first" as provided by commit 4fb912e5e190 > > >>> ("drm/bridge: Introduce pre_enable_prev_first to alter bridge init > > >>> order"). This should allow us to revert commit ec7981e6c614 > > >>> ("drm/msm/dsi: don't powerup at modeset time for parade-ps8640") and > > >>> commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset > > >>> time"). > > >> > > >> I see no reference in the TC358762 datasheet to requiring the DSI > > >> interface to be in any particular state. > > >> However, setting this flag does mean that the DSI host doesn't need to > > >> power up and down for each host_transfer request from > > >> tc358762_pre_enable/tc358762_init, so on that basis I'm good with it. > > >> > > >> Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > > >> > > >>> Cc: Dave Stevenson <dave.stevenson@raspberrypi.com> > > >>> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > >>> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> > > >>> Signed-off-by: Douglas Anderson <dianders@chromium.org> > > >>> --- > > >>> > > >>> (no changes since v1) > > >>> > > >>> drivers/gpu/drm/bridge/tc358762.c | 1 + > > >>> 1 file changed, 1 insertion(+) > > >>> > > >>> diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc358762.c > > >>> index 0b6a28436885..77f7f7f54757 100644 > > >>> --- a/drivers/gpu/drm/bridge/tc358762.c > > >>> +++ b/drivers/gpu/drm/bridge/tc358762.c > > >>> @@ -229,6 +229,7 @@ static int tc358762_probe(struct mipi_dsi_device *dsi) > > >>> ctx->bridge.funcs = &tc358762_bridge_funcs; > > >>> ctx->bridge.type = DRM_MODE_CONNECTOR_DPI; > > >>> ctx->bridge.of_node = dev->of_node; > > >>> + ctx->bridge.pre_enable_prev_first = true; > > >>> > > >>> drm_bridge_add(&ctx->bridge); > > > > > > Abhinav asked what the plan was for landing this [1]. Since this isn't > > > urgent, I guess the plan is to land patch #1 in drm-misc-next. Then we > > > sit and wait until it percolates into mainline and, once it does, then > > > patch #2 and #3 can land. > > > > > > Since I have Dave's review I can commit this to drm-misc-next myself. > > > My plan will be to wait until Thursday or Friday of this week (to give > > > people a bit of time to object) and then land patch #1. Then I'll > > > snooze things for a while and poke Abhinav and Dmitry to land patch #2 > > > / #3 when I notice it in mainline. If, at any point, someone comes out > > > of the woodwork and yells that this is breaking them then, worst case, > > > we can revert. > > > > This plan sounds good to me. > > Pushed to drm-misc-next: > > 55cac10739d5 drm/bridge: tc358762: Set pre_enable_prev_first > > If my math is right then I'd expect that to get into mainline for > 6.4-rc1. I guess that means it'll be in Linus's tree mid-May. I'll > schedule a reminder to suggest landing at patches #2 and #3 again in > late May. It might be earlier, if msm-next merges drm-misc earlier (e.g. for the PSR patches).
diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc358762.c index 0b6a28436885..77f7f7f54757 100644 --- a/drivers/gpu/drm/bridge/tc358762.c +++ b/drivers/gpu/drm/bridge/tc358762.c @@ -229,6 +229,7 @@ static int tc358762_probe(struct mipi_dsi_device *dsi) ctx->bridge.funcs = &tc358762_bridge_funcs; ctx->bridge.type = DRM_MODE_CONNECTOR_DPI; ctx->bridge.of_node = dev->of_node; + ctx->bridge.pre_enable_prev_first = true; drm_bridge_add(&ctx->bridge);