From patchwork Tue Jan 31 14:03:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin LABBE X-Patchwork-Id: 50879 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2770389wrn; Tue, 31 Jan 2023 06:09:17 -0800 (PST) X-Google-Smtp-Source: AK7set9L8r/f6PYxXkSsRzmQ47YFs+m3TsnA8ygcGzecqaNV0BcHK43ezzOQErI6Vsn0y3e0471X X-Received: by 2002:a17:90b:1c0a:b0:22b:ec6a:be66 with SMTP id oc10-20020a17090b1c0a00b0022bec6abe66mr13632863pjb.31.1675174156827; Tue, 31 Jan 2023 06:09:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675174156; cv=none; d=google.com; s=arc-20160816; b=OHcQJT5cutAEOOzX3uNi73sgQ9WC/LRXLgSvehbnVcjYcHOZ0ySdqZ9rlIorKB/3Uq LIJOiaAx/xIOfSSRWfo9nGV7302FTj37/EvIjJs3bjn1G7IZNyzowLupfXQZ5kTe+wNd TKWx+gjUqSXVZxyfG6P4G9Euf3v8CC83Om9aTV66mIi4eA4VBdxYkMutJF/Lgv9QRit7 tp+0hm03wUSVH2acnf6JsVylGAZNG7+vyjKZ6SUdr0SsMu2/jxEsDTT6u+CMOkdoVARx 3gjVZR9xjfryq4troS7bGiCvSwy2cJEBn3HS4O16BmNBH9BNd6KK7Cx4UIO2D3Noi0dE o6sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=lc8ed0h0ZvjQ5UirrcCDNDRepKtbVnO5U4g4adO99nk=; b=HsRw3RIQjG5Jey9OHTWatWND2GsocnGYK0tkMB+B7Qzb0s5NJ3pllXBdO0f5PsQQCa C7beFsPlitsXU8CJ0Lsp07aeVMKzqXlG51bHCqe20eAPHQa9EdNMjxLgSsMcN4NToq9R Kw6kKc8lA3NPY+kJfxvxwHJC/omct65U5cKfB6dhWlWtiL5TnjKKq6lAXMByXKO+hz+N IG/xWdhQfypxcA/Q4JzwFjN9v6AatzTyje/DWIsRg13Qo8jFcFkOsEtefe81OD0UB2gh aR2FTKvUIegSmaQYp/zVsDCFrsU7RN4gsIgRR3Zw0vqPLnyGssr/1KvR6hE7z1mxn9jE LteQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=hWAOXV+e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u4-20020a17090a4bc400b0022c062be7a6si14823000pjl.138.2023.01.31.06.09.03; Tue, 31 Jan 2023 06:09:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=hWAOXV+e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231941AbjAaODW (ORCPT + 99 others); Tue, 31 Jan 2023 09:03:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231822AbjAaODP (ORCPT ); Tue, 31 Jan 2023 09:03:15 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C581FF28 for ; Tue, 31 Jan 2023 06:03:13 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id t18so14326605wro.1 for ; Tue, 31 Jan 2023 06:03:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lc8ed0h0ZvjQ5UirrcCDNDRepKtbVnO5U4g4adO99nk=; b=hWAOXV+eH0/DS4Hu76lBf7HOJPHyBrLevKwVWzylha4entBU1Yly4+uLlRKu05MBAz UYwDYw3EisDTl4Opu0YXG1f4BLhxYLOagWpcFbQsEe2E2QUDzXwIoQaQL5+BXAQtOtXb kzYzqe3xaU8zsFKoeZQ+N5HjRVMks5GK0X6YX1Qg/dMTwtlLUVnjC4QIrA5uBNL0qsMW BGsZLB9RGwdgnLQCOsFf8BAygt0Ojp28TqtZ3x0iRqB5JcLZtU37e4HOl2EV98DOYAZT S+LCcTEbUZyLrFOQ/NZePZZ63ucq8i5UN2YZzdlP3LizkIo7SO+HtqtgCBA9HdX/ySza ufOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lc8ed0h0ZvjQ5UirrcCDNDRepKtbVnO5U4g4adO99nk=; b=QCBN16dGmdng/P/ioUYnSvUm0kNj1vm3dVOxPVXPbL7vK6CEsJIt1vNWBrJ1HBka11 Yr8FT/aeinQOmJ20JwCo2EhAP9aQsIXGwtvUP2EBngRAArR8gXPqTljfoobcjvsSjey+ PDIP03i4DZOwGyh/2WXrj07BTAkPRR8ZXc2/ySaxl3iNMfv0WJd6S+btufrrYuAQ7TQP S3UPwZFGwvwleQ4QLZvY5Zw5eoVK9aP0Zgsj1bi6oEM8AnF4kSIS3ttxNJfpkysP07TR nip7e0XNJThonmX8Q8Jo4EyCZtVQH0NZp2zheZMYq23xixdDSkEdcJP6kkJ/LjV9VGAf 6IFA== X-Gm-Message-State: AFqh2kpCNdCyiTrFfn+eIcmBB4wlj45Dm3CfVZ98wYB4OcJg7zVuEPPp EgWjMRoATqXFjJGKdfuK7687vw== X-Received: by 2002:adf:f0c1:0:b0:2bc:67d:c018 with SMTP id x1-20020adff0c1000000b002bc067dc018mr46749979wro.48.1675173792075; Tue, 31 Jan 2023 06:03:12 -0800 (PST) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id z12-20020adff74c000000b00291f1a5ced6sm14950847wrp.53.2023.01.31.06.03.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Jan 2023 06:03:11 -0800 (PST) From: Corentin Labbe To: lee@kernel.org, linus.walleij@linaro.org, pavel@ucw.cz, robh+dt@kernel.org, jacek.anaszewski@gmail.com, krzysztof.kozlowski+dt@linaro.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, Corentin Labbe , Rob Herring Subject: [PATCH v5 2/2] leds: remove ide-disk trigger Date: Tue, 31 Jan 2023 14:03:04 +0000 Message-Id: <20230131140304.626779-2-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230131140304.626779-1-clabbe@baylibre.com> References: <20230131140304.626779-1-clabbe@baylibre.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756547416962669133?= X-GMAIL-MSGID: =?utf-8?q?1756547416962669133?= No user of ide-disk remains, so remove this deprecated trigger. Only a few platforms used this and were fixed in 2016. Acked-by: Rob Herring Signed-off-by: Corentin Labbe Reviewed-by: Linus Walleij --- Change since v1: - remove also DEFINE_LED_TRIGGER(ledtrig_ide) Changes since v2: - Added the fact that few platforms used this and it was fixed old ago. - Added Rob's ack Change since v3: - Rebase on top of latest next Change since v4: - Rebase on top of latest next Documentation/devicetree/bindings/leds/common.yaml | 3 --- drivers/leds/trigger/ledtrig-disk.c | 4 ---- 2 files changed, 7 deletions(-) diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml index 60c8611c6611..15e3f6645682 100644 --- a/Documentation/devicetree/bindings/leds/common.yaml +++ b/Documentation/devicetree/bindings/leds/common.yaml @@ -92,9 +92,6 @@ properties: - disk-activity - disk-read - disk-write - # LED indicates IDE disk activity (deprecated), in new implementations - # use "disk-activity" - - ide-disk # LED flashes at a fixed, configurable rate - timer # LED alters the brightness for the specified duration with one software diff --git a/drivers/leds/trigger/ledtrig-disk.c b/drivers/leds/trigger/ledtrig-disk.c index 0741910785bb..0b7dfbd04273 100644 --- a/drivers/leds/trigger/ledtrig-disk.c +++ b/drivers/leds/trigger/ledtrig-disk.c @@ -16,7 +16,6 @@ DEFINE_LED_TRIGGER(ledtrig_disk); DEFINE_LED_TRIGGER(ledtrig_disk_read); DEFINE_LED_TRIGGER(ledtrig_disk_write); -DEFINE_LED_TRIGGER(ledtrig_ide); void ledtrig_disk_activity(bool write) { @@ -24,8 +23,6 @@ void ledtrig_disk_activity(bool write) led_trigger_blink_oneshot(ledtrig_disk, &blink_delay, &blink_delay, 0); - led_trigger_blink_oneshot(ledtrig_ide, - &blink_delay, &blink_delay, 0); if (write) led_trigger_blink_oneshot(ledtrig_disk_write, &blink_delay, &blink_delay, 0); @@ -40,7 +37,6 @@ static int __init ledtrig_disk_init(void) led_trigger_register_simple("disk-activity", &ledtrig_disk); led_trigger_register_simple("disk-read", &ledtrig_disk_read); led_trigger_register_simple("disk-write", &ledtrig_disk_write); - led_trigger_register_simple("ide-disk", &ledtrig_ide); return 0; }