diff mbox series

arm64: dts: imx8mq: update usb compatible string

Message ID 20230131091140.3696808-1-peng.fan@oss.nxp.com
State New
Headers
Series arm64: dts: imx8mq: update usb compatible string |

Commit Message

Peng Fan (OSS) Jan. 31, 2023, 9:11 a.m. UTC 
  From: Peng Fan <peng.fan@nxp.com>

There is no fsl,imx8mq-dwc3 binding doc, no driver use this compatible
string. Drop it.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Marco Felsch Jan. 31, 2023, 9:24 a.m. UTC | #1 
Hi,

On 23-01-31, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> There is no fsl,imx8mq-dwc3 binding doc, no driver use this compatible
> string. Drop it.

please don't. I'm not aware of the driver state but the compatibles are
there for _possible_ quirk handling, so the driver can add a match on
demand.

Regards,
  Marco


> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index d59156fdee0b..d308f94a7c52 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -1431,7 +1431,7 @@ gpu: gpu@38000000 {
>  		};
>  
>  		usb_dwc3_0: usb@38100000 {
> -			compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
> +			compatible = "snps,dwc3";
>  			reg = <0x38100000 0x10000>;
>  			clocks = <&clk IMX8MQ_CLK_USB1_CTRL_ROOT>,
>  			         <&clk IMX8MQ_CLK_USB_CORE_REF>,
> @@ -1463,7 +1463,7 @@ usb3_phy0: usb-phy@381f0040 {
>  		};
>  
>  		usb_dwc3_1: usb@38200000 {
> -			compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
> +			compatible = "snps,dwc3";
>  			reg = <0x38200000 0x10000>;
>  			clocks = <&clk IMX8MQ_CLK_USB2_CTRL_ROOT>,
>  			         <&clk IMX8MQ_CLK_USB_CORE_REF>,
> -- 
> 2.37.1
> 
> 
>
Peng Fan Jan. 31, 2023, 9:34 a.m. UTC | #2 
> Subject: Re: [PATCH] arm64: dts: imx8mq: update usb compatible string
> 
> Hi,
> 
> On 23-01-31, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > There is no fsl,imx8mq-dwc3 binding doc, no driver use this compatible
> > string. Drop it.
> 
> please don't. I'm not aware of the driver state but the compatibles are there
> for _possible_ quirk handling, so the driver can add a match on demand.

NXP downstream also not has driver use this compatible string, and pass
several GA releases.

People could add it back when it is needed together with binding doc.

Thanks,
Peng.

> 
> Regards,
>   Marco
> 
> 
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > index d59156fdee0b..d308f94a7c52 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > @@ -1431,7 +1431,7 @@ gpu: gpu@38000000 {
> >  		};
> >
> >  		usb_dwc3_0: usb@38100000 {
> > -			compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
> > +			compatible = "snps,dwc3";
> >  			reg = <0x38100000 0x10000>;
> >  			clocks = <&clk IMX8MQ_CLK_USB1_CTRL_ROOT>,
> >  			         <&clk IMX8MQ_CLK_USB_CORE_REF>, @@ -
> 1463,7 +1463,7 @@
> > usb3_phy0: usb-phy@381f0040 {
> >  		};
> >
> >  		usb_dwc3_1: usb@38200000 {
> > -			compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
> > +			compatible = "snps,dwc3";
> >  			reg = <0x38200000 0x10000>;
> >  			clocks = <&clk IMX8MQ_CLK_USB2_CTRL_ROOT>,
> >  			         <&clk IMX8MQ_CLK_USB_CORE_REF>,
> > --
> > 2.37.1
> >
> >
> >
Marco Felsch Jan. 31, 2023, 9:54 a.m. UTC | #3 
On 23-01-31, Peng Fan wrote:
> > Subject: Re: [PATCH] arm64: dts: imx8mq: update usb compatible string
> > 
> > Hi,
> > 
> > On 23-01-31, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > There is no fsl,imx8mq-dwc3 binding doc, no driver use this compatible
> > > string. Drop it.
> > 
> > please don't. I'm not aware of the driver state but the compatibles are there
> > for _possible_ quirk handling, so the driver can add a match on demand.
> 
> NXP downstream also not has driver use this compatible string, and pass
> several GA releases.

This shouldn't be an argument, because there is no bug at the moment
doesn't mean that there is one. Also the compatible may used by other
projects using this device tree too.

> People could add it back when it is needed together with binding doc.

Nope since a DTB is firmware which is updated relativ rare. The kernel
instead is updated more often. So please instead of removing it add
support to the dt-bindings doc.

Regards,
  Marco


> Thanks,
> Peng.
> 
> > 
> > Regards,
> >   Marco
> > 
> > 
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > >  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > > b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > > index d59156fdee0b..d308f94a7c52 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > > @@ -1431,7 +1431,7 @@ gpu: gpu@38000000 {
> > >  		};
> > >
> > >  		usb_dwc3_0: usb@38100000 {
> > > -			compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
> > > +			compatible = "snps,dwc3";
> > >  			reg = <0x38100000 0x10000>;
> > >  			clocks = <&clk IMX8MQ_CLK_USB1_CTRL_ROOT>,
> > >  			         <&clk IMX8MQ_CLK_USB_CORE_REF>, @@ -
> > 1463,7 +1463,7 @@
> > > usb3_phy0: usb-phy@381f0040 {
> > >  		};
> > >
> > >  		usb_dwc3_1: usb@38200000 {
> > > -			compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
> > > +			compatible = "snps,dwc3";
> > >  			reg = <0x38200000 0x10000>;
> > >  			clocks = <&clk IMX8MQ_CLK_USB2_CTRL_ROOT>,
> > >  			         <&clk IMX8MQ_CLK_USB_CORE_REF>,
> > > --
> > > 2.37.1
> > >
> > >
> > >
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index d59156fdee0b..d308f94a7c52 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -1431,7 +1431,7 @@  gpu: gpu@38000000 {
 		};
 
 		usb_dwc3_0: usb@38100000 {
-			compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
+			compatible = "snps,dwc3";
 			reg = <0x38100000 0x10000>;
 			clocks = <&clk IMX8MQ_CLK_USB1_CTRL_ROOT>,
 			         <&clk IMX8MQ_CLK_USB_CORE_REF>,
@@ -1463,7 +1463,7 @@  usb3_phy0: usb-phy@381f0040 {
 		};
 
 		usb_dwc3_1: usb@38200000 {
-			compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
+			compatible = "snps,dwc3";
 			reg = <0x38200000 0x10000>;
 			clocks = <&clk IMX8MQ_CLK_USB2_CTRL_ROOT>,
 			         <&clk IMX8MQ_CLK_USB_CORE_REF>,