From patchwork Tue Jan 31 05:46:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shaopeng Tan X-Patchwork-Id: 50615 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2580371wrn; Mon, 30 Jan 2023 22:02:04 -0800 (PST) X-Google-Smtp-Source: AK7set+oiQWp/JHw8ZWV8mtB6YRr/dPnfBN2xXgjuKphkPTxS34lNO+Je2JMsXG6B175CCaC8SE7 X-Received: by 2002:a05:6a20:c189:b0:be:fa44:95b2 with SMTP id bg9-20020a056a20c18900b000befa4495b2mr34045pzb.8.1675144924344; Mon, 30 Jan 2023 22:02:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675144924; cv=none; d=google.com; s=arc-20160816; b=fvLVZwIvyiZWiGCjZTsMKDsTiZ0Q+PeVz41U8pCH1mQWDVgJtODN8cnmC0Ho6wr7mQ NtLe2/aCzkDrmE/FoWYAtkgTP4nXhsM/VPvf7JF/UPXWoKSj3FdoqQQiOcZ5BVySR4Rv slTbiaCDyVjo+BwbV+wLW3Spq4bGHBowRoGO6PtPCM2Y3tvyxdSWiBER8K5eQI+yky2k KzyaA8QS+ZNqcmrnaToFnKgCRHP4aNzKxY710VZ55d490K+ssu+RMRsgY+BYi+YvbgRx imj9wQ1KOPacSoSYwiwy9YwXum6QQcIW3KWb9obaq33QCMiZK9lxBu/JYSTh6TEL6tJi AP6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=8vB7wSoHkVQdDBEgWvv4iIcFC9Fe76TYmbSGIUh7/DA=; b=ge1pMSMndOWrqoLSrV01NROG+BGS/aHnc83CpW87dJthsZejAlI90mwm1qEiNXO8Rr 1HSW/PpjipMVBSZ3j4MYWqAeG9W5LRMpqGsH3mHjCbEqzPIWgTyI0n3ZPVcBY1t0x8NR 1iVX6E5T/ioNsZ3KJ+6pdQVWvLPGc+kRXJyLa6Cx6euaFfdn1892juywRv51a+qrai42 Za+gG8D6y5/d05eZmkk4A8Rbsc3Fo9tdTPX4MmqLMdYonp4WdcWd/SypL+1FX+FpuCbd ISmxiiTp4IrCo4xkDFxLjTWkWzcBET9xgdUlDr4YnhO7S84bbcLPFwXXjIaeeB5IkOrZ dhNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=fujitsu.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p16-20020a637f50000000b004e3f0dd60e9si9219166pgn.551.2023.01.30.22.01.47; Mon, 30 Jan 2023 22:02:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=fujitsu.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230267AbjAaFun (ORCPT + 99 others); Tue, 31 Jan 2023 00:50:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230303AbjAaFuj (ORCPT ); Tue, 31 Jan 2023 00:50:39 -0500 Received: from esa5.hc1455-7.c3s2.iphmx.com (esa5.hc1455-7.c3s2.iphmx.com [68.232.139.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 937463B3DD; Mon, 30 Jan 2023 21:50:37 -0800 (PST) X-IronPort-AV: E=McAfee;i="6500,9779,10606"; a="104437403" X-IronPort-AV: E=Sophos;i="5.97,259,1669042800"; d="scan'208";a="104437403" Received: from unknown (HELO yto-r4.gw.nic.fujitsu.com) ([218.44.52.220]) by esa5.hc1455-7.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2023 14:50:35 +0900 Received: from yto-m1.gw.nic.fujitsu.com (yto-nat-yto-m1.gw.nic.fujitsu.com [192.168.83.64]) by yto-r4.gw.nic.fujitsu.com (Postfix) with ESMTP id CA6CCD3EAC; Tue, 31 Jan 2023 14:50:32 +0900 (JST) Received: from yto-om3.fujitsu.com (yto-om3.o.css.fujitsu.com [10.128.89.164]) by yto-m1.gw.nic.fujitsu.com (Postfix) with ESMTP id 225B8CFAB4; Tue, 31 Jan 2023 14:50:32 +0900 (JST) Received: from cn-r05-10.example.com (n3235113.np.ts.nmh.cs.fujitsu.co.jp [10.123.235.113]) by yto-om3.fujitsu.com (Postfix) with ESMTP id EE8A940061250; Tue, 31 Jan 2023 14:50:31 +0900 (JST) From: Shaopeng Tan To: Fenghua Yu , Reinette Chatre , Shuah Khan Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, tan.shaopeng@jp.fujitsu.com, Shuah Khan Subject: [PATCH v6 2/5] selftests/resctrl: Return MBA check result and make it to output message Date: Tue, 31 Jan 2023 14:46:52 +0900 Message-Id: <20230131054655.396270-3-tan.shaopeng@jp.fujitsu.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20230131054655.396270-1-tan.shaopeng@jp.fujitsu.com> References: <20230131054655.396270-1-tan.shaopeng@jp.fujitsu.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756516764355274128?= X-GMAIL-MSGID: =?utf-8?q?1756516764355274128?= Since MBA check result is not returned, the MBA test result message is always output as "ok" regardless of whether the MBA check result is true or false. Make output message to be "not ok" if MBA check result is failed. Reviewed-by: Shuah Khan Reviewed-by: Reinette Chatre Signed-off-by: Shaopeng Tan --- tools/testing/selftests/resctrl/mba_test.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/resctrl/mba_test.c b/tools/testing/selftests/resctrl/mba_test.c index 1a1bdb6180cf..e3a473976d74 100644 --- a/tools/testing/selftests/resctrl/mba_test.c +++ b/tools/testing/selftests/resctrl/mba_test.c @@ -51,10 +51,10 @@ static int mba_setup(int num, ...) return 0; } -static void show_mba_info(unsigned long *bw_imc, unsigned long *bw_resc) +static bool show_mba_info(unsigned long *bw_imc, unsigned long *bw_resc) { int allocation, runs; - bool failed = false; + bool ret = false; ksft_print_msg("Results are displayed in (MB)\n"); /* Memory bandwidth from 100% down to 10% */ @@ -90,13 +90,15 @@ static void show_mba_info(unsigned long *bw_imc, unsigned long *bw_resc) ksft_print_msg("avg_bw_imc: %lu\n", avg_bw_imc); ksft_print_msg("avg_bw_resc: %lu\n", avg_bw_resc); if (avg_diff_per > MAX_DIFF_PERCENT) - failed = true; + ret = true; } ksft_print_msg("%s Check schemata change using MBA\n", - failed ? "Fail:" : "Pass:"); - if (failed) + ret ? "Fail:" : "Pass:"); + if (ret) ksft_print_msg("At least one test failed\n"); + + return ret; } static int check_results(void) @@ -132,9 +134,7 @@ static int check_results(void) fclose(fp); - show_mba_info(bw_imc, bw_resc); - - return 0; + return show_mba_info(bw_imc, bw_resc); } void mba_test_cleanup(void)