diff mbox series

dt-bindings: rename .yamllint to yamllint

Message ID 20230130162650.399490-1-masahiroy@kernel.org
State New
Headers
Series dt-bindings: rename .yamllint to yamllint |

Commit Message

Masahiro Yamada Jan. 30, 2023, 4:26 p.m. UTC 
  This file is ignored by git by the '.*' rule in the top .gitignore.

I do not see a good reason why this should be a hidden file.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

I think many people are aware of this issue
since this is now W=1 warning due to this patch:
 https://lore.kernel.org/all/20221229074310.906556-2-masahiroy@kernel.org/


 Documentation/devicetree/bindings/Makefile                | 4 ++--
 Documentation/devicetree/bindings/{.yamllint => yamllint} | 0
 2 files changed, 2 insertions(+), 2 deletions(-)
 rename Documentation/devicetree/bindings/{.yamllint => yamllint} (100%)

Comments

Rob Herring Jan. 30, 2023, 7:52 p.m. UTC | #1 
On Mon, Jan 30, 2023 at 10:26 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> This file is ignored by git by the '.*' rule in the top .gitignore.
>
> I do not see a good reason why this should be a hidden file.

Only because that is the default name yamllint will pick up if it is
run from the bindings directory. Not really something I do though.

Rob
Masahiro Yamada Jan. 31, 2023, 1:54 a.m. UTC | #2 
On Tue, Jan 31, 2023 at 4:53 AM Rob Herring <robh+dt@kernel.org> wrote:
>
> On Mon, Jan 30, 2023 at 10:26 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > This file is ignored by git by the '.*' rule in the top .gitignore.
> >
> > I do not see a good reason why this should be a hidden file.
>
> Only because that is the default name yamllint will pick up if it is
> run from the bindings directory. Not really something I do though.
>
> Rob


Or, do you prefer adding

!/.yamllint

to Documentation/devicetree/bindings/.gitignore  ?
Krzysztof Kozlowski Jan. 31, 2023, 7:09 p.m. UTC | #3 
On 31/01/2023 02:54, Masahiro Yamada wrote:
> On Tue, Jan 31, 2023 at 4:53 AM Rob Herring <robh+dt@kernel.org> wrote:
>>
>> On Mon, Jan 30, 2023 at 10:26 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>>>
>>> This file is ignored by git by the '.*' rule in the top .gitignore.
>>>
>>> I do not see a good reason why this should be a hidden file.
>>
>> Only because that is the default name yamllint will pick up if it is
>> run from the bindings directory. Not really something I do though.
>>
>> Rob
> 
> 
> Or, do you prefer adding
> 
> !/.yamllint
> 
> to Documentation/devicetree/bindings/.gitignore  ?

https://lore.kernel.org/all/20230127150225.18148-1-andriy.shevchenko@linux.intel.com/

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/Makefile b/Documentation/devicetree/bindings/Makefile
index bf2d8a8ced77..edc65522072b 100644
--- a/Documentation/devicetree/bindings/Makefile
+++ b/Documentation/devicetree/bindings/Makefile
@@ -34,7 +34,7 @@  CHK_DT_DOCS := $(shell $(find_cmd))
 quiet_cmd_yamllint = LINT    $(src)
       cmd_yamllint = ($(find_cmd) | \
                      xargs -n200 -P$$(nproc) \
-		     $(DT_SCHEMA_LINT) -f parsable -c $(srctree)/$(src)/.yamllint >&2) || true
+		     $(DT_SCHEMA_LINT) -f parsable -c $(srctree)/$(src)/yamllint >&2) || true
 
 quiet_cmd_chk_bindings = CHKDT   $@
       cmd_chk_bindings = ($(find_cmd) | \
@@ -64,7 +64,7 @@  override DTC_FLAGS := \
 # Disable undocumented compatible checks until warning free
 override DT_CHECKER_FLAGS ?=
 
-$(obj)/processed-schema.json: $(DT_DOCS) $(src)/.yamllint check_dtschema_version FORCE
+$(obj)/processed-schema.json: $(DT_DOCS) $(src)/yamllint check_dtschema_version FORCE
 	$(call if_changed_rule,chkdt)
 
 always-y += processed-schema.json
diff --git a/Documentation/devicetree/bindings/.yamllint b/Documentation/devicetree/bindings/yamllint
similarity index 100%
rename from Documentation/devicetree/bindings/.yamllint
rename to Documentation/devicetree/bindings/yamllint