From patchwork Mon Jan 30 08:07:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 50176 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2062027wrn; Mon, 30 Jan 2023 00:09:08 -0800 (PST) X-Google-Smtp-Source: AK7set/TDwN+/QGQ7vsZv+Xzrs5671eoE+yaz855TzFf2ESOE3/HtOdNttPYxqOklqFXJWz+3NVf X-Received: by 2002:aa7:df15:0:b0:4a2:2d5c:9b06 with SMTP id c21-20020aa7df15000000b004a22d5c9b06mr7773814edy.17.1675066147844; Mon, 30 Jan 2023 00:09:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675066147; cv=none; d=google.com; s=arc-20160816; b=Z5ZimNXpPA9/tpTrwj5qeIgmrVBueE59ZibBdLVc6ZJD2JW8nrvXFMNI35bYQvLFO6 KTmtKasmbji03VI3ioWuuE3gRLmuGCzxX5+LuQ1JCGJWGnne2vZr39OE1o7OCplBddcN VqCgi1dpptcIPkaNX1bbLjNHZubbwNILlbP/kWUbWRV3RFE3WHxUbCVgE0j5UfwJiFzA uaA/FNPVjPCTwvPwCZ7QpvlPGkPu4aLHqgf/9YiT+nfGqOs9a9pcPrP4KTxoPA8Mga9J RfkSFAV7JOBAiYwahMN6rOS25uHKpoDmB394Qlk5dCjgMEjvaH343GksbaS3UOBqwKuQ xbXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=TcmIW8h9zZkI5S/RrhdXziQQ7tjRl+mr6DxXcfgKaFk=; b=fn1ba6EiWbXmfJiLEE2oHLS87G0rpMQpjwbZQyYDQK1WTok6RjfeTMC6W4HxtPuAoO T7bpdHRJtPOmI7ChoWcliI5CUHJd9Y5fpBQ1zDHEnpVjrvXQyN9x9U91CNj1Aw0JZd4q bgX0SDYd9g9tlRHJSfFI9hQrskRN2wbIrd7b7ivAvEY6S2GD6YSiA2ef/gsoIjwp/+d+ OeQoedPgL8NhfSIeyKe+02wUxfe92XzLDZG6sT11iB7nixFJepA6+lyBB17sJaaafHXA KPqOLRGBUIrARw9nKYpY59tUFXac63DqLmzSR27Q+89QDmyv/UiZFiYmMtiL2tqJuADO 6CEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z17-20020a05640240d100b004a256509804si844127edb.605.2023.01.30.00.08.43; Mon, 30 Jan 2023 00:09:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235810AbjA3IIA (ORCPT + 99 others); Mon, 30 Jan 2023 03:08:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235607AbjA3IHd (ORCPT ); Mon, 30 Jan 2023 03:07:33 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B8AA298DA for ; Mon, 30 Jan 2023 00:07:30 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMPCB-0003fA-2e; Mon, 30 Jan 2023 09:07:19 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pMPCA-001Pw9-Kr; Mon, 30 Jan 2023 09:07:17 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pMPC7-000aK1-LH; Mon, 30 Jan 2023 09:07:15 +0100 From: Oleksij Rempel To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Arun.Ramadoss@microchip.com Subject: [PATCH net-next v3 07/15] net: phy: c45: migrate to genphy_c45_write_eee_adv() Date: Mon, 30 Jan 2023 09:07:06 +0100 Message-Id: <20230130080714.139492-8-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230130080714.139492-1-o.rempel@pengutronix.de> References: <20230130080714.139492-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756434160941408578?= X-GMAIL-MSGID: =?utf-8?q?1756434160941408578?= Migrate from genphy_config_eee_advert() to genphy_c45_write_eee_adv(). It should work as before except write operation to the EEE adv registers will be done only if some EEE abilities was detected. If some driver will have a regression, related driver should provide own .get_features callback. See micrel.c:ksz9477_get_features() as example. Signed-off-by: Oleksij Rempel --- drivers/net/phy/phy-c45.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c index d89627ee0ec8..3a990e0a8d51 100644 --- a/drivers/net/phy/phy-c45.c +++ b/drivers/net/phy/phy-c45.c @@ -262,7 +262,11 @@ int genphy_c45_an_config_aneg(struct phy_device *phydev) linkmode_and(phydev->advertising, phydev->advertising, phydev->supported); - changed = genphy_config_eee_advert(phydev); + ret = genphy_c45_write_eee_adv(phydev, phydev->supported_eee); + if (ret < 0) + return ret; + else if (ret) + changed = true; if (genphy_c45_baset1_able(phydev)) return genphy_c45_baset1_an_config_aneg(phydev); @@ -945,6 +949,11 @@ int genphy_c45_pma_read_abilities(struct phy_device *phydev) } } + /* This is optional functionality. If not supported, we may get an error + * which should be ignored. + */ + genphy_c45_read_eee_abilities(phydev); + return 0; } EXPORT_SYMBOL_GPL(genphy_c45_pma_read_abilities);