From patchwork Mon Jan 30 08:07:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 50181 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2062837wrn; Mon, 30 Jan 2023 00:11:46 -0800 (PST) X-Google-Smtp-Source: AK7set/n08vgBqABJ/LtAHOWLeM1riOQZzfoiqHpOt0gybWE8EqJ241y7RHR3CrU2HV+L5N6LOuq X-Received: by 2002:a17:907:38c:b0:878:7189:a457 with SMTP id ss12-20020a170907038c00b008787189a457mr16095446ejb.51.1675066306231; Mon, 30 Jan 2023 00:11:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675066306; cv=none; d=google.com; s=arc-20160816; b=iQOXMUprC2R9zpi5JYZLaB3TAmdg0AxnPgmS44h9Z7ukXNJAal+PX5sNyBcSaPIFOO h3i/lMqNsTYTSyyeqsWcbGfxI8YFSaXI01G5dsjpp4uypNCpQFRJyxzN1Kh9TwxvxqIx rS08AEKW6gWC7nx35OwyX85SKV/YXVFLEJvtJJXOoXIvBO388Bvo7ALVc4OULY8M0str DjLP4ZVw0V2RLCgq07R6VG5w8fjQioZChOCHLyse6qZ1Yt2I0eaBtvxrV4xnmwS+yLnt iN8naz5+qFTHyBLACTCI76prNfRxW0EUYnyg+wF+luElw6X/ZY+DtGwByl+kJ+yheIJW fkBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=mJHU3mRJN9cfxTCGQUkwyi8DkVcJDLB8FxAGa8v0Txg=; b=aGyPp/7OYQt6NhfEZHf7WSi39N1RynR7n+IDCE8/RVBqt7EpG4aAiurFcgnIRacJGV OD6p8GdTi5KYkMhWegZA8gcUwgo6/9f08Vpu53Yf76O6mf5raWaToNmKRR2VHZJxYbpu PPNufP+mYAbyqVoVHb2P0iiPxNuq+OF26aAEV2ynxhXk0A+pQwtMfy6g0+a2pNnxReBa JM5KwY+zBdxuoJpnXxLCf8WUr5aRrcbSGnA9w0sn7aWkPflGG3eZ5Fo83j2M4ThQ7C71 YYr95o3vxhEtlAmHzKdWmHcoQQwa8PzPTiA3CZP+HqzeGu8LOp9BpCs+r3ZCpzpreCtG gIxw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fi24-20020a1709073ad800b0087858975f3esi12364348ejc.269.2023.01.30.00.11.23; Mon, 30 Jan 2023 00:11:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235914AbjA3IIX (ORCPT + 99 others); Mon, 30 Jan 2023 03:08:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235710AbjA3IHj (ORCPT ); Mon, 30 Jan 2023 03:07:39 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95F6F2A9AE for ; Mon, 30 Jan 2023 00:07:37 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMPCF-0003fF-NJ; Mon, 30 Jan 2023 09:07:23 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pMPCB-001PwP-0R; Mon, 30 Jan 2023 09:07:18 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pMPC7-000aJs-Kk; Mon, 30 Jan 2023 09:07:15 +0100 From: Oleksij Rempel To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Arun.Ramadoss@microchip.com Subject: [PATCH net-next v3 06/15] net: phy: c22: migrate to genphy_c45_write_eee_adv() Date: Mon, 30 Jan 2023 09:07:05 +0100 Message-Id: <20230130080714.139492-7-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230130080714.139492-1-o.rempel@pengutronix.de> References: <20230130080714.139492-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756434327292491792?= X-GMAIL-MSGID: =?utf-8?q?1756434327292491792?= Migrate from genphy_config_eee_advert() to genphy_c45_write_eee_adv(). It should work as before except write operation to the EEE adv registers will be done only if some EEE abilities was detected. If some driver will have a regression, related driver should provide own .get_features callback. See micrel.c:ksz9477_get_features() as example. Signed-off-by: Oleksij Rempel --- drivers/net/phy/phy_device.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 698549ef2981..abe6124eb9dc 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -2231,7 +2231,10 @@ int __genphy_config_aneg(struct phy_device *phydev, bool changed) { int err; - if (genphy_config_eee_advert(phydev)) + err = genphy_c45_write_eee_adv(phydev, phydev->supported_eee); + if (err < 0) + return err; + else if (err) changed = true; err = genphy_setup_master_slave(phydev); @@ -2653,6 +2656,11 @@ int genphy_read_abilities(struct phy_device *phydev) phydev->supported, val & ESTATUS_1000_XFULL); } + /* This is optional functionality. If not supported, we may get an error + * which should be ignored. + */ + genphy_c45_read_eee_abilities(phydev); + return 0; } EXPORT_SYMBOL(genphy_read_abilities);