diff mbox series

ARM: Allow DEBUG_UNCOMPRESS on ARCH_MULTIPLATFORM

Message ID 20230129160039.1598347-1-j.neuschaefer@gmx.net
State New
Headers
Series ARM: Allow DEBUG_UNCOMPRESS on ARCH_MULTIPLATFORM |

Commit Message

Jonathan Neuschäfer Jan. 29, 2023, 4 p.m. UTC 
  A kernel with DEBUG_UNCOMPRESS=y will only work on one platform, but
that is already the case with DEBUG_LL=y (and documented in its help
text), and DEBUG_UNCOMPRESS depends on DEBUG_LL. Therefore, I don't
think users need to be prevented from enabling DEBUG_UNCOMPRESS on
ARCH_MULTIPLATFORM kernels.

Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
 arch/arm/Kconfig.debug | 1 -
 1 file changed, 1 deletion(-)

--
2.39.0

Comments

Arnd Bergmann Jan. 30, 2023, 8:08 a.m. UTC | #1 
On Sun, Jan 29, 2023, at 17:00, Jonathan Neuschäfer wrote:
> A kernel with DEBUG_UNCOMPRESS=y will only work on one platform, but
> that is already the case with DEBUG_LL=y (and documented in its help
> text), and DEBUG_UNCOMPRESS depends on DEBUG_LL. Therefore, I don't
> think users need to be prevented from enabling DEBUG_UNCOMPRESS on
> ARCH_MULTIPLATFORM kernels.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>

I think we should instead change the help text for CONFIG_DEBUG_LL.

There is a very significant difference between the requirements
of DEBUG_LL compared to DEBUG_UNCOMPRESS. The former only provides
the platform specific functions but does not call them unless
a user explicitly passes the "earlyprintk" command line argument
or adds explicit function calls to printascii(), while the latter
makes the kernel immediately unbootable.

     Arnd
diff mbox series

Patch

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index c345775f035bc..655f84ada30f4 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -1904,7 +1904,6 @@  config DEBUG_UART_8250_PALMCHIP

 config DEBUG_UNCOMPRESS
 	bool "Enable decompressor debugging via DEBUG_LL output"
-	depends on !ARCH_MULTIPLATFORM
 	depends on !(ARCH_FOOTBRIDGE || ARCH_RPC || ARCH_SA1100)
 	depends on DEBUG_LL && !DEBUG_OMAP2PLUS_UART && \
 		     (!DEBUG_TEGRA_UART || !ZBOOT_ROM) && \