From patchwork Fri Jan 27 23:51:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gavin Shan X-Patchwork-Id: 49726 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1106614wrn; Fri, 27 Jan 2023 15:58:59 -0800 (PST) X-Google-Smtp-Source: AMrXdXtGD3wWoox3YdlGSHNAicXnUCow2+kj1FmQcmeVB7ajchKERCBaSxuuyWvo8H/k2dKGDBjj X-Received: by 2002:a17:90a:b798:b0:229:d641:9ef2 with SMTP id m24-20020a17090ab79800b00229d6419ef2mr36024354pjr.40.1674863939402; Fri, 27 Jan 2023 15:58:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674863939; cv=none; d=google.com; s=arc-20160816; b=ZAZG/QI0iJdyvNiV1itYpVvClK81k7+WiUSkLGF2QwNpi3mRAkfPQ8NrsTVGX9SSku aR2xslWiBomOZBlV6oVSGB83MnDDNBmJOPhW+vjeZ9idOMGBAklqCWODvQEuL7cUrrDp L5+Fo2ivqDBQH90TY2Eko3a2t3G4mXvhfj4xPjGFehL/4uYsYc1Z2rAHc6dNNeh+lfAt Lwszv/1EFzqeuNKRK2K+i/UeUTgC0LK5Dcun9FMUWQzPurr9XAqHFDUf3n1TkpHjB3OA P7ksFq6QSLjoAgbQO150aXF7mVAuo86Gc1YCmjyR/jF3lMi7c0p7s2YOXVTahU7WGBX8 BmPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=c2wJW8358fg+BxDaJzgkd3OND14b2zFqKAQeciq7tLo=; b=RIFvBPtLNX/Q1x7zaN9GRKicJ59N+eqix2sqvJEBm4MA0BW31j69CgieokIr9qhmFF AN4RXsZDI2Ryy/XPOswueyBTMbg5vCTCTn5kFVV9Xe01j7aDh8uvr/51vdX8ncS2lm6/ 8sxWxuhpULcij7IctpiW4sWCCJsrQP2J7FX/fBfvtH4gSUkHifxn399ezR9YWodlhKJW Ku7ogOKM0LQCRj/sjrhsEND6Pjvg0but4oWIWWQdJsV95rpTeDQs9UGM0TZtvZZrXoED t6A2TYogFZiChxEhI+1XJlwLKbUXVqQ7Ukk86KgpsabHSLJ8tZMZ91qEq+vb8+MpM4pc uQ5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GbokbVQi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z2-20020a17090a66c200b0022c693182d3si476635pjl.136.2023.01.27.15.58.47; Fri, 27 Jan 2023 15:58:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GbokbVQi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231548AbjA0Xxs (ORCPT + 99 others); Fri, 27 Jan 2023 18:53:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232167AbjA0Xxp (ORCPT ); Fri, 27 Jan 2023 18:53:45 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6BEC2A9A1 for ; Fri, 27 Jan 2023 15:52:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674863578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c2wJW8358fg+BxDaJzgkd3OND14b2zFqKAQeciq7tLo=; b=GbokbVQiZmbMiRZjm2xrJqOg0R43mooZAdiOec9At1aLYIWtx3bNDKnO1E4oHOcUVnjqOj yw7VdqT9Azgz9/ylezRtNqnImhF9PkOn2GBrOo5dKuafHgGdklS1D3nSFlQWS+PluaKD0f pNPfpGfXcXgLwsxuINICQ4PEYVgS/BI= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-490--DjD9ThIOLGmJsNr4myWAw-1; Fri, 27 Jan 2023 18:52:52 -0500 X-MC-Unique: -DjD9ThIOLGmJsNr4myWAw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D5B672801E4F; Fri, 27 Jan 2023 23:52:51 +0000 (UTC) Received: from gshan.redhat.com (vpn2-54-64.bne.redhat.com [10.64.54.64]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5F02B40C141B; Fri, 27 Jan 2023 23:52:44 +0000 (UTC) From: Gavin Shan To: kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu Cc: pbonzini@redhat.com, corbet@lwn.net, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, yuzhe@nfschina.com, gshan@redhat.com, seanjc@google.com, isaku.yamahata@intel.com, ricarkol@google.com, eric.auger@redhat.com, renzhengeek@gmail.com, reijiw@google.com, shan.gavin@gmail.com Subject: [PATCH v4 3/4] KVM: arm64: Allow no running vcpu on restoring VGICv3 LPI pending status Date: Sat, 28 Jan 2023 07:51:49 +0800 Message-Id: <20230127235150.17025-4-gshan@redhat.com> In-Reply-To: <20230127235150.17025-1-gshan@redhat.com> References: <20230127235150.17025-1-gshan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756222129855583771?= X-GMAIL-MSGID: =?utf-8?q?1756222129855583771?= We don't have a running VCPU context to restore VGICv3 LPI pending status due to command KVM_DEV_ARM_{VGIC_GRP_CTRL, ITS_RESTORE_TABLES} on KVM device "kvm-arm-vgic-its". Use vgic_write_guest_lock() to restore VGICv3 LPI pending status. Signed-off-by: Gavin Shan Reviewed-by: Oliver Upton --- Documentation/virt/kvm/api.rst | 8 +++++--- arch/arm64/kvm/vgic/vgic-v3.c | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst index 9807b05a1b57..5dc3598afbe2 100644 --- a/Documentation/virt/kvm/api.rst +++ b/Documentation/virt/kvm/api.rst @@ -8070,9 +8070,11 @@ considering the state as complete. VMM needs to ensure that the dirty state is final and avoid missing dirty pages from another ioctl ordered after the bitmap collection. -NOTE: One example of using the backup bitmap is saving arm64 vgic/its -tables through KVM_DEV_ARM_{VGIC_GRP_CTRL, ITS_SAVE_TABLES} command on -KVM device "kvm-arm-vgic-its" when dirty ring is enabled. +NOTE: Multiple examples of using the backup bitmap: (1) save vgic/its +tables through command KVM_DEV_ARM_{VGIC_GRP_CTRL, ITS_SAVE_TABLES} on +KVM device "kvm-arm-vgic-its". (2) restore vgic/its tables through +command KVM_DEV_ARM_{VGIC_GRP_CTRL, ITS_RESTORE_TABLES} on KVM device +"kvm-arm-vgic-its". VGICv3 LPI pending status is restored. 8.30 KVM_CAP_XEN_HVM -------------------- diff --git a/arch/arm64/kvm/vgic/vgic-v3.c b/arch/arm64/kvm/vgic/vgic-v3.c index 5dfbd03e5e1a..c94e4d7520fc 100644 --- a/arch/arm64/kvm/vgic/vgic-v3.c +++ b/arch/arm64/kvm/vgic/vgic-v3.c @@ -338,7 +338,7 @@ int vgic_v3_lpi_sync_pending_status(struct kvm *kvm, struct vgic_irq *irq) if (status) { /* clear consumed data */ val &= ~(1 << bit_nr); - ret = kvm_write_guest_lock(kvm, ptr, &val, 1); + ret = vgic_write_guest_lock(kvm, ptr, &val, 1); if (ret) return ret; }