From patchwork Fri Jan 27 18:12:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Reichel X-Patchwork-Id: 49565 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp974472wrn; Fri, 27 Jan 2023 10:14:59 -0800 (PST) X-Google-Smtp-Source: AK7set94T/194gvf7PkU4XqkMjC8OMnNxc3qwvhmz9/CDkbGDr2PO2JKBh6dPRlvV8qKN4uPchOs X-Received: by 2002:a17:90b:1a89:b0:22c:421:dbfc with SMTP id ng9-20020a17090b1a8900b0022c0421dbfcmr11919633pjb.13.1674843299549; Fri, 27 Jan 2023 10:14:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674843299; cv=none; d=google.com; s=arc-20160816; b=KLLd0rk7jyVLjMTW8fqK5a47tI1ULshd5ezGww6Zw491kyx6KnMucBWK00b9Jk7CYY +OXI0Wz954D/Db5CIUVRruLH6HMj0NSEsYr+GKDysTsqkMZowSYF87X7m5GqBrBL+agU ZvZZOXf4mrCvKIHA6ZGAwFOUC5zH/RWssUuJGtuKAZjb7X0clIAnokXo0MbstJHeT80f phatQcN9/WegF+tVFteVgiqXZxsLWpt6dK56QFJsLCjME+eMOUk5s/jTaSBcVGepb8AM UCi8q7phE3ZC/u2OpFmP5gzEm3JRgQf+WBmia6JeW9Wxg3yCD3TQoT4kxKiDO2gsh8Fs UVfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+8jt9KObevzStGgbzoTc3cape+WRJnmipepQAwnbtJ4=; b=AzIVHZn08mghw68cN0pg+P5PwdLi+VEITJFifgzL1nVHTDbDxKywgVcaBrscpGFA9x MYqpZ/8L+PNXvmLwlY+b1gbxHsl2zWHDPUQsXD2aPzX5nfhHVHLLo2QTVWyd06OqElVB ZZmKFOShmFbqh8JPHPAoFdoIHoKjUyyXc/caNkzrwlikNqzmMBvJunj2X3n2tKtSMRkj j8ZfM92qhrLRK6KlLN9P5aHScBjmF0W1HVlDcn3IAy4FGFiPrC4o06z5eY+pjuizbm9P 1Ej2wrDuu79Y4MaPqF18lAzpHAkbVLF4BBYh35KVWdzK+lLU2ed+5DJwzSZW/vbXhp88 MR1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=IpMI2bRs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x8-20020a17090a294800b0022bfd18f329si5165207pjf.54.2023.01.27.10.14.46; Fri, 27 Jan 2023 10:14:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=IpMI2bRs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235265AbjA0SON (ORCPT + 99 others); Fri, 27 Jan 2023 13:14:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234892AbjA0SNt (ORCPT ); Fri, 27 Jan 2023 13:13:49 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAA4F7F699; Fri, 27 Jan 2023 10:13:40 -0800 (PST) Received: from jupiter.universe (dyndsl-095-033-159-051.ewe-ip-backbone.de [95.33.159.51]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: sre) by madras.collabora.co.uk (Postfix) with ESMTPSA id BDAC86602F13; Fri, 27 Jan 2023 18:13:22 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1674843203; bh=TNmTI9LRk0yhLmS5JTsTApyWD6mKPxT3umkyxpXaAjI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IpMI2bRsTl4lWiZVla0KFyBbunGWwDR4+YxBp9GW4g1y5kud6VsgfGgDPavDNQS4N xYmsWeXO/ZISmFkd1fCMfWMOi92Pojx9TeSc4FuSSYvoIzZPSnbMOQHc8WvDakYH9o 1c3xwkI9rMXllBEIwvNiAM18PWYhMfbSLJ3HAEe80IfYtxGuZOZ11bSKXk4vazJC1g R4RSbh0APNmexWQ20alJYqtKvDLJyMgzc37j/YHmjo+Vo+lA5BQdmSGzY3GvUdAyxE wGXPNALKP4M8SX0w1oScAgQXeY/GmtN1ahHruy47Mrm92gk4eeQ6aMJq9jxKM/w46I ZImtxGsmn25Sw== Received: by jupiter.universe (Postfix, from userid 1000) id 437FF480120; Fri, 27 Jan 2023 19:13:17 +0100 (CET) From: Sebastian Reichel To: Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Lee Jones Cc: Michael Turquette , Stephen Boyd , Linus Walleij , Mark Brown , Liam Girdwood , Alexandre Belloni , Alessandro Zummo , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , kernel@collabora.com Subject: [PATCHv6 10/11] regulator: expose regulator_find_closest_bigger Date: Fri, 27 Jan 2023 19:12:43 +0100 Message-Id: <20230127181244.160887-11-sebastian.reichel@collabora.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230127181244.160887-1-sebastian.reichel@collabora.com> References: <20230127181244.160887-1-sebastian.reichel@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756200487845563664?= X-GMAIL-MSGID: =?utf-8?q?1756200487845563664?= Expose and document the table lookup logic used by regulator_set_ramp_delay_regmap, so that it can be reused for devices that cannot be configured via regulator_set_ramp_delay_regmap. Signed-off-by: Sebastian Reichel --- drivers/regulator/helpers.c | 22 ++++++++++++++++++---- include/linux/regulator/driver.h | 2 ++ 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/helpers.c b/drivers/regulator/helpers.c index ad2237a95572..586f42e378ee 100644 --- a/drivers/regulator/helpers.c +++ b/drivers/regulator/helpers.c @@ -902,8 +902,21 @@ bool regulator_is_equal(struct regulator *reg1, struct regulator *reg2) } EXPORT_SYMBOL_GPL(regulator_is_equal); -static int find_closest_bigger(unsigned int target, const unsigned int *table, - unsigned int num_sel, unsigned int *sel) +/** + * regulator_find_closest_bigger - helper to find offset in ramp delay table + * + * @target: targeted ramp_delay + * @table: table with supported ramp delays + * @num_sel: number of entries in the table + * @sel: Pointer to store table offset + * + * This is the internal helper used by regulator_set_ramp_delay_regmap to + * map ramp delay to register value. It should only be used directly if + * regulator_set_ramp_delay_regmap cannot handle a specific device setup + * (e.g. because the value is split over multiple registers). + */ +int regulator_find_closest_bigger(unsigned int target, const unsigned int *table, + unsigned int num_sel, unsigned int *sel) { unsigned int s, tmp, max, maxsel = 0; bool found = false; @@ -933,6 +946,7 @@ static int find_closest_bigger(unsigned int target, const unsigned int *table, return 0; } +EXPORT_SYMBOL_GPL(regulator_find_closest_bigger); /** * regulator_set_ramp_delay_regmap - set_ramp_delay() helper @@ -951,8 +965,8 @@ int regulator_set_ramp_delay_regmap(struct regulator_dev *rdev, int ramp_delay) if (WARN_ON(!rdev->desc->n_ramp_values || !rdev->desc->ramp_delay_table)) return -EINVAL; - ret = find_closest_bigger(ramp_delay, rdev->desc->ramp_delay_table, - rdev->desc->n_ramp_values, &sel); + ret = regulator_find_closest_bigger(ramp_delay, rdev->desc->ramp_delay_table, + rdev->desc->n_ramp_values, &sel); if (ret) { dev_warn(rdev_get_dev(rdev), diff --git a/include/linux/regulator/driver.h b/include/linux/regulator/driver.h index d3b4a3d4514a..c6ef7d68eb9a 100644 --- a/include/linux/regulator/driver.h +++ b/include/linux/regulator/driver.h @@ -758,6 +758,8 @@ int regulator_set_current_limit_regmap(struct regulator_dev *rdev, int min_uA, int max_uA); int regulator_get_current_limit_regmap(struct regulator_dev *rdev); void *regulator_get_init_drvdata(struct regulator_init_data *reg_init_data); +int regulator_find_closest_bigger(unsigned int target, const unsigned int *table, + unsigned int num_sel, unsigned int *sel); int regulator_set_ramp_delay_regmap(struct regulator_dev *rdev, int ramp_delay); int regulator_sync_voltage_rdev(struct regulator_dev *rdev);