| Message ID | 20230127135755.79929-4-mathieu.desnoyers@efficios.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp846308wrn;
Fri, 27 Jan 2023 05:59:56 -0800 (PST)
X-Google-Smtp-Source:
AMrXdXtjSAk2mAfA96pWj87WvZoXsETyhTUY75OcsaVY83wI6P12U3sJD7WDTUoULsOXmfyOL5rf
X-Received: by 2002:aa7:cacd:0:b0:49e:20f9:4ade with SMTP id
l13-20020aa7cacd000000b0049e20f94ademr40042433edt.10.1674827996013;
Fri, 27 Jan 2023 05:59:56 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1674827995; cv=none;
d=google.com; s=arc-20160816;
b=SdtCW2McSnMEIM1cvMwpKBIiw8ZQ9CEovolI8MhnPyKv6EoQDgZim+OTdZ4ocKO/Cu
TAgaa8v+dwT9goR/KomlkdB+qaw7/6uuDCnK1anlw21NaMGHhmXgtxPqlOnRQpxjmZTx
lvBvIfmRTfmI8k5uLVWGAKOhzwQWCLKPJzyjJ791hfBToh01ObQW8iSSIPbo6U6IoUhk
NMEOaBtm30wiC96/doWWyog2viLqobhILQa0a3GIYW3UKiUwsJfO/beJshE+YVb4GHFY
KQb7q587mG3QZa+MVGmmcwN66oLbCVJr6gTLo/zEmbJsM00oPDeQxs7JUwLriq2bfOFn
PNGw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=Zc4SWGgsofgpkWXkAAUGbf0bbOBEMxPLT5yq8KjrvnI=;
b=d/vq53HYm5dCZdLKV6K6JuGgHSsrKG8CrHsW7LPIGbQlAm1gnePqBvutWLBzL64nJA
QzveplFZg7fcSorMpBkyppfOE3C/XSmRAET/Zmh21dNzVcTeuG3VkDnannvYpSA2h+Dm
Es5gimxViMoQhxnjgIgCEbQ0jO52Eh1XoCFw1V5fauzVBmQtIfMwxhLoKyu8pLzMXeAa
L0wjdm7mrVsgkfn71IYJ3IVfi55pd3EQfYCgOaPCy59/rpvi9LwcO3rsROU56pk0y5Br
bAM8G2RQgllL52DkdwPRr1dm/d+WHs240IgEzV9x5ca8e3uHt9qGMNw0ujwmteYArhny
nAJA==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@efficios.com header.s=smtpout1 header.b=mQl6h6aj;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=efficios.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
uh6-20020a170906b38600b00878529e9d49si4581882ejc.573.2023.01.27.05.59.27;
Fri, 27 Jan 2023 05:59:55 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@efficios.com header.s=smtpout1 header.b=mQl6h6aj;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=efficios.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S233734AbjA0N6M (ORCPT <rfc822;lekhanya01809@gmail.com>
+ 99 others); Fri, 27 Jan 2023 08:58:12 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37430 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S233479AbjA0N6H (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 27 Jan 2023 08:58:07 -0500
Received: from smtpout.efficios.com (unknown [IPv6:2607:5300:203:b2ee::31e5])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D4AB40ED;
Fri, 27 Jan 2023 05:58:02 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com;
s=smtpout1; t=1674827881;
bh=ZcCKW7xHONk6lQkmDiIQ6FF58ak31qhSFzWiuXDr2hE=;
h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
b=mQl6h6ajedQaMhcvhGLSEeGTiB+LP244YHTUh0QwRPLf/lQeqdklGNFmgnU1+7Tab
EX+MEIw7zp/t8lW2Uw/XOFoWqmPWBK8KKnYYXrEM7UEFpD4uud1/JGO1dR+eZhyGKb
e2TPY+m8ZRZxOqgGoEggAWS9yp+IRySGPDEYznCAKaLl/A5e7miInF/FLDEv3lNoh4
IXq744ROYHlE4+xeyYveQdLCrdnU9V5UwToAXNWEhrkU72VlUJ7Ptdq+iRCaBxP90v
1aZ14YkS3crvxCt1zJ+zM8FTfGYuyttIkBkyCKgOEKkM2I0IU48U1cyrE49aSKLxV4
CVlScCdUtk7Ag==
Received: from localhost.localdomain (192-222-180-24.qc.cable.ebox.net
[192.222.180.24])
by smtpout.efficios.com (Postfix) with ESMTPSA id 4P3K0T5NPszhnn;
Fri, 27 Jan 2023 08:58:01 -0500 (EST)
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Shuah Khan <shuah@kernel.org>, linux-kselftest@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
stable@vger.kernel.org
Subject: [PATCH 03/34] selftests: clone3: Fix incorrect kernel headers search
path
Date: Fri, 27 Jan 2023 08:57:24 -0500
Message-Id: <20230127135755.79929-4-mathieu.desnoyers@efficios.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20230127135755.79929-1-mathieu.desnoyers@efficios.com>
References: <20230127135755.79929-1-mathieu.desnoyers@efficios.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RDNS_NONE,SPF_HELO_NONE,
SPF_PASS autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1756184440543927978?=
X-GMAIL-MSGID: =?utf-8?q?1756184440543927978?=
|
| Series |
selftests: Fix incorrect kernel headers search path
|
|
Commit Message
Mathieu Desnoyers
Jan. 27, 2023, 1:57 p.m. UTC
Use $(KHDR_INCLUDES) as lookup path for kernel headers. This prevents
building against kernel headers from the build environment in scenarios
where kernel headers are installed into a specific output directory
(O=...).
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: linux-kselftest@vger.kernel.org
Cc: Ingo Molnar <mingo@redhat.com>
Cc: <stable@vger.kernel.org> [5.18+]
---
tools/testing/selftests/clone3/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 1/27/23 06:57, Mathieu Desnoyers wrote: > Use $(KHDR_INCLUDES) as lookup path for kernel headers. This prevents > building against kernel headers from the build environment in scenarios > where kernel headers are installed into a specific output directory > (O=...). > > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> > Cc: Shuah Khan <shuah@kernel.org> > Cc: linux-kselftest@vger.kernel.org > Cc: Ingo Molnar <mingo@redhat.com> > Cc: <stable@vger.kernel.org> [5.18+] > --- > tools/testing/selftests/clone3/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/clone3/Makefile b/tools/testing/selftests/clone3/Makefile > index 79b19a2863a0..84832c369a2e 100644 > --- a/tools/testing/selftests/clone3/Makefile > +++ b/tools/testing/selftests/clone3/Makefile > @@ -1,5 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0 > -CFLAGS += -g -std=gnu99 -I../../../../usr/include/ > +CFLAGS += -g -std=gnu99 $(KHDR_INCLUDES) > LDLIBS += -lcap > > TEST_GEN_PROGS := clone3 clone3_clear_sighand clone3_set_tid \ + brauner@kernel.org Hi Christian, Would you me to take this patch through kselftest tree? If you decide to take this through yours: Acked-by: Shuah Khan <skhan@linuxfoundation.org> thanks, -- Shuah
On Mon, Jan 30, 2023 at 09:15:13AM -0700, Shuah Khan wrote: > On 1/27/23 06:57, Mathieu Desnoyers wrote: > > Use $(KHDR_INCLUDES) as lookup path for kernel headers. This prevents > > building against kernel headers from the build environment in scenarios > > where kernel headers are installed into a specific output directory > > (O=...). > > > > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> > > Cc: Shuah Khan <shuah@kernel.org> > > Cc: linux-kselftest@vger.kernel.org > > Cc: Ingo Molnar <mingo@redhat.com> > > Cc: <stable@vger.kernel.org> [5.18+] > > --- Looks good to me, Acked-by: Christian Brauner <brauner@kernel.org> > > tools/testing/selftests/clone3/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/testing/selftests/clone3/Makefile b/tools/testing/selftests/clone3/Makefile > > index 79b19a2863a0..84832c369a2e 100644 > > --- a/tools/testing/selftests/clone3/Makefile > > +++ b/tools/testing/selftests/clone3/Makefile > > @@ -1,5 +1,5 @@ > > # SPDX-License-Identifier: GPL-2.0 > > -CFLAGS += -g -std=gnu99 -I../../../../usr/include/ > > +CFLAGS += -g -std=gnu99 $(KHDR_INCLUDES) > > LDLIBS += -lcap > > TEST_GEN_PROGS := clone3 clone3_clear_sighand clone3_set_tid \ > > + brauner@kernel.org > > Hi Christian, Hey Shuah, > > Would you me to take this patch through kselftest tree? If you Feel free to take it through the kselftest tree. Thank you! Christian
diff --git a/tools/testing/selftests/clone3/Makefile b/tools/testing/selftests/clone3/Makefile index 79b19a2863a0..84832c369a2e 100644 --- a/tools/testing/selftests/clone3/Makefile +++ b/tools/testing/selftests/clone3/Makefile @@ -1,5 +1,5 @@ # SPDX-License-Identifier: GPL-2.0 -CFLAGS += -g -std=gnu99 -I../../../../usr/include/ +CFLAGS += -g -std=gnu99 $(KHDR_INCLUDES) LDLIBS += -lcap TEST_GEN_PROGS := clone3 clone3_clear_sighand clone3_set_tid \