[RESEND] drm/logicvc: Drop obsolete dependency on COMPILE_TEST

Message ID 20230127120135.293dfc60@endymion.delvare
State New
Headers
Series [RESEND] drm/logicvc: Drop obsolete dependency on COMPILE_TEST |

Commit Message

Jean Delvare Jan. 27, 2023, 11:01 a.m. UTC
  Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
is possible to test-build any driver which depends on OF on any
architecture by explicitly selecting OF. Therefore depending on
COMPILE_TEST as an alternative is no longer needed.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
---
 drivers/gpu/drm/logicvc/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Paul Kocialkowski Jan. 30, 2023, 9:15 a.m. UTC | #1
Hi Jean,

On Fri 27 Jan 23, 12:01, Jean Delvare wrote:
> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>

Sounds good to me!

Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

Cheers,

Paul

> ---
>  drivers/gpu/drm/logicvc/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-6.1.orig/drivers/gpu/drm/logicvc/Kconfig
> +++ linux-6.1/drivers/gpu/drm/logicvc/Kconfig
> @@ -1,7 +1,7 @@
>  config DRM_LOGICVC
>  	tristate "LogiCVC DRM"
>  	depends on DRM
> -	depends on OF || COMPILE_TEST
> +	depends on OF
>  	select DRM_KMS_HELPER
>  	select DRM_KMS_DMA_HELPER
>  	select DRM_GEM_DMA_HELPER
> 
> 
> -- 
> Jean Delvare
> SUSE L3 Support
  

Patch

--- linux-6.1.orig/drivers/gpu/drm/logicvc/Kconfig
+++ linux-6.1/drivers/gpu/drm/logicvc/Kconfig
@@ -1,7 +1,7 @@ 
 config DRM_LOGICVC
 	tristate "LogiCVC DRM"
 	depends on DRM
-	depends on OF || COMPILE_TEST
+	depends on OF
 	select DRM_KMS_HELPER
 	select DRM_KMS_DMA_HELPER
 	select DRM_GEM_DMA_HELPER