From patchwork Fri Jan 27 11:29:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Price X-Patchwork-Id: 49264 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp783537wrn; Fri, 27 Jan 2023 03:34:01 -0800 (PST) X-Google-Smtp-Source: AK7set/nItxn9KHV28CZqi+RdUyvrHK7nNSczTKalCFhOMX/V1K/ao+iIWeEkzePrWaLXcI8Qqkg X-Received: by 2002:a17:902:d492:b0:196:3feb:1f1e with SMTP id c18-20020a170902d49200b001963feb1f1emr6522925plg.47.1674819241561; Fri, 27 Jan 2023 03:34:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674819241; cv=none; d=google.com; s=arc-20160816; b=ndcPjdOvQJiNr3hVBMhWadoDgHI5KnZWxaJnwWhU5Ma6+wi+Pldl+mnDVBa0PoWqLL ObPskZRXBmrHiCc5HKanjxNTMzL4SFsFy3ipugQQKixSzMMgUBoLeiTsWDrPe3hhiWyV wR75G/mgsV0g5koP6Ucry9/DWczgyeIDrg/vkSg10DtB0w8AeiqfiWb9rI6oIQKcWrow 0m59uibUhnVDNATlI84g8if4L4tJel63i35djQ/FLpVtisqEjbdI7fFgOHhEl+jXbqSR 5RiriaPD3DnsdfaKRnaUn8HeyGNm/3m0ZcV0ZQ0rwBEKQnek6LVLrkKaXWWDX4+2stze iGvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=+nXKcxRiBXWZWetNf+3NGbJ+8n9JkoB2ceCXG1dJ3oA=; b=er2y+GyNp2hkxxIInYgkzjDfyh0EpYL5CR3Oxvkzyu8z2jMuRJlQ6CZwke/KFT2cXd sUHq4+SqRDDp+OEI1k2y5DNXhQ+/T1HHsHqMmClaC4okJ5b/1CBUT2hnl9a7lpSBzs4O YNy7oRsaRoyCcWoeGM4fEIWWuEOjNFz5aPaglbNsnz6GJvEsjZcEScal8Q8uzkqzXYmk MsP6zwOR3fUqzh+VKNLsUV0/AuEAwiHg8Poh+zRHL7Lcxa3Pk+z+bryfGuMdjS5qPoDO JeukKBSriXwR9ym4FIaecSrAfz28bvDzziXaDfsYN8J9E809zTCDZAPhQqcBKnj3G1/d swdQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r10-20020a170902c60a00b001871c762263si4129624plr.185.2023.01.27.03.33.49; Fri, 27 Jan 2023 03:34:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233764AbjA0LdW (ORCPT + 99 others); Fri, 27 Jan 2023 06:33:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233719AbjA0Lcy (ORCPT ); Fri, 27 Jan 2023 06:32:54 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B1C4678ADC; Fri, 27 Jan 2023 03:31:20 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 43CBB169C; Fri, 27 Jan 2023 03:31:18 -0800 (PST) Received: from e122027.cambridge.arm.com (e122027.cambridge.arm.com [10.1.35.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 311753F64C; Fri, 27 Jan 2023 03:30:34 -0800 (PST) From: Steven Price To: kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: Steven Price , Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev Subject: [RFC PATCH 21/28] KVM: arm64: WARN on injected undef exceptions Date: Fri, 27 Jan 2023 11:29:25 +0000 Message-Id: <20230127112932.38045-22-steven.price@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230127112932.38045-1-steven.price@arm.com> References: <20230127112248.136810-1-suzuki.poulose@arm.com> <20230127112932.38045-1-steven.price@arm.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756175261171671403?= X-GMAIL-MSGID: =?utf-8?q?1756175261171671403?= The RMM doesn't allow injection of a undefined exception into a realm guest. Add a WARN to catch if this ever happens. Signed-off-by: Steven Price --- arch/arm64/kvm/inject_fault.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/kvm/inject_fault.c b/arch/arm64/kvm/inject_fault.c index f32f4a2a347f..29966a3e5a71 100644 --- a/arch/arm64/kvm/inject_fault.c +++ b/arch/arm64/kvm/inject_fault.c @@ -175,6 +175,8 @@ void kvm_inject_size_fault(struct kvm_vcpu *vcpu) */ void kvm_inject_undefined(struct kvm_vcpu *vcpu) { + if (vcpu_is_rec(vcpu)) + WARN(1, "Cannot inject undefined exception into REC. Continuing with unknown behaviour"); if (vcpu_el1_is_32bit(vcpu)) inject_undef32(vcpu); else