From patchwork Fri Jan 27 11:26:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 49234 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp781479wrn; Fri, 27 Jan 2023 03:29:53 -0800 (PST) X-Google-Smtp-Source: AK7set/e+SY8ZXjdzDYUvji61WTNdvOUh7MldklpQ1ohxmDKk8j+AT+VPFf7nTUHIevhr3ok3N0E X-Received: by 2002:a17:902:f2c5:b0:196:56a4:426b with SMTP id h5-20020a170902f2c500b0019656a4426bmr1250118plc.44.1674818992837; Fri, 27 Jan 2023 03:29:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674818992; cv=none; d=google.com; s=arc-20160816; b=gk79ihFVzotTVt+1ZjHKDbBUkgyB31DmMJy3k9D4T5jM0zcNV6La24BmVCpPIQLZcb KF8DTaUcA7eaMYmflnlTyxHqzN6f/BBhjyNATOStqNOsydXGjoUFcAvBIITQtofQjPM3 AlPGnXdmeHcLstfSRa5E6OE+O8s/btYDK/BDVj1t3Cp9bwftZkDtbtf1RWlVxXEB4Mb/ hv398Bzy+gJbmDrkPIkgZD91XI8QTnks8sb43OCwrFOE03lhf/bn/ffNWPx+UkQIjSr+ AtHvrPQqyRNQzrc4Gcbp5rz1lJp/WNyBupPdbCgJEbWW1aQaj2gXQJ0S+DLe8g9aJRlY Yu+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=0NyB8CX+0Sm4wexEEN7Z8nAkSlgZax3KRKSosLThVYI=; b=EssQGXNFZKSjO+5/1TEZD/ku1QNbHJvRurIHuRpkWZ6BVfDfnQyxgImCuG6P78d7UJ 9ZVBQQQ4i/iuwHM2xKMBwTLkegSnda8qX9j8SvPr2uo9ARQ5cymO+BwWqP2eeQQ+2ftm A2OE6Wpw8JuQ+BJikkM+7lVv5n329xOXskWrOQIDgxBz4n+roa0TdPdujA49GwCkt7Iw FdDg+B+FWhO969VHrK4qENAVYLzD6TAwxbDj60CT7qvsWRqBNpTHh+TA+yi6Q1fcOdo1 8UNMklRk6sgwq52pldQekuYOe55MZnbW6EHxdn9/vedi3O7hKJQC5d9DMZBzTWMIqdyS 7qOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=H0K5FOoe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h8-20020a636c08000000b004276c7b2253si3875943pgc.584.2023.01.27.03.29.40; Fri, 27 Jan 2023 03:29:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=H0K5FOoe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232456AbjA0L2n (ORCPT + 99 others); Fri, 27 Jan 2023 06:28:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231937AbjA0L20 (ORCPT ); Fri, 27 Jan 2023 06:28:26 -0500 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA6D878ADD; Fri, 27 Jan 2023 03:27:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674818829; x=1706354829; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=JG73C6HLxgRYzOPAld+BfeRoEIwbS9sLX9ctvZGPeLM=; b=H0K5FOoe4iyazL+asZex1R1ra8AdcbBZ+1fDwyt7jhY/mXU5eOKNFNml zr7eXLo6xXozXNka8CliR18h2ppBYTBhP1JKbbVXAfnu0J3bniNsKkmcJ QGEU1/LXydUo0ukYhLzRhFF6DtdA/GG4XrXxhsVQdyya0uAvXo5iS0bLU dgEVgbeSs+PGy2XV7aWwZGwD69rrNCxIFCl6me+JSiFI5R32X8+pMUASc H/w9M3X2Wgt59OxjXwqW0H58uSUzqSWW1YIX2UqzgcpJa12anfjT5uobM a40n3I+QMotXyZ/egM5HvYbtujyting+FSNplh1EUT7xEhOBcJ9WytYyj w==; X-IronPort-AV: E=McAfee;i="6500,9779,10602"; a="315020387" X-IronPort-AV: E=Sophos;i="5.97,250,1669104000"; d="scan'208";a="315020387" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2023 03:26:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10602"; a="665216227" X-IronPort-AV: E=Sophos;i="5.97,250,1669104000"; d="scan'208";a="665216227" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga007.fm.intel.com with ESMTP; 27 Jan 2023 03:26:41 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 1C8E6152; Fri, 27 Jan 2023 13:27:18 +0200 (EET) From: Andy Shevchenko To: Greg Kroah-Hartman , =?utf-8?b?SsOzIMOBZ2ls?= =?utf-8?b?YSBCaXRzY2g=?= , Andy Shevchenko , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 1/1] usg: gadget: Move validation out of lock in webusb_bcdVersion_store() Date: Fri, 27 Jan 2023 13:26:38 +0200 Message-Id: <20230127112638.84806-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756175000432377415?= X-GMAIL-MSGID: =?utf-8?q?1756175000432377415?= Validation has nothing to do with any protected data, move it out of the lock and make code neater. Signed-off-by: Andy Shevchenko --- drivers/usb/gadget/configfs.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c index 63dc15b4f6d8..1346b330b358 100644 --- a/drivers/usb/gadget/configfs.c +++ b/drivers/usb/gadget/configfs.c @@ -836,19 +836,15 @@ static ssize_t webusb_bcdVersion_store(struct config_item *item, if (ret) return ret; - mutex_lock(&gi->lock); - ret = is_valid_bcd(bcdVersion); if (ret) - goto out; + return ret; + mutex_lock(&gi->lock); gi->bcd_webusb_version = bcdVersion; - ret = len; - -out: mutex_unlock(&gi->lock); - return ret; + return len; } static ssize_t webusb_bVendorCode_show(struct config_item *item, char *page)