From patchwork Fri Jan 27 10:40:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 49181 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp763662wrn; Fri, 27 Jan 2023 02:42:58 -0800 (PST) X-Google-Smtp-Source: AK7set/SieOb2r7T1AR9lCHnYZYe9pJxF2oBcNt45I9KHawYBPZN1lIiwymYfFUg/bTfA3O037Tp X-Received: by 2002:a17:902:f353:b0:196:3d96:7f9f with SMTP id q19-20020a170902f35300b001963d967f9fmr3856910ple.17.1674816178044; Fri, 27 Jan 2023 02:42:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674816178; cv=none; d=google.com; s=arc-20160816; b=LR2Mqg+miuDXhru4/8UPMB5/gUZarl6I0zMSPBypWzf1++r9zc7/OhgJkiMrSnLBVh L32czJA5i4Nhean9t/0Qbe6YVUm10ieB6jJXDKj+K/Ihlyis9oCK8dp5uGxx0uzfpjkT wjZYc8FoPJkT8OKJvZIemOM5iMcXXmPtuRazI5HM50x11GUP2pbJ8RlP+AeYOs5ApEE7 9wxdijnxpaAb5vWM2/YqtlPtyE28Vp8hd/+GNNwHuetEHfJ+/aHLjCYKa59MDe1d49Cv OcYzECXkE5A8Ig8cfhI32ZHiCi0/Xwb5NOT53b+5+Jnjpi6z6HA0EekizD54iDvj7XK4 CKqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ZtVH5VgAz17FnfQMHHRW9JT+QmfExCAJP9BmlGuNLdk=; b=ws3nDxLSk4KN4Yz7xzchV0Lc9Ykdi6veJv3a+LlVI9MCnB+4+VBWal/qMSJpVixQzR NVl4yqLoYQFdx/9Ch//qVA888R+mjTpRpyjHfbm/D2Aoz4KBqRBzfrbs2bDvmqey7KM2 LhkwSo8hwegWTfvMfSiFH7wGfBy9dxuJr8VviuHnBQJh36jaeWvoFOJt3ef0ddgVQGs3 Lclgjjziy8NnZW1PKJAayw814lj476o9s1oMhT/tODR2FDn+hJAXpaS1s6//VBSjM+Ap /4BE6qTqTZB+RFHZk/jxYY6K639c5ZXUW8QIjETcxSwVJ9ARHilgPWe8HYF3r7CHdn3u 588A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fjlWBHiE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bc7-20020a170902930700b001895e356f00si4147898plb.152.2023.01.27.02.42.45; Fri, 27 Jan 2023 02:42:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fjlWBHiE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232021AbjA0KlH (ORCPT + 99 others); Fri, 27 Jan 2023 05:41:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232140AbjA0Kkl (ORCPT ); Fri, 27 Jan 2023 05:40:41 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CDEE9EFB for ; Fri, 27 Jan 2023 02:40:35 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id fl11-20020a05600c0b8b00b003daf72fc844so5124730wmb.0 for ; Fri, 27 Jan 2023 02:40:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZtVH5VgAz17FnfQMHHRW9JT+QmfExCAJP9BmlGuNLdk=; b=fjlWBHiEpuzwg1d05jkEHFOO/cM62PXN6MfAnanzh0WVouI5K1EP7NIOujlWeVVYCC VTuLyWEhTIzqC3hAyKNAwnmCTQ5eRY7vFVirjg0hREvRyKVjhzWj9yIXnz/b6lQc/W5j PX2rlZJ39UP/UoVz0nyQOznwoiCKMsrlO466j4HC45x9tA+lR1Ny8DmOEDSwqoIRV+3D 95C4Jl3SVb676lJRQV8DU9g5FjtdoRrwTiU7feUCX4Kj3qjoSz5Tt4SsUXW2JOYw/d8A DINQcgY3wNLzxl3XVv6BSs1fv6y0zZhBWVtcgTL0fHh4s52Y+V8X4xLoRU+fYWGThbe7 y57w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZtVH5VgAz17FnfQMHHRW9JT+QmfExCAJP9BmlGuNLdk=; b=InJ39XFaQNkYjhjzWpCVH36MLy8fuTl4/UcJKkkig/+a7doy2pO5QlvISnm9YBSla1 bj70f8bssOSLKEAFgWhNWtucEY03/ySYgZctY2IQsIkPutuFFKLytZZFHAWWQNxs+Og6 fxslyP5LPqzzIIk7a8EF3L/2jSrTG3bbBdKVt/yoFO/gGmS2Fck+aH1JYoNHMmWmbP6q ji1y69et2TyLvc1uVUGggA3uLiAsihmk7eefzeH5imtnQF20PrKEl4B5VqQ4dYR+1Q7C so63/dyOvQUc4UFq4hTvgkNnEWa1+maxibrdBXyW3+6Y3b3EoBfbc2/XROqBYpXKCmjv V8Nw== X-Gm-Message-State: AFqh2ko2KhdS1qG2QQqiR2/Y6G12rlAfAQEOKeY5zuZAR09V3qO716an 76vaXpMC8/cXXvGCGHI3OXgElQ== X-Received: by 2002:a05:600c:1d22:b0:3d9:6bc3:b8b9 with SMTP id l34-20020a05600c1d2200b003d96bc3b8b9mr39648893wms.9.1674816034077; Fri, 27 Jan 2023 02:40:34 -0800 (PST) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id q9-20020a1ce909000000b003dc34edacf8sm1619787wmc.31.2023.01.27.02.40.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jan 2023 02:40:33 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, "Russell King (Oracle)" , stable@vger.kernel.org, kernel test robot , Dan Carpenter , Srinivas Kandagatla Subject: [PATCH 09/10] nvmem: core: fix return value Date: Fri, 27 Jan 2023 10:40:14 +0000 Message-Id: <20230127104015.23839-10-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230127104015.23839-1-srinivas.kandagatla@linaro.org> References: <20230127104015.23839-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756172048499080686?= X-GMAIL-MSGID: =?utf-8?q?1756172048499080686?= From: "Russell King (Oracle)" Dan Carpenter points out that the return code was not set in commit 60c8b4aebd8e ("nvmem: core: fix cleanup after dev_set_name()"), but this is not the only issue - we also need to zero wp_gpio to prevent gpiod_put() being called on an error value. Cc: stable@vger.kernel.org Reported-by: kernel test robot Reported-by: Dan Carpenter Fixes: 60c8b4aebd8e ("nvmem: core: fix cleanup after dev_set_name()") Signed-off-by: Russell King (Oracle) Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 563116405b3d..34ee9d36ee7b 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -783,6 +783,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) GPIOD_OUT_HIGH); if (IS_ERR(nvmem->wp_gpio)) { rval = PTR_ERR(nvmem->wp_gpio); + nvmem->wp_gpio = NULL; goto err_put_device; }