diff mbox series

regulator: max20411: Convert to i2c's .probe_new()

Message ID 20230127101726.1313927-1-u.kleine-koenig@pengutronix.de
State New
Headers
Series regulator: max20411: Convert to i2c's .probe_new() |

Commit Message

Uwe Kleine-König Jan. 27, 2023, 10:17 a.m. UTC 
  The probe function doesn't make use of the i2c_device_id * parameter so
it can be trivially converted.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
There is an ongoing effort to convert all drivers to .probe_new to
eventually drop .probe with the i2c_device_id parameter. This driver
currently sits in next so wasn't on my radar before.

My plan is to tackle that after the next merge window. So I ask you to
either apply this patch during the next merge window or accept that it
will go in via the i2c tree together with the patch that drops .probe().
---
 drivers/regulator/max20411-regulator.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Mark Brown Jan. 28, 2023, 10:48 a.m. UTC | #1 
On Fri, 27 Jan 2023 11:17:26 +0100, Uwe Kleine-König wrote:
> The probe function doesn't make use of the i2c_device_id * parameter so
> it can be trivially converted.
> 
> 

Applied to

   broonie/regulator.git for-next

Thanks!

[1/1] regulator: max20411: Convert to i2c's .probe_new()
      commit: fad8ddda1c40c00bff4ac45eb9b85e1f717f17f4

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/drivers/regulator/max20411-regulator.c b/drivers/regulator/max20411-regulator.c
index b4faad54c458..e75d16048e2f 100644
--- a/drivers/regulator/max20411-regulator.c
+++ b/drivers/regulator/max20411-regulator.c
@@ -96,8 +96,7 @@  static const struct regulator_desc max20411_desc = {
 	.n_ramp_values = ARRAY_SIZE(max20411_slew_rates),
 };
 
-static int max20411_probe(struct i2c_client *client,
-			  const struct i2c_device_id *id)
+static int max20411_probe(struct i2c_client *client)
 {
 	struct regulator_init_data *init_data;
 	struct device *dev = &client->dev;
@@ -156,7 +155,7 @@  static struct i2c_driver max20411_i2c_driver = {
 		.name = "max20411",
 		.of_match_table	= of_max20411_match_tbl,
 	},
-	.probe = max20411_probe,
+	.probe_new = max20411_probe,
 	.id_table = max20411_id,
 };
 module_i2c_driver(max20411_i2c_driver);