From patchwork Thu Jan 26 23:54:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gavin Shan X-Patchwork-Id: 48979 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp554011wrn; Thu, 26 Jan 2023 16:03:02 -0800 (PST) X-Google-Smtp-Source: AMrXdXv/7JHkVoblv8ZWq+SJz30FEhbSKyUHXbXTPAyElSjOAH4+qFSIi2qQ5yA8+mCtQKa4tfiW X-Received: by 2002:a05:6402:2315:b0:49e:6a70:d9a6 with SMTP id l21-20020a056402231500b0049e6a70d9a6mr28110415eda.25.1674777782616; Thu, 26 Jan 2023 16:03:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674777782; cv=none; d=google.com; s=arc-20160816; b=0xkyvNeBMsXYerXh0EnmUCcl/FCQKyGqREcW8FFAvVbjCW/vhgHfLVCzC4porzBmM7 W82A623aA/DKGPO3ZPyvYS4dtCEYVz04Uz0V6m1ny3NyZAXCoViigxrK3yGOOxL6sMn2 tGKH4PZ0GcKUyZTIPpkD8crzMkGE1ESEzFpT5xuisR2d5WnbHqYJ//3wWetghNcFrJ0q tMNLruWft99Ctg30T628TnKRgGJY8scC06FOvc7QmmLFnS72bX4cPzizZ8YloGxKDQ3v G8DmrbR4gSmrYX1Szcx8v9nY9e2o4J3Nlfg8V+vYQVfBalcWvICpEwIMECuJ6/J0PH9/ 7Rpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=v0k2LdruntFpx2ttdih4bIPnTl7L9WM09WTVFT9+2zo=; b=o2fbVeplS4gaIJVOKx4cRPQevjIcxCnEmy8+kHF06WP8v8+TeybmCHr5VGyVmo9Rlg +zNQFSssPaxeehFpSAqT4WQFy+Q+TyT1uZfYxdc0k0oZ+pz2EIjD57nUOzlySlWlOKOI xiXna++52XvpR/+9ERpXp4+EmUZ/CUMuISDTGJOFnjzr5w2w7yjy4rso/JOzdMxRsno+ ILF5D58Ut3q1R2tWPLiHUbsyMuv5MLcx07mlY8vrhQxurKh5xlfvONLP5FNULd2CwocB NsaQe29XpJ36W/LCQS0Q3iKfGkVUnCeVqOPGGNOBK5Bpi4pz3Ky8hf0IJ7DgOsQxqFT7 vUIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OjNmufZ0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 17-20020a170906019100b0087124db83a3si2601551ejb.880.2023.01.26.16.02.38; Thu, 26 Jan 2023 16:03:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OjNmufZ0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233598AbjAZX4a (ORCPT + 99 others); Thu, 26 Jan 2023 18:56:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233321AbjAZX41 (ORCPT ); Thu, 26 Jan 2023 18:56:27 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AB534CE4E for ; Thu, 26 Jan 2023 15:55:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674777336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v0k2LdruntFpx2ttdih4bIPnTl7L9WM09WTVFT9+2zo=; b=OjNmufZ053qBzYVZgm2SF+9dHV9ohFQp6Y9OgwUiqJzJiyTVjL/Ef9dtMPmW8J/+JsdMZ1 IOeq6AE9OJ0xnrPvr8equOMntluO0CGDH5ewzfB0E/ButktTY23bCAww3VO9nWvdsij500 1kKD9JhlV7CpYM1nVZ56S1vmiculsG8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-437-iM7GUvV8N3iESEj2vdfZOQ-1; Thu, 26 Jan 2023 18:55:30 -0500 X-MC-Unique: iM7GUvV8N3iESEj2vdfZOQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2AA8618811F6; Thu, 26 Jan 2023 23:55:29 +0000 (UTC) Received: from gshan.redhat.com (vpn2-54-98.bne.redhat.com [10.64.54.98]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D8E6D2166B26; Thu, 26 Jan 2023 23:55:21 +0000 (UTC) From: Gavin Shan To: kvmarm@lists.linux.dev Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, pbonzini@redhat.com, corbet@lwn.net, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, yuzhe@nfschina.com, isaku.yamahata@intel.com, seanjc@google.com, ricarkol@google.com, eric.auger@redhat.com, renzhengeek@gmail.com, reijiw@google.com, shan.gavin@gmail.com Subject: [PATCH v3 3/4] KVM: arm64: Allow no running vcpu on restoring vgic3 LPI pending status Date: Fri, 27 Jan 2023 07:54:50 +0800 Message-Id: <20230126235451.469087-4-gshan@redhat.com> In-Reply-To: <20230126235451.469087-1-gshan@redhat.com> References: <20230126235451.469087-1-gshan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756131787953774463?= X-GMAIL-MSGID: =?utf-8?q?1756131787953774463?= We don't have a running VCPU context to restore vgic3 LPI pending status due to command KVM_DEV_ARM_{VGIC_GRP_CTRL, ITS_RESTORE_TABLES} on KVM device "kvm-arm-vgic-its". Use vgic_write_guest_lock() to restore vgic3 LPI pending status. Signed-off-by: Gavin Shan Reviewed-by: Oliver Upton --- Documentation/virt/kvm/api.rst | 8 +++++--- arch/arm64/kvm/vgic/vgic-v3.c | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst index 9807b05a1b57..40ada313faa3 100644 --- a/Documentation/virt/kvm/api.rst +++ b/Documentation/virt/kvm/api.rst @@ -8070,9 +8070,11 @@ considering the state as complete. VMM needs to ensure that the dirty state is final and avoid missing dirty pages from another ioctl ordered after the bitmap collection. -NOTE: One example of using the backup bitmap is saving arm64 vgic/its -tables through KVM_DEV_ARM_{VGIC_GRP_CTRL, ITS_SAVE_TABLES} command on -KVM device "kvm-arm-vgic-its" when dirty ring is enabled. +NOTE: Multiple examples of using the backup bitmap: (1) save vgic/its +tables through command KVM_DEV_ARM_{VGIC_GRP_CTRL, ITS_SAVE_TABLES} on +KVM device "kvm-arm-vgic-its". (2) restore vgic/its tables through +command KVM_DEV_ARM_{VGIC_GRP_CTRL, ITS_RESTORE_TABLES} on KVM device +"kvm-arm-vgic-its". vgic3 LPI pending status is restored. 8.30 KVM_CAP_XEN_HVM -------------------- diff --git a/arch/arm64/kvm/vgic/vgic-v3.c b/arch/arm64/kvm/vgic/vgic-v3.c index 5dfbd03e5e1a..c94e4d7520fc 100644 --- a/arch/arm64/kvm/vgic/vgic-v3.c +++ b/arch/arm64/kvm/vgic/vgic-v3.c @@ -338,7 +338,7 @@ int vgic_v3_lpi_sync_pending_status(struct kvm *kvm, struct vgic_irq *irq) if (status) { /* clear consumed data */ val &= ~(1 << bit_nr); - ret = kvm_write_guest_lock(kvm, ptr, &val, 1); + ret = vgic_write_guest_lock(kvm, ptr, &val, 1); if (ret) return ret; }