From patchwork Thu Jan 26 21:51:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Keith Busch X-Patchwork-Id: 48928 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp520592wrn; Thu, 26 Jan 2023 14:32:58 -0800 (PST) X-Google-Smtp-Source: AK7set/yWSvePdBtZKjfjJVQsnTaQxB6zgY35PYSnAcQNXOPrbrBfWH82rsSeyQP9TSSX6zVM48j X-Received: by 2002:a17:902:ce8b:b0:196:3672:f250 with SMTP id f11-20020a170902ce8b00b001963672f250mr6464473plg.24.1674772378155; Thu, 26 Jan 2023 14:32:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674772378; cv=none; d=google.com; s=arc-20160816; b=GZOoiFCyVVeS1kZl7vLzSx9axUgAlEr8L1mrtG/poy3Et8nnv4Iz2wcK5UdGiWYFui KBxztGL4wpRxDg4/wlBbO3WAzWovNq3wXAO5Oq7k3uno/4wB+sH9kRRBgEBGfiI/gt8A O70xlrHlZFnDt4QmiEhem8/NsW7gcvhvmDxi3iSBOu+3hWAzmPm/BRglbu92z+neE6fL qtpuftxw9SSG/DLYVsuhIhY+9mYkIgMR+mGM1JFHbHH2xHJAt70+TG8JIWEz6fcaw3QU R5chu8wTgUbjT5n9M7F0zWLyZDNHloRg2eGHyKTpXmLXLOHLAuTVu1jtNbHPWpox+eMp bZtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=3bZHL2Z78cKAF6RylfMcYGJJt43dfPQsNy0PbvPE3is=; b=abi7RHNiJsKul7CX7Es1WQwwmqzoa2Gyydr9dVFKlBXNjJKQVce1RvsOBaJKrGBGTL PO1csXEeZjwUM9D6OW3RNeFxoHd4q+T0jvTBdhtvhGUFTmhq7zK9prpw4NEHSZn2HebR Lc2eCHG552dzO0kaTbz0j1LjMbzUK+MPd5XT45kqQ2nYYuhTsEPLHkNJVpHglc0nlxYk GxxtOxR5oZEddcF7N7eMLQG+koBDjFUHju20b5TJKWFf0KcaDyga0NvNfgg0zuNhVm1i jzODGj99kw45vCAYUf47B6c2a2x6dxDFD5VHDYDyO2wXChf2mFJbgPJg3+uZE5u9QjbR /JNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@meta.com header.s=s2048-2021-q4 header.b=lVrUtV7e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=meta.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j4-20020a170903028400b00194548ad2c9si2794804plr.61.2023.01.26.14.32.44; Thu, 26 Jan 2023 14:32:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@meta.com header.s=s2048-2021-q4 header.b=lVrUtV7e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=meta.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233153AbjAZVzE (ORCPT + 99 others); Thu, 26 Jan 2023 16:55:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233006AbjAZVyp (ORCPT ); Thu, 26 Jan 2023 16:54:45 -0500 Received: from mx0a-00082601.pphosted.com (mx0b-00082601.pphosted.com [67.231.153.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80F5A21A14 for ; Thu, 26 Jan 2023 13:54:43 -0800 (PST) Received: from pps.filterd (m0001303.ppops.net [127.0.0.1]) by m0001303.ppops.net (8.17.1.19/8.17.1.19) with ESMTP id 30QJ9NFV028224 for ; Thu, 26 Jan 2023 13:54:42 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meta.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=s2048-2021-q4; bh=3bZHL2Z78cKAF6RylfMcYGJJt43dfPQsNy0PbvPE3is=; b=lVrUtV7eIfA+pTjKwQ4ayJK+j8lGNrnWZANTogfISnYDcFY9OF80Vn5S04uuKHS/jvMb EeIGIEZdjrEWbgNpuS8LBQAaHrWV0XYxLUVb/6Ed1igPwjGL2oDsIWOAwyfA9vMPoAg/ FSab2TSFYmid8os9V6E+9I8CkMTsyXS9OMoypXZdyoOYM+Eh4FSii6xiMosOSPIu8Ugm Fe4yICWSigw/3zCpzzISOciiyvIN1f0JvD8MxwEtigJPCeUM4eEqHqzxGcg0HvCEt4Qy y3+QrA+qmX6r+kanWgp4UYVU9/3jM5IO4hErIm4/A4RrjzXCeXZNVhz5SakVnWoRMigx Sw== Received: from maileast.thefacebook.com ([163.114.130.16]) by m0001303.ppops.net (PPS) with ESMTPS id 3nbe8yye5c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 26 Jan 2023 13:54:42 -0800 Received: from twshared1408.04.ash8.facebook.com (2620:10d:c0a8:1b::d) by mail.thefacebook.com (2620:10d:c0a8:82::e) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Thu, 26 Jan 2023 13:54:41 -0800 Received: by devbig007.nao1.facebook.com (Postfix, from userid 544533) id 72918FE80AA6; Thu, 26 Jan 2023 13:51:26 -0800 (PST) From: Keith Busch To: , , , , , CC: , Keith Busch Subject: [PATCHv4 12/12] dmapool: create/destroy cleanup Date: Thu, 26 Jan 2023 13:51:25 -0800 Message-ID: <20230126215125.4069751-13-kbusch@meta.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230126215125.4069751-1-kbusch@meta.com> References: <20230126215125.4069751-1-kbusch@meta.com> MIME-Version: 1.0 X-FB-Internal: Safe X-Proofpoint-ORIG-GUID: CmWiZxWWIwo4IzqQFJFLEKuRryx8QaqQ X-Proofpoint-GUID: CmWiZxWWIwo4IzqQFJFLEKuRryx8QaqQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-26_09,2023-01-26_01,2022-06-22_01 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756126121643830501?= X-GMAIL-MSGID: =?utf-8?q?1756126121643830501?= From: Keith Busch Set the 'empty' bool directly from the result of the function that determines its value instead of adding additional logic. Reviewed-by: Christoph Hellwig Signed-off-by: Keith Busch --- mm/dmapool.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/mm/dmapool.c b/mm/dmapool.c index bb8893b4f4b96..1920890ff8d3d 100644 --- a/mm/dmapool.c +++ b/mm/dmapool.c @@ -226,7 +226,7 @@ struct dma_pool *dma_pool_create(const char *name, struct device *dev, { struct dma_pool *retval; size_t allocation; - bool empty = false; + bool empty; if (!dev) return NULL; @@ -276,8 +276,7 @@ struct dma_pool *dma_pool_create(const char *name, struct device *dev, */ mutex_lock(&pools_reg_lock); mutex_lock(&pools_lock); - if (list_empty(&dev->dma_pools)) - empty = true; + empty = list_empty(&dev->dma_pools); list_add(&retval->pools, &dev->dma_pools); mutex_unlock(&pools_lock); if (empty) { @@ -350,7 +349,7 @@ static struct dma_page *pool_alloc_page(struct dma_pool *pool, gfp_t mem_flags) void dma_pool_destroy(struct dma_pool *pool) { struct dma_page *page, *tmp; - bool empty = false, busy = false; + bool empty, busy = false; if (unlikely(!pool)) return; @@ -358,8 +357,7 @@ void dma_pool_destroy(struct dma_pool *pool) mutex_lock(&pools_reg_lock); mutex_lock(&pools_lock); list_del(&pool->pools); - if (list_empty(&pool->dev->dma_pools)) - empty = true; + empty = list_empty(&pool->dev->dma_pools); mutex_unlock(&pools_lock); if (empty) device_remove_file(pool->dev, &dev_attr_pools);