From patchwork Thu Jan 26 18:24:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fedor Pchelkin X-Patchwork-Id: 48836 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp422889wrn; Thu, 26 Jan 2023 10:30:11 -0800 (PST) X-Google-Smtp-Source: AMrXdXtqycIJngj//ItMFU+BgLP1fym6Ll4SBErzlkEZKt6yB2c92Sl85kvF0YQu3s4G1EU6AdeS X-Received: by 2002:a17:907:cbc5:b0:7ad:9455:d57d with SMTP id vk5-20020a170907cbc500b007ad9455d57dmr40677750ejc.74.1674757810910; Thu, 26 Jan 2023 10:30:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674757810; cv=none; d=google.com; s=arc-20160816; b=XXRZ3vxlhi0HgFO1JjBZZ5V3pSdTEj+WLjZ3IQb+6n/dTsCmplBXri97+BLb/EY84+ fyZlWlO2UBrFS0fGzzaVbaf/t6efN4dCVNucrT6it/4G2K19/dzvckuwQmDvWJ+VJszS Cr7xM0WR/1ejSknnOuXM4qkKaL3g1QUYrjHQT+GYWU37GAU3nyOdn0JLwyv8nAfLKka8 oABLVWMhbDigGTFBd6Txo98g8UCmmkTdi3visoeWqLRfCHDYJcufSpX0XiH4n+LekOfJ wNndvHuQlb95nYdjGipWtLt3K2e6V2lKyZy7AszyIB/QRpArFIKqFRR+TmHRZyvekYdI BedQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-filter; bh=Afq4b2X8eBtK6SxOlqW9d62Bwf0KZ0SsOAymNkS7amw=; b=quwQPRP+0lpcZKt/mwI8+P6tAlLVVp2mPUm+qqyhjmNnkEQVUKXmE1osoZ4FabKGWe 7ardp9RdRwiaTvTek1zk8a8kIvMFpWkx8LpxjiqtHvB5a/SbJ4hXwbeitGWR4WvIoEa4 uxfjDO/bfeatvGyS8lyXbcnPhdwBlApq6rbVeHQpw8UtagopQH3RwdNCd/WZMiwYPW4C xswETI36phr39hPlsehS1JhcOeO2KvGoWpDag15OgXI0bom87aAk5AFwhV2G/HcYyxEz 6BG7EENINRmmCOKoLUtk7JTqbo+/78crvncAkVZ32rEeI+4RIPtxXhhE8CqNmb0kMe8t YJAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=kdpTNvL3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r25-20020a170906a21900b0085a483a6fd3si2107990ejy.209.2023.01.26.10.29.47; Thu, 26 Jan 2023 10:30:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=kdpTNvL3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231961AbjAZSZk (ORCPT + 99 others); Thu, 26 Jan 2023 13:25:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229721AbjAZSZj (ORCPT ); Thu, 26 Jan 2023 13:25:39 -0500 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2B1261869; Thu, 26 Jan 2023 10:25:26 -0800 (PST) Received: from fedcomp.intra.ispras.ru (unknown [46.242.14.200]) by mail.ispras.ru (Postfix) with ESMTPSA id C55AB44C1003; Thu, 26 Jan 2023 18:25:21 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru C55AB44C1003 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1674757521; bh=Afq4b2X8eBtK6SxOlqW9d62Bwf0KZ0SsOAymNkS7amw=; h=From:To:Cc:Subject:Date:From; b=kdpTNvL3PZpEagtlTlMTtFOwQbQ5HB+uXPkNZ5x+X29xL9t2yZpBXyJSIlJ7imTca gIO7l0btapr9pXKIe6Bi5HwqU60PseWBqrXsPbKwq5MAUbNRpIaxN5RUDaQZ4ptbzp TQZxFaGLQZr0s21HG4q4IUfLgwwgsVbTeEOf5VKg= From: Fedor Pchelkin To: Kalle Valo Cc: Fedor Pchelkin , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexey Khoroshilov , Oliver Neukum , Mohammed Shafi Shajakhan , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, syzbot+555908813b2ea35dae9a@syzkaller.appspotmail.com Subject: [PATCH] wifi: ath6kl: reduce WARN to dev_dbg() in callback Date: Thu, 26 Jan 2023 21:24:31 +0300 Message-Id: <20230126182431.867984-1-pchelkin@ispras.ru> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756110846465706387?= X-GMAIL-MSGID: =?utf-8?q?1756110846465706387?= The warn is triggered on a known race condition that is correctly handled. Using WARN() hinders automated testing. Reducing severity. Fixes: de2070fc4aa7 ("ath6kl: Fix kernel panic on continuous driver load/unload") Reported-and-tested-by: syzbot+555908813b2ea35dae9a@syzkaller.appspotmail.com Signed-off-by: Oliver Neukum Signed-off-by: Fedor Pchelkin Signed-off-by: Alexey Khoroshilov --- drivers/net/wireless/ath/ath6kl/htc_pipe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/htc_pipe.c b/drivers/net/wireless/ath/ath6kl/htc_pipe.c index c68848819a52..9b88d96bfe96 100644 --- a/drivers/net/wireless/ath/ath6kl/htc_pipe.c +++ b/drivers/net/wireless/ath/ath6kl/htc_pipe.c @@ -960,8 +960,8 @@ static int ath6kl_htc_pipe_rx_complete(struct ath6kl *ar, struct sk_buff *skb, * Thus the possibility of ar->htc_target being NULL * via ath6kl_recv_complete -> ath6kl_usb_io_comp_work. */ - if (WARN_ON_ONCE(!target)) { - ath6kl_err("Target not yet initialized\n"); + if (!target) { + ath6kl_dbg(ATH6KL_DBG_HTC, "Target not yet initialized\n"); status = -EINVAL; goto free_skb; }