Message ID | 20230126-rpi-display-fw-clk-cleanup-v1-2-d646ff6fb842@cerno.tech |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp384938wrn; Thu, 26 Jan 2023 09:11:33 -0800 (PST) X-Google-Smtp-Source: AMrXdXvuso8d6mZccmR4atuOgLE0sRHbmsKd3bboE4F2P2H3z4HPVTOw9AdVhluFPU7ajiHcwIEG X-Received: by 2002:a05:6a20:e610:b0:9d:efbf:787d with SMTP id my16-20020a056a20e61000b0009defbf787dmr37716805pzb.50.1674753092641; Thu, 26 Jan 2023 09:11:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674753092; cv=none; d=google.com; s=arc-20160816; b=aFnUxADCxcX/5uWzoIOVVy4gnNpy9dKs22pl1/4LpwOM8Q/fKjrpKSblHVA0Q3hSp/ FIAdOvi9Vpz4ko2LX8Unj3g2rdTRSSo45HtVPoSKgHHEkmetDvMG3OhRtMvYJUlAHrRh EPPx6X5/P58V5fdmrpNKyh8Nbs4gzu1h9R8LJeoi8fIxEOrh600ZtHFL+zu3XLFLLQlr jMPvLkyybNO5ngP+j5RWTk7t7BvaWIzlpVs3fiLG4vrCHH8rKIxOulY12gnS4gZaZLw/ DAY8QPRDhCURxnaiXQb0/uajkNWE81V08sZdOfNq/s4nzvQd8bkF0jQAkUlNpaapE1Uh p1KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :feedback-id:dkim-signature:dkim-signature; bh=r8PfVgfg1/1/LZjTHHsJomA3Uy4NDG54RVBnB5RCyr0=; b=L7iV8DCl25D9vA3V8C/XCtodOSf1NHEx4N0mcgvHWqom7adLirk9TV2hkrKRLqx9E+ i7qf0sFIS+9pcnRkeuuH+HVeesj2UHoFskwGzZZ7l5Ai1w9U/9F46OZjKIp47+y2+nFc GI/1NKforjoY1BNpNwBj+ddYdLRA885++BPYozehjPtPBoNjWpf0r8UsoFIv+Tyruhbr NnDg8Yrm6IQHhkgNgMUcy5sDRI6ZWiPCqSMj8jiaWMJug/uR57wd/GEbzY9MbjZg2oWq 1zGqwwVMWYVSnDFVhh/B9vfp6NzdC/lSigEiBxqCeFlwOgnqf+w/A0SW5SUVlPCDzX/h W+mQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm1 header.b=iOMneerG; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=No8++D68; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t5-20020a639545000000b004deafa8f3b3si1529825pgn.739.2023.01.26.09.11.19; Thu, 26 Jan 2023 09:11:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm1 header.b=iOMneerG; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=No8++D68; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232095AbjAZRKQ (ORCPT <rfc822;lekhanya01809@gmail.com> + 99 others); Thu, 26 Jan 2023 12:10:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232300AbjAZRKM (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 26 Jan 2023 12:10:12 -0500 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5B98C646 for <linux-kernel@vger.kernel.org>; Thu, 26 Jan 2023 09:10:08 -0800 (PST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id D72865C0432; Thu, 26 Jan 2023 12:10:07 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 26 Jan 2023 12:10:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1674753007; x= 1674839407; bh=r8PfVgfg1/1/LZjTHHsJomA3Uy4NDG54RVBnB5RCyr0=; b=i OMneerGnFOg01mvXwYKOrilpgKgtN2YF2q43xZSo+mRI5twbkHDXaXIwgVSRouJ1 65p3JF8o+6q2GcOnyVyKOE9ebDL57uQv+Wx5hDz+78wX6b3JlwQSkOxuIArignc/ vQ+IUcQ63XwHhhr+fQW5sR9QLane19xyol7beemJQ/s+UGJqeHbwQe+f2gfb9qdq inswiE13VgzvaNEDKO9a9CFfz+uzqvi3DkYIPv732OwQtVkB/GKfc3dA5t7JEZ0n Ug/7qQ1atrz0+482puou0Z5zPYm9yFZ2TbVvGBGxT3tn37tO1S/GpJBUFPbbJ5oF oubgnACTLLlUM1FR1KIHA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1674753007; x= 1674839407; bh=r8PfVgfg1/1/LZjTHHsJomA3Uy4NDG54RVBnB5RCyr0=; b=N o8++D68TaOHuEuvEILXJr6z7O+49rKKa6vOCJokzIte38Etazwc2Z0cKXXgUnVTc +0ePT76lzAOjkNe8CQwvZ+5MeDDlY3yOTqZb1MtJKDAOWzQ938dgFcYtrKAKUxH1 P66yPIHyvn1EpG2o7fETP3vwB/z0uS5wr68+7FM6Q4NxjGejFRscHPFNSehMoFl3 PYbXDH3pT2huERw7/TjRjdggm9lkluX7yNkw+yf4KN+h5D3gG169UBSGjTT1fjiN UteSy9cS63SHYZgedZOLC3PkUkQZTcAEAe2higU8EcPyhBrD1nBWwcBTbEqKUsiX O6piMwtZbMR07AP/DpEMQ== X-ME-Sender: <xms:77PSY34L4Da-JcyF4G0JBy0cT_T_Xx3zkWXow9mCPX0bqIOiMMImlA> <xme:77PSY8401suvRE02LCLcvL77IrqsXsqusaGl_-bygdU7LR74mOD2EcOdtXZ2YyS7o kW7irSOUa5wQtifvPE> X-ME-Received: <xmr:77PSY-fn7YY0z3xA5W834UowgoD07OL6h2qIaGxi6BSthufeDPpsOpSc40I_wSOtnRWXVFww3vvpCkvI294Xy2nEP_0HLOMQNeCEyptfNxzR9Q> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddvgedgleekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffufggtgfgkfhfjgfvvefosehtjeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepvedvleeijeegvdekffehkeehieelhfeggfffheetkeeuledvtdeuffeh teeltdffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: <xmx:77PSY4KzfJGso5_D4piK_FfJQKFEQ-kUreJvvKKzuFcOw2TCkmuHyw> <xmx:77PSY7L-em_BXw6_t0dlrcCdC6fuuONyD5Tp7_LqERU34yHkulNwHA> <xmx:77PSYxz6MKGMl57AbWqauE6PIEU1AlmlFDgFeAFugmF47qVfr7C2vA> <xmx:77PSY0453PrdRCZeR5Bwf0m_pAZgZ4nIzIhSAfhGJXCi7IPZVA11tQ> Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 26 Jan 2023 12:10:06 -0500 (EST) From: Maxime Ripard <maxime@cerno.tech> Date: Thu, 26 Jan 2023 18:05:47 +0100 Subject: [PATCH 2/4] drm/vc4: hdmi: Enable power domain before setting minimum MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230126-rpi-display-fw-clk-cleanup-v1-2-d646ff6fb842@cerno.tech> References: <20230126-rpi-display-fw-clk-cleanup-v1-0-d646ff6fb842@cerno.tech> In-Reply-To: <20230126-rpi-display-fw-clk-cleanup-v1-0-d646ff6fb842@cerno.tech> To: Emma Anholt <emma@anholt.net>, Maxime Ripard <mripard@kernel.org>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Thomas Zimmermann <tzimmermann@suse.de>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard <maxime@cerno.tech> X-Mailer: b4 0.11.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2394; i=maxime@cerno.tech; h=from:subject:message-id; bh=kZGgOHx1L8Al+hD8WBITB+QjtYhPj3I6fD0qrBD3FhE=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMmXNn1cUXxw3eOl1Z/WXv/I+yunIH534lFG8zne6xJjdvNM YFi5uqOUhUGMi0FWTJElRth8SdypWa872fjmwcxhZQIZwsDFKQATyXRkZFh2WyvtZvbNrpbMb+3t7g eimY5tOa33UHp5oq7i21yDzzMYGfZccHvts+12IG9UNOdxnZVp0pudnAMat6oaL+R9fOGmMA8A X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756105899305671760?= X-GMAIL-MSGID: =?utf-8?q?1756105899305671760?= |
Series |
drm/vc4: hdmi: Firmware clocks cleanup
|
|
Commit Message
Maxime Ripard
Jan. 26, 2023, 5:05 p.m. UTC
On the RaspberryPi0-3, the HSM clock was provided by the clk-bcm2835
driver, but on the Pi4 it was provided by the firmware through the
clk-raspberrypi driver.
The clk-bcm2835 driver registers the HSM clock using the
CLK_SET_RATE_GATE flag that prevents any modification to the rate while
the clock is active.
This meant that we needed to call clk_set_min_rate() before our call to
pm_runtime_resume_and_get() since our runtime_resume implementation
needs to enable the HSM clock for the HDMI controller registers to be
functional.
However, the HSM clock is part of the HDMI power domain which might not
be powered prior to the pm_runtime_resume_and_get() call, so we could
end up changing the rate of the HSM clock while its power domain was
disabled.
We recently changed the backing driver for the RaspberryPi0-3 to
clk-raspberrypi though, which doesn't have such restrictions. We can
thus move the clk_set_min_rate() after our call to runtime_resume and
avoid the access while the power domain is disabled.
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
drivers/gpu/drm/vc4/vc4_hdmi.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
Comments
On 1/26/23 18:05, Maxime Ripard wrote: > On the RaspberryPi0-3, the HSM clock was provided by the clk-bcm2835 > driver, but on the Pi4 it was provided by the firmware through the > clk-raspberrypi driver. > > The clk-bcm2835 driver registers the HSM clock using the > CLK_SET_RATE_GATE flag that prevents any modification to the rate while > the clock is active. > > This meant that we needed to call clk_set_min_rate() before our call to > pm_runtime_resume_and_get() since our runtime_resume implementation > needs to enable the HSM clock for the HDMI controller registers to be > functional. > > However, the HSM clock is part of the HDMI power domain which might not > be powered prior to the pm_runtime_resume_and_get() call, so we could > end up changing the rate of the HSM clock while its power domain was > disabled. > > We recently changed the backing driver for the RaspberryPi0-3 to > clk-raspberrypi though, which doesn't have such restrictions. We can > thus move the clk_set_min_rate() after our call to runtime_resume and > avoid the access while the power domain is disabled. > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> > --- I'm not familiar with the RPi clock hierarchy but the commit message explains why a clk_set_min_rate() was needed before the pm_runtime_resume_and_get(), and why that isn't needed anymore after the switch to clk-raspberrypi driver. And certainly, the correct thing to do is to enable the power domain that a controller is part of, before attempting to change the rate for one of its clocks. So the patch looks good to me. Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index 98fa306dbd24..9dd722b9ae3a 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi.c +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c @@ -1466,6 +1466,12 @@ static void vc4_hdmi_encoder_pre_crtc_configure(struct drm_encoder *encoder, if (!drm_dev_enter(drm, &idx)) goto out; + ret = pm_runtime_resume_and_get(&vc4_hdmi->pdev->dev); + if (ret < 0) { + DRM_ERROR("Failed to retain power domain: %d\n", ret); + goto err_dev_exit; + } + /* * As stated in RPi's vc4 firmware "HDMI state machine (HSM) clock must * be faster than pixel clock, infinitesimally faster, tested in @@ -1488,13 +1494,7 @@ static void vc4_hdmi_encoder_pre_crtc_configure(struct drm_encoder *encoder, ret = clk_set_min_rate(vc4_hdmi->hsm_clock, hsm_rate); if (ret) { DRM_ERROR("Failed to set HSM clock rate: %d\n", ret); - goto err_dev_exit; - } - - ret = pm_runtime_resume_and_get(&vc4_hdmi->pdev->dev); - if (ret < 0) { - DRM_ERROR("Failed to retain power domain: %d\n", ret); - goto err_dev_exit; + goto err_put_runtime_pm; } ret = clk_set_rate(vc4_hdmi->pixel_clock, tmds_char_rate);